)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae8964e93c790e0463c39e641b0837aff3f4a942","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a134caf9_97084156","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":100},"updated":"2024-05-20 17:46:25.000000000","message":"Nit: line too long","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4414e0303819ca92cc2666595f51d63377abbb50","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"143fd99e_5ac2f0f9","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":56},"updated":"2024-05-20 17:47:31.000000000","message":"dependencies","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4414e0303819ca92cc2666595f51d63377abbb50","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"767408f6_6be7c0f1","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"updated":"2024-05-20 17:47:31.000000000","message":"targeted","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"23065e3c064e75a65fa6af7ab5573cf5f8a736dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4662a543_0d475caa","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":56},"in_reply_to":"143fd99e_5ac2f0f9","updated":"2024-05-21 08:21:15.000000000","message":"Done","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"23065e3c064e75a65fa6af7ab5573cf5f8a736dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0af9faa_91d17d8b","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"in_reply_to":"767408f6_6be7c0f1","updated":"2024-05-21 08:21:15.000000000","message":"Done","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"23065e3c064e75a65fa6af7ab5573cf5f8a736dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass rabbitmq apt preferences into kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the latest and targetted rabbitmq-server depencencies mismatch, kolla-toolbox will fail to build."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"```"},{"line_number":12,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aae95e9_ba452294","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":100},"in_reply_to":"a134caf9_97084156","updated":"2024-05-21 08:21:15.000000000","message":"Done","commit_id":"1cb107856e6be92e9df624a5e0fdb2a1b8a46ce2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"08e2f26ebfb9244419c358ed1ca251287d4026b3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"If the latest and targeted rabbitmq-server dependencies mismatch,"},{"line_number":10,"context_line":"kolla-toolbox will fail to build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"```"},{"line_number":13,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"},{"line_number":14,"context_line":"```"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #2066171"},{"line_number":17,"context_line":"Change-Id: I64e9442545d98364585e3c632ae9142cd6b4f9bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"902b213f_c9d3d3f7","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":3},"updated":"2024-05-24 10:33:16.000000000","message":"its better mention to read the bugreport for details","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f632e1a407608e93c419d1761c884cac2d81211b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the latest and targeted rabbitmq-server dependencies mismatch,"},{"line_number":10,"context_line":"kolla-toolbox will fail to build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"```"},{"line_number":13,"context_line":"rabbitmq-server : Depends: erlang-base (\u003e\u003d 1:26.0) but 1:25.3.2.12-1rmq1ppa1~ubuntu22.04.1 is to be installed"},{"line_number":14,"context_line":"```"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #2066171"},{"line_number":17,"context_line":"Change-Id: I64e9442545d98364585e3c632ae9142cd6b4f9bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5c7a44fd_1c4fe58a","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":3},"in_reply_to":"902b213f_c9d3d3f7","updated":"2024-06-04 10:21:36.000000000","message":"Ok, the bug is linked so I\u0027ll just drop this bit","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"08e2f26ebfb9244419c358ed1ca251287d4026b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4358c788_21e4bfd9","updated":"2024-05-24 10:33:16.000000000","message":"not sure if symlinks is a good idea here","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f632e1a407608e93c419d1761c884cac2d81211b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9e32e0b_b1610ebe","in_reply_to":"4358c788_21e4bfd9","updated":"2024-06-04 10:21:36.000000000","message":"Why not? We wouldn\u0027t want the preferences to differ between the toolbox and rabbitmq itself.","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"15e2893944c43662d35d119c97eec0ed39a6fd46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e4c8f336_df0ac598","in_reply_to":"90d6d3aa_24cb0304","updated":"2024-06-11 07:54:55.000000000","message":"Acknowledged","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ff347027db76e17d7c527ffbe0c39a035bbf263c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"90d6d3aa_24cb0304","in_reply_to":"c9c3cbc9_8fc3b1c1","updated":"2024-06-10 14:44:11.000000000","message":"The issue with a COPY is that the different service folders are out of scope during a build. So trying to copy into kolla-toolbox from rabbitmq fails with this error:\n\n` docker.errors.BuildError: COPY failed: forbidden path outside the build context: ../rabbitmq/apt_preferences_rabbitmq.debian`","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2368c56112349a467132bb82ad53f7fc02fff3c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9c3cbc9_8fc3b1c1","in_reply_to":"e9e32e0b_b1610ebe","updated":"2024-06-05 10:22:06.000000000","message":"I have no issues with symbolic links per se, but I do have some concerns about how it handles them. So, with a symbolic link in the repository, upon checkout you either get a text file with a reference to a full filesystem path, or a proper symbolic link, depending on the value of the core.symlinks config. Why not simply copy the file from the specified directory (like ../docker/base/ for example) ?","commit_id":"a29088ec3d3e5bea5b050aba65dede946a8b6931"}]}