)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d3614e1a16a2dc057eb4a1fabee26acdedaa0b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d692b300_3c0b6dae","updated":"2024-05-24 09:30:54.000000000","message":"recheck kolla-ansible should be green again (docker-py/requests breakage)","commit_id":"c871d7c0a1caa86e80253b9d6e7e7b921c74474c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"000b9f2ddde935a51dfcfaa4786db6be334c4b7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"990cea9a_83ad5ea9","updated":"2024-05-24 09:29:21.000000000","message":"we need this to fix publish jobs I guess:\n\nhttps://zuul.opendev.org/t/openstack/build/a42da15ee4c04698b9237bf8738c1ad4\n\ncurrently all publish jobs are in POST_FAILURE mode, due to:\n\nhttps://zuul.opendev.org/t/openstack/builds?project\u003dopenstack/kolla\n\n```\nINFO:kolla.common.utils:Using engine: docker\nINFO:kolla.common.utils:Found the container image folder at /tmp/kolla-virtualenv/share/kolla/docker\nERROR:kolla.common.utils:Unable to connect to container engine daemon, exiting\nINFO:kolla.common.utils:Exception caught: Error while fetching server API version: Not supported URL scheme http+docker\n```","commit_id":"c871d7c0a1caa86e80253b9d6e7e7b921c74474c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"281cc96417cb94e7cf1d2e08006a52e386753820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b1d10288_fd4a08b9","updated":"2024-05-28 10:47:19.000000000","message":"Fast approving as gate fix","commit_id":"968711579fbe73316227bd2b1993c5656adad9f4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f952e6d0d73c72287e9626b916228859084db003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fe3f8828_360c030d","updated":"2024-05-28 10:29:53.000000000","message":"Looks good. Needed to unbreak kayobe CI.","commit_id":"968711579fbe73316227bd2b1993c5656adad9f4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4f6125c9da1d097095914467e56284980f55f6fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e894bcad_157255ec","updated":"2024-05-28 08:55:00.000000000","message":"we actually do want to backport this for 2024.1","commit_id":"968711579fbe73316227bd2b1993c5656adad9f4"}],"kolla/image/build.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6d4fa5dab8e1f09cb18208df2639771bdb527c24","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \"but the Python library is not found.\""},{"line_number":121,"context_line":"                      \"Try running \u0027pip install docker\u0027\")"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        except AttributeError:"},{"line_number":124,"context_line":"            LOG.error(\"Error, Docker Python library is too old, \""},{"line_number":125,"context_line":"                      \"Try running \u0027pip install docker --upgrade\u0027\")"},{"line_number":126,"context_line":"        if conf.squash:"}],"source_content_type":"text/x-python","patch_set":7,"id":"841f8a9f_000b27b1","side":"PARENT","line":123,"updated":"2024-05-23 14:03:35.000000000","message":"I\u0027m not convinced we need this","commit_id":"25f357ecc81bc2ad25a1e1b2f549d6a4b755b638"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6feb70450bf2a589664742f1edcf3dd2862f54b","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \"but the Python library is not found.\""},{"line_number":121,"context_line":"                      \"Try running \u0027pip install docker\u0027\")"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        except AttributeError:"},{"line_number":124,"context_line":"            LOG.error(\"Error, Docker Python library is too old, \""},{"line_number":125,"context_line":"                      \"Try running \u0027pip install docker --upgrade\u0027\")"},{"line_number":126,"context_line":"        if conf.squash:"}],"source_content_type":"text/x-python","patch_set":7,"id":"b2ff3c18_975e0d71","side":"PARENT","line":123,"in_reply_to":"841f8a9f_000b27b1","updated":"2024-05-23 14:10:43.000000000","message":"well this was a compromise between documenting the supported versions or automatically installing something sufficient. I would prefer we just install a sufficient version ourselves if the user indicates they want to use docker we probably should just install the necessary lib, no?\n\nThen we can get rid of this.","commit_id":"25f357ecc81bc2ad25a1e1b2f549d6a4b755b638"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55bb2b4fa6bc69d0dfa68d86aae46d57ba246634","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                      \"but the Python library is not found.\""},{"line_number":121,"context_line":"                      \"Try running \u0027pip install docker\u0027\")"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        except AttributeError:"},{"line_number":124,"context_line":"            LOG.error(\"Error, Docker Python library is too old, \""},{"line_number":125,"context_line":"                      \"Try running \u0027pip install docker --upgrade\u0027\")"},{"line_number":126,"context_line":"        if conf.squash:"}],"source_content_type":"text/x-python","patch_set":7,"id":"029db63c_5a1d3533","side":"PARENT","line":123,"in_reply_to":"9b50ad43_4b7700c3","updated":"2024-05-27 19:06:40.000000000","message":"Done","commit_id":"25f357ecc81bc2ad25a1e1b2f549d6a4b755b638"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05113c0fe2c29a1925bf15f9730e02ba9399916e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \"but the Python library is not found.\""},{"line_number":121,"context_line":"                      \"Try running \u0027pip install docker\u0027\")"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        except AttributeError:"},{"line_number":124,"context_line":"            LOG.error(\"Error, Docker Python library is too old, \""},{"line_number":125,"context_line":"                      \"Try running \u0027pip install docker --upgrade\u0027\")"},{"line_number":126,"context_line":"        if conf.squash:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5522744b_184b6033","side":"PARENT","line":123,"in_reply_to":"9b50ad43_4b7700c3","updated":"2024-05-27 12:14:22.000000000","message":"ah, I\u0027ve been wondering what the \"docker.__version__\" line is good for. worth a comment that explains this I\u0027d say","commit_id":"25f357ecc81bc2ad25a1e1b2f549d6a4b755b638"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ded55091344d3f9749788b8e126c0a8f2612bb01","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \"but the Python library is not found.\""},{"line_number":121,"context_line":"                      \"Try running \u0027pip install docker\u0027\")"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        except AttributeError:"},{"line_number":124,"context_line":"            LOG.error(\"Error, Docker Python library is too old, \""},{"line_number":125,"context_line":"                      \"Try running \u0027pip install docker --upgrade\u0027\")"},{"line_number":126,"context_line":"        if conf.squash:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9b50ad43_4b7700c3","side":"PARENT","line":123,"in_reply_to":"b2ff3c18_975e0d71","updated":"2024-05-26 07:13:44.000000000","message":"actually we need to call anything from docker (like we do podman.__version__) so that pep8 doesn\u0027t barf","commit_id":"25f357ecc81bc2ad25a1e1b2f549d6a4b755b638"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05113c0fe2c29a1925bf15f9730e02ba9399916e","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            LOG.error(\"Error, you have set podman as container engine, \""},{"line_number":134,"context_line":"                      \"but library is not found.\""},{"line_number":135,"context_line":"                      \"Try running pip install podman\""},{"line_number":136,"context_line":"                      \"Python error: %s\", e)"},{"line_number":137,"context_line":"            exit(1)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    kolla \u003d KollaWorker(conf)"}],"source_content_type":"text/x-python","patch_set":11,"id":"15eb9bcb_d5b46d40","line":136,"updated":"2024-05-27 12:14:22.000000000","message":"dito","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55bb2b4fa6bc69d0dfa68d86aae46d57ba246634","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            LOG.error(\"Error, you have set podman as container engine, \""},{"line_number":134,"context_line":"                      \"but library is not found.\""},{"line_number":135,"context_line":"                      \"Try running pip install podman\""},{"line_number":136,"context_line":"                      \"Python error: %s\", e)"},{"line_number":137,"context_line":"            exit(1)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    kolla \u003d KollaWorker(conf)"}],"source_content_type":"text/x-python","patch_set":11,"id":"6250d58c_3d529d23","line":136,"in_reply_to":"15eb9bcb_d5b46d40","updated":"2024-05-27 19:06:40.000000000","message":"Done","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05113c0fe2c29a1925bf15f9730e02ba9399916e","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            LOG.error(\"Error, you have set Docker as container engine, \""},{"line_number":119,"context_line":"                      \"but the Python library is not found.\""},{"line_number":120,"context_line":"                      \"Try running \u0027pip install docker\u0027\""},{"line_number":121,"context_line":"                      \"Python error: %s\", e)"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        if conf.squash:"},{"line_number":124,"context_line":"            squash_version \u003d utils.get_docker_squash_version()"}],"source_content_type":"text/x-python","patch_set":12,"id":"5620f078_7cefee16","line":121,"updated":"2024-05-27 12:14:22.000000000","message":"IIUC this is one long string, not multiple lines, so you\u0027ll want to add some separation in front of the added message","commit_id":"152b349c68c7fa08199381116bc541134bb5387a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55bb2b4fa6bc69d0dfa68d86aae46d57ba246634","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            LOG.error(\"Error, you have set Docker as container engine, \""},{"line_number":119,"context_line":"                      \"but the Python library is not found.\""},{"line_number":120,"context_line":"                      \"Try running \u0027pip install docker\u0027\""},{"line_number":121,"context_line":"                      \"Python error: %s\", e)"},{"line_number":122,"context_line":"            sys.exit(1)"},{"line_number":123,"context_line":"        if conf.squash:"},{"line_number":124,"context_line":"            squash_version \u003d utils.get_docker_squash_version()"}],"source_content_type":"text/x-python","patch_set":12,"id":"615db0c7_bdf3135a","line":121,"in_reply_to":"5620f078_7cefee16","updated":"2024-05-27 19:06:40.000000000","message":"Done","commit_id":"152b349c68c7fa08199381116bc541134bb5387a"}],"tests/playbooks/pre.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05113c0fe2c29a1925bf15f9730e02ba9399916e","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":45,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":46,"context_line":"      loop:"},{"line_number":47,"context_line":"        - \"pip\""},{"line_number":48,"context_line":"        - \".\""},{"line_number":49,"context_line":"        - \"{{ \u0027docker\u0027 if container_engine \u003d\u003d \u0027docker\u0027 else \u0027podman\u0027 if container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4380353a_0c03f183","line":47,"updated":"2024-05-27 12:14:22.000000000","message":"Is this really needed? We didn\u0027t do this before and usually for reasonably managed distros the available pip version should be fine?","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e4eebc47e7723e04d240607f0f8c8b88c5b0f672","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":45,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":46,"context_line":"      loop:"},{"line_number":47,"context_line":"        - \"pip\""},{"line_number":48,"context_line":"        - \".\""},{"line_number":49,"context_line":"        - \"{{ \u0027docker\u0027 if container_engine \u003d\u003d \u0027docker\u0027 else \u0027podman\u0027 if container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b2c9e166_61db7b43","line":47,"in_reply_to":"4380353a_0c03f183","updated":"2024-05-28 04:09:13.000000000","message":"Done","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05113c0fe2c29a1925bf15f9730e02ba9399916e","unresolved":true,"context_lines":[{"line_number":46,"context_line":"      loop:"},{"line_number":47,"context_line":"        - \"pip\""},{"line_number":48,"context_line":"        - \".\""},{"line_number":49,"context_line":"        - \"{{ \u0027docker\u0027 if container_engine \u003d\u003d \u0027docker\u0027 else \u0027podman\u0027 if container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    - name: Configure Docker repo for Debian/Ubuntu"},{"line_number":52,"context_line":"      block:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"992b15d3_2312d891","line":49,"updated":"2024-05-27 12:14:22.000000000","message":"why not simply\n\n```\n  - \"{{ container_engine }}\"\n```\n\nwe do check allowed cases elsewhere, don\u0027t we?","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e4eebc47e7723e04d240607f0f8c8b88c5b0f672","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      loop:"},{"line_number":47,"context_line":"        - \"pip\""},{"line_number":48,"context_line":"        - \".\""},{"line_number":49,"context_line":"        - \"{{ \u0027docker\u0027 if container_engine \u003d\u003d \u0027docker\u0027 else \u0027podman\u0027 if container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    - name: Configure Docker repo for Debian/Ubuntu"},{"line_number":52,"context_line":"      block:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c96db30a_e7d90d96","line":49,"in_reply_to":"992b15d3_2312d891","updated":"2024-05-28 04:09:13.000000000","message":"Done","commit_id":"79cd818a67241534d56d878f835626fe37a74d79"}]}