)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"20ab948116c2d840c6b6ada65b7ee94873757b4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2401f9d4_bb8a8ccb","updated":"2024-06-28 13:16:39.000000000","message":"I know it\u0027s trivial, but it really needs a release note because it\u0027s fixing a bug in a release.","commit_id":"14c91037e6c18c0a92208bac42435540d800f367"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"75a2a21e3eec0adc58631bdd92e9b94ffe7545c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f579acb9_552ec56e","updated":"2024-06-28 13:24:37.000000000","message":"agreed on the missing reno.\n\nBut I also want to highlight that 6 people, including myself, didn\u0027t spot this in the initial review: https://review.opendev.org/c/openstack/kolla/+/887347\n\nand I blame large changesets for that. nobody has the mental endurance to really read 600 lines of code, without going into \"skimming mode\" and then we miss stuff like this.\n\nSo I hope we keep that in mind and strive for smaller changesets in general.\n\nThanks","commit_id":"14c91037e6c18c0a92208bac42435540d800f367"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"adc7cc9ffd0f2daf7bee31b6c50d00cb744a6387","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eed5c706_8e77b783","in_reply_to":"8a5e4587_f7302c2c","updated":"2024-06-28 13:49:11.000000000","message":"I don\u0027t want to derail the discussion here, so I won\u0027t answer about how to (not) split up patches.\n\nregarding the reno: is/was this user visible? I\u0027m really not sure.\n\nIf it\u0027s not user visible I agree with kevko that there is no point in a release note.","commit_id":"14c91037e6c18c0a92208bac42435540d800f367"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bae12ad300810a54ba7c95d47ce26352b6c3c219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a5e4587_f7302c2c","in_reply_to":"f579acb9_552ec56e","updated":"2024-06-28 13:27:26.000000000","message":"And how you can split patch which is refered as depends on in kolla-ansible ? So you need it for build an image ...to pass Kolla-ansible patch \n\nlistening","commit_id":"14c91037e6c18c0a92208bac42435540d800f367"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"78050544f6aba83806f57c019f35f2ffaf7f37d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9215e2b3_0c09175e","updated":"2024-06-28 14:57:48.000000000","message":"Trivial - no user facing impact.","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"71ae7323d508679786c50326ed5a8dd1c1561eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7f65e10_82ef7ee3","updated":"2024-06-28 13:54:14.000000000","message":"searching the codebsae neither`cinder_base_packages` nor `letsencrypt_base_packages` was used in any relevant codepath wrt let\u0027s encrypt, so I don\u0027t think we need a reno for this, this is more of a refactor/internal code cleanup than a user visible change imho.","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"78050544f6aba83806f57c019f35f2ffaf7f37d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f9c8665_5d768607","in_reply_to":"6435ebc3_bc10fe28","updated":"2024-06-28 14:57:48.000000000","message":"From a quick check, I think you\u0027re right. I don\u0027t see anything Cinder related in the base image.","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"86694495cd833a679963d37b251d8c77f9518d23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4f23e81_58dffc8e","in_reply_to":"c7f65e10_82ef7ee3","updated":"2024-06-28 14:03:43.000000000","message":"I largely agree, but for example, if someone has built letsencrypt Docker images locally, then they might want to rebuild them to remove the cinder packages, which is what the release note would tell them.","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"77ee5b66524cca19acce45ec3561734fb3904561","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6435ebc3_bc10fe28","in_reply_to":"e4f23e81_58dffc8e","updated":"2024-06-28 14:15:11.000000000","message":"afaik that package variable should be empty for LE base builds, but I can\u0027t currently test this, as my local dev env for kolla is broken (problems with distutils..)\n\nI would like to verify this though, as it might be valid.","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"}],"docker/letsencrypt/letsencrypt-base/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f8780fed56e19634faeb9c0115181fcdc04ee4da","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block letsencrypt_base_header %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"82801f68_5fa87a86","line":8,"updated":"2024-06-28 15:00:49.000000000","message":"nit: we don\u0027t need this any more, could be removed in a follow up","commit_id":"7aec3724809681a2cf68c0686b6b8e2d83dcd02f"}]}