)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\"additional_users\" allows to manage additional users specified by \u0027custom\u0027"},{"line_number":13,"context_line":"templates (passed with --docker-dir option) the same way as regular"},{"line_number":14,"context_line":"Kolla templates, i.e., by using \u0027configure_user\u0027 macros and specifying"},{"line_number":15,"context_line":"exact UID and GIU in kolla config file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"additional_source_projects\" serves the similar purpose, but relates to"},{"line_number":18,"context_line":"cloning extrenal projects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"26664b66_e41f2d31","line":15,"updated":"2024-07-22 15:24:26.000000000","message":"Did you mean GID?","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2c27bd55b94c01634167f95ddff3e2251483be9a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\"additional_users\" allows to manage additional users specified by \u0027custom\u0027"},{"line_number":13,"context_line":"templates (passed with --docker-dir option) the same way as regular"},{"line_number":14,"context_line":"Kolla templates, i.e., by using \u0027configure_user\u0027 macros and specifying"},{"line_number":15,"context_line":"exact UID and GIU in kolla config file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"additional_source_projects\" serves the similar purpose, but relates to"},{"line_number":18,"context_line":"cloning extrenal projects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2821c894_407abb32","line":15,"in_reply_to":"26664b66_e41f2d31","updated":"2024-07-25 09:57:35.000000000","message":"yes, thanks","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"additional_users\" allows to manage additional users specified by \u0027custom\u0027"},{"line_number":13,"context_line":"templates (passed with --docker-dir option) the same way as regular"},{"line_number":14,"context_line":"Kolla templates, i.e., by using \u0027configure_user\u0027 macros and specifying"},{"line_number":15,"context_line":"exact UID and GIU in kolla config file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"additional_source_projects\" serves the similar purpose, but relates to"},{"line_number":18,"context_line":"cloning extrenal projects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"13dbb9b5_8d7214da","line":15,"in_reply_to":"2821c894_407abb32","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":true,"context_lines":[{"line_number":15,"context_line":"exact UID and GIU in kolla config file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"additional_source_projects\" serves the similar purpose, but relates to"},{"line_number":18,"context_line":"cloning extrenal projects."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use-case: unification of deployment process by managing third-party"},{"line_number":21,"context_line":"services (which openstack upstream may not be interested) the same way"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dd61ec4f_88a4db87","line":18,"updated":"2024-07-22 15:24:26.000000000","message":"external","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"exact UID and GIU in kolla config file."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"additional_source_projects\" serves the similar purpose, but relates to"},{"line_number":18,"context_line":"cloning extrenal projects."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use-case: unification of deployment process by managing third-party"},{"line_number":21,"context_line":"services (which openstack upstream may not be interested) the same way"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cdfb390c_47118ea0","line":18,"in_reply_to":"dd61ec4f_88a4db87","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a54add32_9e88003d","updated":"2024-07-22 15:24:26.000000000","message":"An example in documentation with a use case would be nice.","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"10b9589bfd74f3c4f4bcecc56f466d119a2f3a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67f791d1_9d159cb5","updated":"2024-08-20 13:08:07.000000000","message":"Hi folks!\nThank you for your feedback, and I\u0027m sorry for disappearing for some time. I wanted to recheck everything as extending sources did work for my project.\nAfter digging deeper into Kolla\u0027s code, I found that `additional_source_projects` is unnecessary as Kolla automatically registers the sources section for an image when it was not registered in the kolla/common/config.py file - https://github.com/openstack/kolla/blob/18.1.0/kolla/image/kolla_worker.py#L665-L669. My original tests with `--docker-dir` failed due to configuration typos (the image used \u0027one-another\u0027 format versus config section was \u0027one_another\u0027).\n\nIf Kolla already performs section auto-registration for sources, does it make sense to do the same for users by extending https://github.com/openstack/kolla/blob/18.1.0/kolla/image/kolla_worker.py#L288-L289 without introducing new option `additional_users`:\n\n```diff\n             if match:\n-                user \u003d self.conf[match.group(0)]\n+                cfg_group_name \u003d match.group(0)\n+                if cfg_group_name not in self.conf._groups:\n+                    self.conf.register_opts(\n+                        common_config.get_user_opts(\n+                            None, None,\n+                            # cut `-user` suffix\n+                            group\u003dcfg_group_name[:-5]\n+                        ),\n+                        group\u003dcfg_group_name\n+                     )\n+                user \u003d self.conf[cfg_group_name]\n                 ret[match.group(0)[:-5]] \u003d {\n\n```\n\nThoughts?","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa35941f646c2cae2fe92715019bbed71e01612d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a07f0ac_8c7768c3","updated":"2024-07-22 15:52:21.000000000","message":"I\u0027m not convinced that this belongs into kolla, managing users that are out of the scope of kolla is IMO also out of scope for kolla","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a3ba7f7c8cc9c1ac4eccf3a5025060023e34317a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2555e20a_80dfa1e5","updated":"2024-08-13 12:29:07.000000000","message":"It would be nice to have some piece of documentation with examples available. Not all users read release notes or commit messages in git.","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f01b6e6e02089ff66cf078a0d36adc5eb74b548a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38d81460_db33bb1f","updated":"2024-08-08 09:14:32.000000000","message":"thanks for explaining your use case, I\u0027m still not 100% convinced that this should go into upstream, but if other reviewers do see this positive, at least I don\u0027t want to block it","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2c27bd55b94c01634167f95ddff3e2251483be9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6be0ece7_81fd4ce1","in_reply_to":"2a07f0ac_8c7768c3","updated":"2024-07-25 09:57:35.000000000","message":"As you have not put -2, I assume there is still a place for discussion :)\n\n\u003e I\u0027m not convinced that this belongs into kolla, managing users that are out of the scope of kolla is IMO also out of scope for kolla\n\nI would agree(maybe) if there were no \"--docker-dir\" option, but this option exists and provides an excellent extension potential for Kolla.\n\nLet me talk about my real-life use-case.\nI work for GoDaddy in a team that manages several OpenStack clouds using Kolla\u0026Kolla-Ansible (thanks for developing this great software). We created several microservices to integrate OpenStack into our infrastructure and cover inner business logic. There are several ways to implement the deployment/management of those external services/tools, such as writing separate build \u0026 deployment processes (i.e., standalone way) or unifying the processes \u0026 workflow. We decided to go with the second option - manage the whole cloud, all OpenStack-related things, in a single way.\nCurrently, we have a patched version of Kolla that allows us to have a single Jenkins job for building docker images with Kolla for any OpenStack-specific service. The patches add templates for new services, and those templates were implemented just by taking existing templates from upstream as examples and adapting them to our needs; that is why they are using all of Kolla\u0027s macros, particularly the one for setting users. I think there is no need to explain why patching is terrible in terms of maintenance pain and the potential temptation not to contribute even bug fixes to the upstream.\nFrom time to time, I check for ways to get rid of patched products, and the recent discovery of the \"--docker-dir\" option excited me that I could keep managing \"external\" services with Kolla but get rid of \u0027patching\u0027.\nYes, I understand that I still can rewrite \"my\" custom templates to avoid \u0027configure_user\u0027 macros usage, but imo, this has a huge downside - the introduction of several implementations and sources of truth, not to mention the style difference. To avoid the problem with several sources of truth, I would add a wrapper to split \"users.yaml\" and put a part of the data in Kolla\u0027s config and another in template_override. This adds extra complexity, which I would like to avoid but consolidates user-configuration into one place that suits as a source of truth at least.\n\n\u003e managing users that are out of the scope of kolla is IMO also out of scope for kolla\n\nwhat about sources? :)","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c2018ff0b1e60815cd0e3c105dbe34620abd91f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e73b8818_8e1c9335","updated":"2024-09-17 11:58:57.000000000","message":"I\u0027ve been using this feature for a while, no side-effects so far. Code and UX are significantly simplified from the initial revision. The documentation is extended with info about ``--docker-dir`` option","commit_id":"45fdaf6ae07a346bfd0cecde4f2d3b9e99811cc8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1585c5cd6b7a7015a000c8882777c31cd3524825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c0ebe3d0_7869dccf","updated":"2025-02-06 12:37:48.000000000","message":"Any chance to get another round of review?","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cfdde74dd34e6ea859153108b3576dd723e8ca39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7a8809ab_a647b581","updated":"2025-02-08 09:12:16.000000000","message":"thank you! documentation is fixed","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cb4fd190eeace9050344be441b8112461d1426b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"488ff769_5434f1f7","updated":"2025-02-18 09:46:33.000000000","message":"thanks","commit_id":"cfa266a3a2fd2f29ba48ecb93018197af5510649"}],"doc/source/admin/image-building.rst":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c8943eeb5d30dce51cec79e91cd2cf90f18e9c87","unresolved":true,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"First, create a ``Dockerfile.j2`` template for the project."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":".. path /home/kolla/custom-kolla-docker-templates/Dockerfile.j2"},{"line_number":501,"context_line":".. code-block:: jinja"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"}],"source_content_type":"text/x-rst","patch_set":8,"id":"de8404d2_aef92eab","line":500,"range":{"start_line":500,"start_character":49,"end_line":500,"end_character":50},"updated":"2025-02-07 21:44:26.000000000","message":"/releaser/","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cfdde74dd34e6ea859153108b3576dd723e8ca39","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"First, create a ``Dockerfile.j2`` template for the project."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":".. path /home/kolla/custom-kolla-docker-templates/Dockerfile.j2"},{"line_number":501,"context_line":".. code-block:: jinja"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"}],"source_content_type":"text/x-rst","patch_set":8,"id":"63b9843d_53c8c7aa","line":500,"range":{"start_line":500,"start_character":49,"end_line":500,"end_character":50},"in_reply_to":"de8404d2_aef92eab","updated":"2025-02-08 09:12:16.000000000","message":"fixed","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c8943eeb5d30dce51cec79e91cd2cf90f18e9c87","unresolved":true,"context_lines":[{"line_number":536,"context_line":".. path /etc/kolla/kolla-build.conf"},{"line_number":537,"context_line":".. code-block:: ini"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   [os-releaser]"},{"line_number":540,"context_line":"   type \u003d git"},{"line_number":541,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":542,"context_line":"   reference \u003d master"}],"source_content_type":"text/x-rst","patch_set":8,"id":"6346540c_08dcb818","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":15},"updated":"2025-02-07 21:44:26.000000000","message":"releaser","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cfdde74dd34e6ea859153108b3576dd723e8ca39","unresolved":false,"context_lines":[{"line_number":536,"context_line":".. path /etc/kolla/kolla-build.conf"},{"line_number":537,"context_line":".. code-block:: ini"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   [os-releaser]"},{"line_number":540,"context_line":"   type \u003d git"},{"line_number":541,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":542,"context_line":"   reference \u003d master"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f0b964b8_c727c6b3","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":15},"in_reply_to":"6346540c_08dcb818","updated":"2025-02-08 09:12:16.000000000","message":"fixed","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c8943eeb5d30dce51cec79e91cd2cf90f18e9c87","unresolved":true,"context_lines":[{"line_number":541,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":542,"context_line":"   reference \u003d master"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"   [os-releaser-user]"},{"line_number":545,"context_line":"   uid \u003d 53001"},{"line_number":546,"context_line":"   gid \u003d 53001"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"b1ecf1c1_9eb76e56","line":544,"range":{"start_line":544,"start_character":4,"end_line":544,"end_character":20},"updated":"2025-02-07 21:44:26.000000000","message":"releaser-user","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cfdde74dd34e6ea859153108b3576dd723e8ca39","unresolved":false,"context_lines":[{"line_number":541,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":542,"context_line":"   reference \u003d master"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"   [os-releaser-user]"},{"line_number":545,"context_line":"   uid \u003d 53001"},{"line_number":546,"context_line":"   gid \u003d 53001"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"597de9d9_593ae829","line":544,"range":{"start_line":544,"start_character":4,"end_line":544,"end_character":20},"in_reply_to":"b1ecf1c1_9eb76e56","updated":"2025-02-08 09:12:16.000000000","message":"fixed","commit_id":"4651c69a1b0870484b474309312867ea8fd17739"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77ff0832f9fe8802853637d54ad742d8e8c74cf6","unresolved":true,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"First, create a ``Dockerfile.j2`` template for the project."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":".. path /home/kolla/custom-kolla-docker-templates/Dockerfile.j2"},{"line_number":554,"context_line":".. code-block:: jinja"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"   FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"}],"source_content_type":"text/x-rst","patch_set":11,"id":"8b618bf5_443f5120","line":553,"range":{"start_line":553,"start_character":20,"end_line":553,"end_character":63},"updated":"2025-02-17 22:36:25.000000000","message":"why do you remove it back? see below comment","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f954c9cc67e830ae713d22c962105ef3cb13ee46","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"First, create a ``Dockerfile.j2`` template for the project."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":".. path /home/kolla/custom-kolla-docker-templates/Dockerfile.j2"},{"line_number":554,"context_line":".. code-block:: jinja"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"   FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"}],"source_content_type":"text/x-rst","patch_set":11,"id":"4d9e65d7_d829448b","line":553,"range":{"start_line":553,"start_character":20,"end_line":553,"end_character":63},"in_reply_to":"8b618bf5_443f5120","updated":"2025-02-18 08:44:03.000000000","message":"err... sorry, the last patch-set was pushed from another laptop resulting in taking outdated revision of this patch.\n\nThank you for catching this. Should be fixed now.","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77ff0832f9fe8802853637d54ad742d8e8c74cf6","unresolved":true,"context_lines":[{"line_number":580,"context_line":".. code-block:: console"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"   custom-kolla-docker-templates"},{"line_number":583,"context_line":"   |__ releaser"},{"line_number":584,"context_line":"       |__ Dockerfile.j2"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Then, modify Kolla\u0027s configuration so the engine can download sources and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"cdfedead_d8207043","line":583,"range":{"start_line":583,"start_character":3,"end_line":583,"end_character":15},"updated":"2025-02-17 22:36:25.000000000","message":"here you show the \u0027releaser\u0027 subfolder removed.","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7b6698d6031be1b68e2f537c9e91d8496675880d","unresolved":false,"context_lines":[{"line_number":580,"context_line":".. code-block:: console"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"   custom-kolla-docker-templates"},{"line_number":583,"context_line":"   |__ releaser"},{"line_number":584,"context_line":"       |__ Dockerfile.j2"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Then, modify Kolla\u0027s configuration so the engine can download sources and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"656317c9_e4594d84","line":583,"range":{"start_line":583,"start_character":3,"end_line":583,"end_character":15},"in_reply_to":"cdfedead_d8207043","updated":"2025-02-18 09:46:55.000000000","message":"Done","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77ff0832f9fe8802853637d54ad742d8e8c74cf6","unresolved":true,"context_lines":[{"line_number":589,"context_line":".. path /etc/kolla/kolla-build.conf"},{"line_number":590,"context_line":".. code-block:: ini"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"   [os-releaser]"},{"line_number":593,"context_line":"   type \u003d git"},{"line_number":594,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":595,"context_line":"   reference \u003d master"}],"source_content_type":"text/x-rst","patch_set":11,"id":"21245881_18074b29","line":592,"range":{"start_line":592,"start_character":4,"end_line":592,"end_character":15},"updated":"2025-02-17 22:36:25.000000000","message":"shouldn\u0027t it be the name of (sub)folder?","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f954c9cc67e830ae713d22c962105ef3cb13ee46","unresolved":false,"context_lines":[{"line_number":589,"context_line":".. path /etc/kolla/kolla-build.conf"},{"line_number":590,"context_line":".. code-block:: ini"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"   [os-releaser]"},{"line_number":593,"context_line":"   type \u003d git"},{"line_number":594,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":595,"context_line":"   reference \u003d master"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bc0fecc1_1b75d4f0","line":592,"range":{"start_line":592,"start_character":4,"end_line":592,"end_character":15},"in_reply_to":"21245881_18074b29","updated":"2025-02-18 08:44:03.000000000","message":"Done","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77ff0832f9fe8802853637d54ad742d8e8c74cf6","unresolved":true,"context_lines":[{"line_number":594,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":595,"context_line":"   reference \u003d master"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"   [os-releaser-user]"},{"line_number":598,"context_line":"   uid \u003d 53001"},{"line_number":599,"context_line":"   gid \u003d 53001"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5e13ca07_e34e4fad","line":597,"range":{"start_line":597,"start_character":4,"end_line":597,"end_character":15},"updated":"2025-02-17 22:36:25.000000000","message":"ditto","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f954c9cc67e830ae713d22c962105ef3cb13ee46","unresolved":false,"context_lines":[{"line_number":594,"context_line":"   location \u003d https://opendev.org/openstack/releases"},{"line_number":595,"context_line":"   reference \u003d master"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"   [os-releaser-user]"},{"line_number":598,"context_line":"   uid \u003d 53001"},{"line_number":599,"context_line":"   gid \u003d 53001"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7322a20d_ce7a1e12","line":597,"range":{"start_line":597,"start_character":4,"end_line":597,"end_character":15},"in_reply_to":"5e13ca07_e34e4fad","updated":"2025-02-18 08:44:03.000000000","message":"Done","commit_id":"8cf3881dfbb9dd69baf4b665209f4b86cab0de81"}],"releasenotes/notes/extend-sources-and-users-61c143326a35c7ed.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"de71b2ff_f37217f1","line":5,"updated":"2024-07-22 15:24:26.000000000","message":"Double backticks","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b46c5104_40b4172c","line":5,"updated":"2024-07-22 15:24:26.000000000","message":"to allow users to\n\n(or even operators instead of users)","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bbfa5c7f_7bef339a","line":5,"in_reply_to":"b46c5104_40b4172c","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c760e886_b13c7660","line":5,"in_reply_to":"de71b2ff_f37217f1","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a63b9842d47eb867e0a07dde4d4a31bd7c99b163","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ba7fbca_56438e0b","line":6,"updated":"2024-07-22 15:24:26.000000000","message":"built-in","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Introduces ``additional_source_projects`` and ``additional_users`` config"},{"line_number":5,"context_line":"     options to allow users manage external projects provided in `docker-dir`"},{"line_number":6,"context_line":"     the same way as Kolla builtin projects."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0519e421_8373ac5b","line":6,"in_reply_to":"1ba7fbca_56438e0b","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"}],"roles/kolla-build/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5de9bee1b540077d44e387c787896bd8d90189d7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  ansible.builtin.command:"},{"line_number":10,"context_line":"    cmd: \u003e-"},{"line_number":11,"context_line":"      {{ kolla_build_venv_path }}/bin/kolla-build --template-only"},{"line_number":12,"context_line":"      {% if kolla_build_external_docker_dir %}--docker-dir {{ kolla_build_external_docker_dir }}{% endif %}"},{"line_number":13,"context_line":"      --work-dir {{ kolla_build_logs_dir }}/work_dir"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Run kolla-build"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"28d2ae55_e5842b8a","line":12,"updated":"2025-02-17 09:41:25.000000000","message":"Can you add this to kolla/tests/playbooks/run.yml instead?","commit_id":"97b3f36e56c515b9ab09b10550921f96ea4263c2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e0a17b4e9a195ab8e2933c5c6d32cdcc22e86323","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  ansible.builtin.command:"},{"line_number":10,"context_line":"    cmd: \u003e-"},{"line_number":11,"context_line":"      {{ kolla_build_venv_path }}/bin/kolla-build --template-only"},{"line_number":12,"context_line":"      {% if kolla_build_external_docker_dir %}--docker-dir {{ kolla_build_external_docker_dir }}{% endif %}"},{"line_number":13,"context_line":"      --work-dir {{ kolla_build_logs_dir }}/work_dir"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Run kolla-build"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e3a41571_e12ce776","line":12,"in_reply_to":"28d2ae55_e5842b8a","updated":"2025-02-17 15:36:35.000000000","message":"Done. Specified docker_dir as a part of config","commit_id":"97b3f36e56c515b9ab09b10550921f96ea4263c2"}],"tests/playbooks/run.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a3d2a252bb7cf347d2817437ebbf6d212b516884","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"46283f0d_dcb050d2","line":20,"updated":"2024-07-22 08:44:04.000000000","message":"I think that\u0027s going to be published in the publish jobs as well, if that should serve as a test for this functionality - we\u0027d need to exclude that image for being published in the publish jobs (or just include that when not publisher)","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e6ca34328b4cd458638cfa4d105e06fa9ab90088","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"752cc487_a34e78f9","line":20,"in_reply_to":"46283f0d_dcb050d2","updated":"2024-07-22 08:58:30.000000000","message":"yeah, there are two purposes:\n- show the way how the new options are expected to work\n- extend CI to prevent breaking the feature in future\n\nI do not know the purpose of publish job, so please suggest the way to go - should I move tests under follow-up change or just get rid of them?","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2dd806b9dd8f599921a2f3ed3c2ef533d8e3fdb9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a5061f8_3a55eee8","line":20,"in_reply_to":"752cc487_a34e78f9","updated":"2024-09-17 11:49:51.000000000","message":"Done","commit_id":"27301d704ee3deae7bb4b8eb6e5c446800968bbe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"02a98ad5b0c4405d99d3bd312c74798e1511f3a0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"878281e9_f38ea6a1","line":20,"updated":"2024-10-02 08:04:41.000000000","message":"Can we just not build them in publish jobs, instead of doing the dance in publish.yml?","commit_id":"ccc10f2efc5dbfa264759fe740af64a175f881f9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"79a2aade3528619a4a312b7712b9d6ac6d3c088e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a553685f_c0939d24","line":20,"in_reply_to":"46d58fcc_9f883c9c","updated":"2024-10-02 12:55:39.000000000","message":"Done","commit_id":"ccc10f2efc5dbfa264759fe740af64a175f881f9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a83528cdde4eaf153d67020b67b4154f7b088d3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa09e924_6af6b4f9","line":20,"in_reply_to":"878281e9_f38ea6a1","updated":"2024-10-02 08:15:36.000000000","message":"hi!\nAre you suggesting not checking this feature in CI or moving it to another job? If the second, please suggest a better place to put this, as I was under impression that all \"*-build\" jobs are using this playbook.","commit_id":"ccc10f2efc5dbfa264759fe740af64a175f881f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"044384b1b2eb580ab9f2d7e6569dea75b98f093b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        # NOTE(yoctozepto): to avoid issues with IPv6 not enabled in the docker daemon"},{"line_number":18,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":19,"context_line":"        network_mode: host"},{"line_number":20,"context_line":"      releaser:"},{"line_number":21,"context_line":"        type: git"},{"line_number":22,"context_line":"        reference: master"},{"line_number":23,"context_line":"        location: \"https://opendev.org/openstack/releases.git\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"46d58fcc_9f883c9c","line":20,"in_reply_to":"fa09e924_6af6b4f9","updated":"2024-10-02 08:25:28.000000000","message":"I just meant to do a second dict with releaser - and combine it into the regular Kolla-build.conf dict only when not publishing","commit_id":"ccc10f2efc5dbfa264759fe740af64a175f881f9"}]}