)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c72f79c15e22293235fc3f1b0ae3f92e0ae59e39","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-09 08:34:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"horizon: Copy wsgi.py to /etc/openstack-dashboard/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ided63ff1462f7554302c8e2958ac46cc370c8455"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2a306f6d_ef91e8cf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-08-09 08:37:30.000000000","message":"why? this should be answered by the commit msg.","commit_id":"0f0b2768b9b3c1287286248829b07a77b6344abc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"62431faf4aaab64638e13a284079af42819500c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-09 08:34:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"horizon: Copy wsgi.py to /etc/openstack-dashboard/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ided63ff1462f7554302c8e2958ac46cc370c8455"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eeabee18_52ba828a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"2a306f6d_ef91e8cf","updated":"2024-08-09 08:50:38.000000000","message":"Done","commit_id":"0f0b2768b9b3c1287286248829b07a77b6344abc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f94566c376688885599293548b49914b5dd9a214","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"horizon: Copy wsgi.py to /etc/openstack-dashboard/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Every time new Debian/Ubuntu/Rocky comes out - we need"},{"line_number":10,"context_line":"to do a dance with passing distro_python_version from kolla"},{"line_number":11,"context_line":"to kolla-ansible, updating kolla-ansible distro_python_version"},{"line_number":12,"context_line":"and then removing the additional variables in CI"},{"line_number":13,"context_line":"This patch will allow smoother migrations to newer OSes with"},{"line_number":14,"context_line":"newer Python versions."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ided63ff1462f7554302c8e2958ac46cc370c8455"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c0a99b67_f4266d89","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":22},"updated":"2024-08-13 12:15:53.000000000","message":"The description is not related to the changes in the Dockerfile.\nThere is need to describe how horizon files relates to distro_python_version or whatever mentioned.\nMaybe there is a bugreport with issue needed?","commit_id":"6f9fd0a4de6d9ef09daa1d5fb233b24eaa3f589f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"62431faf4aaab64638e13a284079af42819500c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5944c0cb_dab96018","updated":"2024-08-09 08:50:38.000000000","message":"do we want to maybe backport this? It\u0027s not really a user visible feature, but may make changes to stable branches easier, no?","commit_id":"e72402dd42f818a2fa00a16a677373c7cede0b50"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0d6c4ba75076f790ab6eb0b3c8b0e16f4c65a34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aea8738a_fb7162be","in_reply_to":"5944c0cb_dab96018","updated":"2024-08-09 09:13:57.000000000","message":"I think would be nice to backport to 2024.1 - since we\u0027ll be back porting Noble support there for migration purposes.","commit_id":"e72402dd42f818a2fa00a16a677373c7cede0b50"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"201d8dac0fbdd338c3a5ea6c9c86f1e89d6eb72f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe787667_fc16568f","in_reply_to":"aea8738a_fb7162be","updated":"2024-08-09 10:26:20.000000000","message":"Acknowledged","commit_id":"e72402dd42f818a2fa00a16a677373c7cede0b50"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eb92816ff90c8081f451bc59a27e4d047ef469bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ccf77431_5646eb03","updated":"2024-08-09 11:32:02.000000000","message":"Check kolla-ansible comment","commit_id":"6f9fd0a4de6d9ef09daa1d5fb233b24eaa3f589f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4b501737171408f48ec1b6c8d905edd1bc76aa18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d749166_4e982da1","updated":"2024-08-20 12:08:06.000000000","message":"I am still saying the best is to create /var/lib/kolla/venv/pythonX.X -\u003e /var/lib/kolla/venv/python3 symlink as I\u0027ve done here: \n\nhttps://review.opendev.org/c/openstack/kolla/+/829295/7/docker/openstack-base/Dockerfile.j2\n\nWhy not ?","commit_id":"6f9fd0a4de6d9ef09daa1d5fb233b24eaa3f589f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6458c92dfdd0a9b7f5bad543069e05111cb840d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f3eefd1_c99d9448","updated":"2024-08-20 12:04:26.000000000","message":"Seems we\u0027re not setting STATIC_PATH so collectstatic will always build css/etc into /var/lib/kolla/venv/lib/python{{ version }}/static","commit_id":"6f9fd0a4de6d9ef09daa1d5fb233b24eaa3f589f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2f6d1657442bceab438e39729bf40b5ef2a8ccfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9026c6df_da5ea51c","in_reply_to":"0d749166_4e982da1","updated":"2024-08-20 12:13:01.000000000","message":"I value your opinion, but I don\u0027t like the solution.","commit_id":"6f9fd0a4de6d9ef09daa1d5fb233b24eaa3f589f"}],"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"001dbb6a4cfba20d44dbdbea9bac841b2698581a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    \u0026\u0026 rm -rf $local_settings_d \\"},{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3df86d59_0ba3be8b","line":66,"updated":"2024-08-09 08:17:32.000000000","message":"I\u0027m not sure having executables in /etc is a good idea, how about /usr/local/bin instead? could use horizon-wsgi.py as name then to avoid ambiguities\n\nalso, do we need a copy or can we simply move the file?","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fbecb1ca33901f96eaa46ed4d473c9fbc05c2eef","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    \u0026\u0026 rm -rf $local_settings_d \\"},{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a0043d38_d039ae9f","line":66,"in_reply_to":"3df86d59_0ba3be8b","updated":"2024-08-09 08:23:09.000000000","message":"Well, I didn\u0027t want to remove things in /horizon - since it\u0027s the location where we unpack the tarball and do pip install from that location.\nI think we could copy that to /var/lib/kolla/venv/bin ? Is that a better idea?","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fd6224f75302d6d8a60ae8186fa58dfc14410ab","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \u0026\u0026 rm -rf $local_settings_d \\"},{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c7f354fd_b231af29","line":66,"in_reply_to":"528451cf_456cbe38","updated":"2024-08-09 09:44:48.000000000","message":"Done","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66a1226ec54cf30732e090001c48744a12149fe1","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    \u0026\u0026 rm -rf $local_settings_d \\"},{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"528451cf_456cbe38","line":66,"in_reply_to":"a0043d38_d039ae9f","updated":"2024-08-09 08:45:58.000000000","message":"sounds fine, too. and yes, that\u0027s a good reason for copying","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"001dbb6a4cfba20d44dbdbea9bac841b2698581a","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"},{"line_number":70,"context_line":"       fi \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a668385_2f9890e0","line":67,"updated":"2024-08-09 08:17:32.000000000","message":"can we move instead of copying?","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66a1226ec54cf30732e090001c48744a12149fe1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 ln -s /etc/openstack-dashboard/local_settings.d $local_settings_d \\"},{"line_number":65,"context_line":"    \u0026\u0026 cp /horizon/manage.py /var/lib/kolla/venv/bin/manage.py \\"},{"line_number":66,"context_line":"    \u0026\u0026 cp /horizon/openstack_dashboard/wsgi.py /etc/openstack-dashboard/ \\"},{"line_number":67,"context_line":"    \u0026\u0026 cp -Rf /horizon/openstack_dashboard/static /etc/openstack-dashboard/ \\"},{"line_number":68,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":69,"context_line":"           {{ macros.install_pip(horizon_plugins_pip_packages) }}; \\"},{"line_number":70,"context_line":"       fi \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"50cc63a1_dec2db57","line":67,"in_reply_to":"9a668385_2f9890e0","updated":"2024-08-09 08:45:58.000000000","message":"ok, better not to","commit_id":"1fc1e528c857cc2216f65c3ced57cfcd4f19f821"}]}