)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aeb4cd7064ce8fd6648131ef12bf2e3d93d507f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b428c1d2_b2d80476","updated":"2024-09-19 04:41:14.000000000","message":"Missing reno for people using KOLLA_DISTRO_PYTHON_VERSION (remember people use Kolla without Kolla-Ansible)","commit_id":"a53bcd7811303de3ff2d6afebf0b8e82ecf42670"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"63ac5058008fc539ce5474a9e919dd78f1d6e1f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6705ac5b_29008416","in_reply_to":"b428c1d2_b2d80476","updated":"2024-09-19 11:10:26.000000000","message":"Done","commit_id":"a53bcd7811303de3ff2d6afebf0b8e82ecf42670"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3d8cfbbf32c2c3cfcf99be70ec5dd3fbec6b374","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3eada707_7ec71184","updated":"2024-09-23 08:42:59.000000000","message":"thx","commit_id":"1cda1acc7fd22bc42917c723f14c6ee076098297"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b27610f418461a8b043abe4471b93df8a0078d2a","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set venv_path\u003d\u0027/opt/ansible\u0027 %}"},{"line_number":9,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"RUN cd /usr/bin \u0026\u0026 \\"},{"line_number":11,"context_line":"    rm -f python3 \u0026\u0026 \\"},{"line_number":12,"context_line":"    ln -s python3.12 python3"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f6741a29_fd977f91","line":10,"updated":"2024-09-19 07:50:09.000000000","message":"Need a comment why are we doing that, but personally I feel this is a bit unnecessary and unreadable - let\u0027s just run python3.12 on EL and python3 on every other bistro in L72","commit_id":"a53bcd7811303de3ff2d6afebf0b8e82ecf42670"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7856a0b83114e057a0f056b8e686637733dc3d64","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set venv_path\u003d\u0027/opt/ansible\u0027 %}"},{"line_number":9,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"RUN cd /usr/bin \u0026\u0026 \\"},{"line_number":11,"context_line":"    rm -f python3 \u0026\u0026 \\"},{"line_number":12,"context_line":"    ln -s python3.12 python3"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c49fb36f_c8bdd5b1","line":10,"in_reply_to":"c361a7d3_90c9addd","updated":"2024-09-19 10:22:47.000000000","message":"Done","commit_id":"a53bcd7811303de3ff2d6afebf0b8e82ecf42670"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3d0981297543e701f347508d1511b640ee23b114","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set venv_path\u003d\u0027/opt/ansible\u0027 %}"},{"line_number":9,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"RUN cd /usr/bin \u0026\u0026 \\"},{"line_number":11,"context_line":"    rm -f python3 \u0026\u0026 \\"},{"line_number":12,"context_line":"    ln -s python3.12 python3"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c361a7d3_90c9addd","line":10,"in_reply_to":"f6741a29_fd977f91","updated":"2024-09-19 09:53:13.000000000","message":"I wrote a comment there, let me know if you\u0027re okay with it. Or are we unnecessarily adding an if for EL? Especially in the Kolla toolbox, where we can expect use outside of a virtual environment with a python3 shebang, this will be pointing to the quite old Python 3.9.\n\nWhat I mean is – if a service or scripts running in a container (which is dedicated, like kolla-toolbox) do not work with Python 3.9, and that\u0027s why Python 3.12 is installed. Why should the default Python in such a container be set to the old Python 3.9?","commit_id":"a53bcd7811303de3ff2d6afebf0b8e82ecf42670"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7030517516548af88a61821fd7fd67383538e4ce","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  So, let\u0027s correctly set python3 -\u003e python3.X since we had to install"},{"line_number":71,"context_line":"  it and now have default python3 points to the new version."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  [1] https://review.opendev.org/c/openstack/kolla/+/924245."},{"line_number":74,"context_line":"#}"},{"line_number":75,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":76,"context_line":"RUN cd /usr/bin \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0bebe41c_a8441ea2","line":73,"updated":"2024-09-19 10:20:33.000000000","message":"nit: remove the dot please","commit_id":"71b82cecce2f4dc62da376cb03090d89cd0031fc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dfd68948b621ef2585c9047a9f34f6f7614f6fa4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  So, let\u0027s correctly set python3 -\u003e python3.X since we had to install"},{"line_number":71,"context_line":"  it and now have default python3 points to the new version."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  [1] https://review.opendev.org/c/openstack/kolla/+/924245."},{"line_number":74,"context_line":"#}"},{"line_number":75,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":76,"context_line":"RUN cd /usr/bin \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"f0f4042c_e776a098","line":73,"in_reply_to":"0bebe41c_a8441ea2","updated":"2024-09-19 10:22:32.000000000","message":"Done","commit_id":"71b82cecce2f4dc62da376cb03090d89cd0031fc"}]}
