)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"e7d79ba4ef2d815b6f006998274e181f81de5b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0bfa5aa6_ca991612","updated":"2024-08-22 11:02:53.000000000","message":"LGTM","commit_id":"3eea22946d4edaf304cf9376a6e93663f79250e4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0e4c50370cc1f8b854a8c38b60f548a31eb2f17e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"968c48e9_f0983a60","updated":"2024-09-02 15:54:16.000000000","message":"I have never actually built images directly in the conductor container, could you please describe your use case? I would like to understand it a little bit.\n\nUsually the deployments I know only distribute images via conductor and built them not directly there but in some kind of CI/CD pipeline.\n\nYou mentioned EFI iso images on the bug report.\n\nThanks!","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed9c79c9b7dd1a00afd66b379f5ad626b0de4173","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07c0cfe7_d44e377a","updated":"2024-09-03 07:42:15.000000000","message":"we may want to have a release note, to highlight this was fixed? :)","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"89a936e1989a9c4f27383339125bc3141857d61a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31291a31_c2dc2fe1","updated":"2024-09-03 08:17:20.000000000","message":"yep. lgtm, but lack of relno","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"7f4ebb08eb8c335b7c1bb6029aba3f2c5f9ddd4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d19bec8_7b66c26a","in_reply_to":"07c0cfe7_d44e377a","updated":"2024-09-23 12:09:33.000000000","message":"Done.","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"7f4ebb08eb8c335b7c1bb6029aba3f2c5f9ddd4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"652ca79b_5d4bd4e8","in_reply_to":"31291a31_c2dc2fe1","updated":"2024-09-23 12:09:33.000000000","message":"Done.","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1b58f309883ed683174f9b8ab3ab8a77a27dce2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9242231_bbfbeda9","in_reply_to":"968c48e9_f0983a60","updated":"2024-09-02 18:31:39.000000000","message":"Sven, why do you set -1 for this change? This is well know method to boot baremetal node via virtual media.\nMay be because not obvious place for this piece of documentation is a Redfish section: https://docs.openstack.org/ironic/latest/admin/drivers/redfish.html#virtual-media-boot","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed9c79c9b7dd1a00afd66b379f5ad626b0de4173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6419adfa_711b03e3","in_reply_to":"c9242231_bbfbeda9","updated":"2024-09-03 07:42:15.000000000","message":"ah, thanks for educating me Maksim, I wasn\u0027t actually aware that ironic conductor can generate the isos on-the-fly! Actually a very interesting feature.\n\nThen this is of course a simple bugfix, sorry for the noise!","commit_id":"5d76cf4a2281b7f69b243ca9bec5fdbf697a3b1a"}]}
