)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"710ee43dcbdfd0eee1d1d62881053a33a090c92a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-12 15:30:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removal of deletion of the proxysql database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that at the time of implementing proxysql,"},{"line_number":10,"context_line":"it did not have the --reload parameter, or I overlooked"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"07578f80_b0329f39","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2024-09-15 19:11:01.000000000","message":"maybe more clear would be something like \u0027Preserve ProxySQL database on reload\" ? also too complicated commit message, but lgtm.","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"15aaf741be9804721028eb28824e66302a2b828a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"and keeps it there. The deletion was in the extended start"},{"line_number":14,"context_line":"precisely because proxysql ignored changes in the configuration"},{"line_number":15,"context_line":"file, so the internal database was always rebuilt during"},{"line_number":16,"context_line":"a restart. However, this now works with the --reload parameter."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I47848bb1e9847821c9b5fa25f0d817ef00358dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b6bb84db_555efe7a","line":16,"updated":"2024-09-13 07:39:21.000000000","message":"Can you point to where that --reload is being used? I failed to find it in kolla-ansible.","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5d2f034f33dc66d53e10b286f6e85d24e43a0807","unresolved":true,"context_lines":[{"line_number":13,"context_line":"and keeps it there. The deletion was in the extended start"},{"line_number":14,"context_line":"precisely because proxysql ignored changes in the configuration"},{"line_number":15,"context_line":"file, so the internal database was always rebuilt during"},{"line_number":16,"context_line":"a restart. However, this now works with the --reload parameter."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I47848bb1e9847821c9b5fa25f0d817ef00358dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ec35321f_5e3c9f76","line":16,"in_reply_to":"b6bb84db_555efe7a","updated":"2024-09-13 08:25:16.000000000","message":"it\u0027s here https://review.opendev.org/c/openstack/kolla-ansible/+/928611\n\nthis patch is dependency for mentioned above ^^","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a6c4e10ed60925c6d65c37170810fe4f229be031","unresolved":false,"context_lines":[{"line_number":13,"context_line":"and keeps it there. The deletion was in the extended start"},{"line_number":14,"context_line":"precisely because proxysql ignored changes in the configuration"},{"line_number":15,"context_line":"file, so the internal database was always rebuilt during"},{"line_number":16,"context_line":"a restart. However, this now works with the --reload parameter."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I47848bb1e9847821c9b5fa25f0d817ef00358dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea27e286_9fc76834","line":16,"in_reply_to":"ec35321f_5e3c9f76","updated":"2024-09-13 09:33:40.000000000","message":"Done","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dd93896929cb64a62f8d21a1164cc5795a2273e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39d33ef6_ce013c89","updated":"2024-09-13 10:47:13.000000000","message":"Ah, shouldn\u0027t the dependency be the other way around, then? Or do we actually need to make sure to merge both at the same time? I wonder what will happen on upgrades.","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c124185336c619e9b7040b7da2a438b2e43784ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"841d3402_650883b1","updated":"2024-09-13 11:02:54.000000000","message":"removed depends-on in kolla-ansible patch","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9034fd789b7094c79b0f07c10424c7563c3f7653","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28beb9ad_5e49cb18","updated":"2024-09-16 12:40:11.000000000","message":"should be merged ASAP as the k-a related change is already merged.","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"af4671fcb60734d9476d243129373d9b8382020d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01a112aa_a29b39d4","updated":"2024-09-13 09:47:03.000000000","message":"this is dependency for https://review.opendev.org/c/openstack/kolla-ansible/+/928611","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a7d54666052fc6cad8714aeb85a5664e54ead4d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d58780f8_0a4e5cf3","in_reply_to":"39d33ef6_ce013c89","updated":"2024-09-13 10:55:13.000000000","message":"nothing, if Kolla patch witch is removing removal of database will be merged and even if kolla-ansible will not be merged..ci will pass I would say ..because there is no configuration change ...so db will work.\n\nI was also wondering if it should be dependent other way around ..but it was weird from my point of view.\n\nbut maybe I can remove dependency ? because if I am now thinking about it ...it\u0027s not strong dependency ... \n\nwhat to you think ?","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"31769ea03580bc6f4cf904577d9928c27b12c256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e61a6e3_bacb03bb","in_reply_to":"d58780f8_0a4e5cf3","updated":"2024-09-13 10:56:28.000000000","message":"but yeah ..it should be merged one after another one ..in same time ..or in short window ..","commit_id":"8fde7db3f57ba6deebb9410b70f26fa96a9a3f3e"}]}