)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"33ae7056a41322b428a2a165e1629a7570089a6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d159c0e1_77ca657e","updated":"2024-09-18 08:00:58.000000000","message":"probably worth figuring out why kolla-ansible-ubuntu-mariadb (non-voting)FAILURE failed in reconfigure step.","commit_id":"320263c8bc6edf4b964e6e1efae31768cf0d69c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cd70a4ae6338d0fdbbec4281962ae441e04ae763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"85e378c3_39da03d9","updated":"2024-09-18 11:20:49.000000000","message":"recheck mariadb Ubuntu intermittent not synced","commit_id":"320263c8bc6edf4b964e6e1efae31768cf0d69c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"969e1fb0d506e6d990c190aeb18da15da375a562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ee58cc6b_df7e4896","in_reply_to":"5fd822e8_0cbb31a2","updated":"2024-09-18 12:43:22.000000000","message":"After recheck it\u0027s passing of course.","commit_id":"320263c8bc6edf4b964e6e1efae31768cf0d69c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e8cb1d1ec3fe043fc449fdf928a8ab7d8e674c56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5fd822e8_0cbb31a2","in_reply_to":"660c1917_5d952f1d","updated":"2024-09-18 11:20:24.000000000","message":"No, of course it can\u0027t as backup.sh is used during the backup nowhere else.\n\nThis just means that mariadb wasn\u0027t synced and recheck should help.","commit_id":"320263c8bc6edf4b964e6e1efae31768cf0d69c1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"593f1a6b97fdfa4f88a79508d159f66cc04ce54e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"660c1917_5d952f1d","in_reply_to":"d159c0e1_77ca657e","updated":"2024-09-18 08:02:25.000000000","message":"reason:\n\n```\n\nTASK [mariadb : Fail when MariaDB services are not synced across the whole cluster] ***\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/mariadb/tasks/lookup_cluster.yml:72\n\nTuesday 17 September 2024  12:05:46 +0000 (0:00:00.177)       0:00:49.647 ***** \n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"changed\": false,\n\n    \"msg\": \"MariaDB cluster is not synced. Please wait for WSREP sync before proceeding.\"\n\n}\n```\n\nweird, not sure if this can be a result of this patchset (need more caffein)","commit_id":"320263c8bc6edf4b964e6e1efae31768cf0d69c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2f6e43b2f67a79b269c7f6a2eef6db093ca9ef54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"88d3bad2_42b08df4","updated":"2024-09-27 12:47:20.000000000","message":"-1 just for the actual issue that needs fixing, everything else can be discussed IMO and it would be nice to hear what other reviewers think","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5e6c6f6d6ea2d52f9e41d6da666b374849d19caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e7819ccb_58f34331","updated":"2024-09-27 07:37:53.000000000","message":"All in all this looks like a hacky workaround to me, and I don\u0027t think that it even would work in the general case, see inline comments.\n\nBut I\u0027m also wondering why it isn\u0027t possible to solve the underlying issue between proxysql and mariabackup? It doesn\u0027t make sense to me to have a proxy setup and then go through such a hassle to circumvent it. If it turns out to really be needed after all, I think a static configuration of the mysql host to connect to would be better than such a fragile setup.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e75ed13c255a4ec0371162ede7b39a17a6b61ca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"aab8c394_2a9f93f8","in_reply_to":"4913fdf9_c183e6cb","updated":"2024-10-01 19:09:30.000000000","message":"backup from replica.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"760da83dbc312f13d83b2752fb755b0934803d43","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4913fdf9_c183e6cb","in_reply_to":"616ca5ad_6151a87b","updated":"2024-09-30 09:34:54.000000000","message":"The bug that you cite seems only remotely related, I\u0027d like to have one specific to proxysql + mariabackup. \n\n^^ Regarding this, i really don\u0027t understand what you are talking about. Problem is that xtrabackup is parsing binary version ... not version which actually mariadb node reports...\n\n\n```\n(kolla-ansible)[root]# mysql -h 192.168.205.254 -u root_shard_1 -p\nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MySQL connection id is 117470\nServer version: 8.0.11 (ProxySQL)  \u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c THIS STRING IS PROBLEM ||| VIP\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\nMySQL [(none)]\u003e select @@version;\n+---------------------------+\n| @@version                 |\n+---------------------------+\n| 10.11.9-MariaDB-deb12-log |     \u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c THIS SHOULD BE READ, BUT IT\u0027S NOT ||\n+---------------------------+\n1 row in set (0.003 sec)\n\nMySQL [(none)]\u003e exit\nBye\n(kolla-ansible)[root]# mysql -h 192.168.205.10 -u root_shard_1 -pultimum \nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MariaDB connection id is 222747\nServer version: 10.11.9-MariaDB-deb12-log mariadb.org binary distribution\n\n^^^^^^ THIS IS NOT PROBLEM, referenced bug is little bit different, but still about parsing\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\n````\n\nServer version can be set on ProxySQL side, but can be only hardcoded ...so it means every mariadb version change in kolla repo ..you need to also change the version in ProxySQL kolla-ansible template (or leave 10.11.9-MariaDB-deb12-log there forever ...so mariabackup will be happy ...then this patch is not needed).\n\n\n\n\nIn the end, I still don’t understand what bothers you about this approach. Even before, it connected through the VIP, but thanks to the MariaDB cluster check, it always went to just one node and performed the backup. However, if the VIP switched during the backup, the MariaDB backup wasn\u0027t valid.\n\nHere, it’s exactly the same, but instead of going through the load balancer, it first checks the address of the active node, connects to it, and starts the backup.\n\nHowever, if you prefer to back up from a non-active node that is a replica, I can certainly do that. Currently, in ProxySQL, we have the setup where requests through the load balancer always go to one host while the others are replicas. What do you think?\n\n\n\n```\nMySQL [(none)]\u003e select hostgroup_id,hostname,status,weight from runtime_mysql_servers where hostgroup_id \u003d 10 ;\n+--------------+----------------+---------+--------+\n| hostgroup_id | hostname       | status  | weight |\n+--------------+----------------+---------+--------+\n| 10           | 192.168.205.10 | ONLINE  | 100    |\n| 10           | 192.168.205.11 | SHUNNED | 10     |\n| 10           | 192.168.205.12 | SHUNNED | 10     |\n+--------------+----------------+---------+--------+\n```\n\n^^^ requests are sent only to first mariadb in kolla inventory ... i can do backup from secondary node ... WDYT ?","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2f6e43b2f67a79b269c7f6a2eef6db093ca9ef54","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"616ca5ad_6151a87b","in_reply_to":"d9fbc54b_cc63e57a","updated":"2024-09-27 12:47:20.000000000","message":"The bug that you cite seems only remotely related, I\u0027d like to have one specific to proxysql + mariabackup.\n\nIf you cite performance reason, that could be valid, but I think in that case it should be more sophisticated and actually disable the backend in the proxy for other client while the backup is running?","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"47964f4368515684b05aef0c533271738c7c0657","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d9fbc54b_cc63e57a","in_reply_to":"e7819ccb_58f34331","updated":"2024-09-27 09:25:35.000000000","message":"Why do you think this approach wouldn\u0027t work generally? (Except for the SELECT issue — I’ll fix that - you are right)\n\nWhy is this necessary? Well, because MariaDB/xtrabackup is dumb and checks the wrong version. It should be checking the server version, not the client binary version. This is a bug in mariabackup/xtrabackup that\u0027s been around for years, and I don\u0027t think anyone is going to fix it.\n\nHere\u0027s the relevant bug which is already 5 years old:\n\nhttps://bugs.launchpad.net/ubuntu/+source/percona-xtrabackup/+bug/1826556\n\nThis is the block of code responsible: \n\nhttps://github.com/percona/percona-xtrabackup/blob/cc111bf9309c0dcd9e19aca3c5c884a4001c4050/storage/innobase/xtrabackup/src/backup_mysql.cc#L408-L420\n\nIn the end, I really don’t see any problem with this approach. The mariabackup container connects, detects which server it is connected to (since ProxySQL reliably routes connections, checking ping, wsrep status, replication, etc.), and then proceeds to make a backup from that server.\n\nIn fact, this approach has some advantages because it avoids targeting a VIP where network load could significantly increase because of backup (and where there are, of course, many other services).\n\nIt’s also resilient to VIP failovers.\n\n\n\n\nSo, what specific issue do you actually have with this approach?","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"83ed81a342f6135a83b670b85ed71de4b3ca80f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ceac54ef_ed9c3bb3","updated":"2024-09-30 10:29:56.000000000","message":"How it looks like in  proxysql and how it is setup in kolla , by default every client is read/write from active node. So, we can backup from replica.\n\n\n```\n(kolla-ansible)[root]# mysql -h 192.168.205.10 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User                | Host              | db                  | Command | Time   | State                   | Info                  | Progress |\n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n|      1 | system user         |                   | NULL                | Sleep   | 647689 | wsrep aborter idle      | NULL                  |    0.000 |\n|      2 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|      6 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|      7 | system user         |                   | NULL                | Sleep   | 647685 |                         | NULL                  |    0.000 |\n|      9 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|    288 | octavia_persistence | controller2:60706 | octavia_persistence | Sleep   |      1 |                         | NULL                  |    0.000 |\n|    473 | octavia_persistence | controller2:57500 | octavia_persistence | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    480 | cinder              | controller2:57542 | cinder              | Sleep   |      0 |                         | NULL                  |    0.000 |\n|    528 | neutron             | controller2:35042 | neutron             | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    531 | neutron             | controller2:35046 | neutron             | Sleep   |      1 |                         | NULL                  |    0.000 |\n|    582 | octavia             | controller2:41854 | octavia             | Sleep   |      2 |                         | NULL                  |    0.000 |\n|    592 | octavia             | controller2:53720 | octavia             | Sleep   |      0 |                         | NULL                  |    0.000 |\n|    637 | neutron             | controller2:38956 | neutron             | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    724 | designate           | controller2:44502 | designate           | Sleep   |      4 |                         | NULL                  |    0.000 |\n|   1055 | neutron             | controller2:50494 | neutron             | Sleep   |      1 |                         | NULL                  |    0.000 |\n|   6148 | cinder              | controller2:55846 | cinder              | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 170898 | monitor             | controller2:49882 | NULL                | Sleep   |      1 |                         | NULL                  |    0.000 |\n| 327479 | cinder              | controller2:45764 | cinder              | Sleep   |      1 |                         | NULL                  |    0.000 |\n| 327481 | designate           | controller2:45774 | designate           | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 327482 | cinder              | controller2:45778 | cinder              | Sleep   |      4 |                         | NULL                  |    0.000 |\n| 376885 | monitor             | controller2:50912 | NULL                | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992342 | root_shard_1        | deploy:36982      | NULL                | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n(kolla-ansible)[root]# mysql -h 192.168.205.11 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User         | Host              | db   | Command | Time   | State                   | Info                  | Progress |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n|      2 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|      1 | system user  |                   | NULL | Sleep   | 647672 | wsrep aborter idle      | NULL                  |    0.000 |\n|      6 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      8 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      9 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|     14 | monitor      | controller2:41224 | NULL | Sleep   |      3 |                         | NULL                  |    0.000 |\n| 687811 | monitor      | controller2:45344 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 992274 | root_shard_1 | deploy:37770      | NULL | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n(kolla-ansible)[root]# mysql -h 192.168.205.12 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User         | Host              | db   | Command | Time   | State                   | Info                  | Progress |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n|      1 | system user  |                   | NULL | Sleep   | 647654 | wsrep aborter idle      | NULL                  |    0.000 |\n|      2 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      6 | system user  |                   | NULL | Sleep   |      2 | wsrep applier committed | NULL                  |    0.000 |\n|      7 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|      8 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|   1423 | monitor      | controller2:56430 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 774317 | monitor      | controller2:58942 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992194 | monitor      | controller0:54706 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 992196 | monitor      | controller1:50192 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992197 | monitor      | controller1:50198 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992202 | root_shard_1 | deploy:55846      | NULL | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n```","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0c722a143e7781d7d6c0c1f1195cce8f2478854e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"09519352_94a4e1f1","updated":"2024-09-30 10:25:44.000000000","message":"My test \n\n```\n(kolla-ansible)[root]# mysql -h 192.168.205.10 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User                | Host              | db                  | Command | Time   | State                   | Info                  | Progress |\n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n|      1 | system user         |                   | NULL                | Sleep   | 647689 | wsrep aborter idle      | NULL                  |    0.000 |\n|      2 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|      6 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|      7 | system user         |                   | NULL                | Sleep   | 647685 |                         | NULL                  |    0.000 |\n|      9 | system user         |                   | NULL                | Sleep   | 647685 | wsrep applier committed | NULL                  |    0.000 |\n|    288 | octavia_persistence | controller2:60706 | octavia_persistence | Sleep   |      1 |                         | NULL                  |    0.000 |\n|    473 | octavia_persistence | controller2:57500 | octavia_persistence | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    480 | cinder              | controller2:57542 | cinder              | Sleep   |      0 |                         | NULL                  |    0.000 |\n|    528 | neutron             | controller2:35042 | neutron             | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    531 | neutron             | controller2:35046 | neutron             | Sleep   |      1 |                         | NULL                  |    0.000 |\n|    582 | octavia             | controller2:41854 | octavia             | Sleep   |      2 |                         | NULL                  |    0.000 |\n|    592 | octavia             | controller2:53720 | octavia             | Sleep   |      0 |                         | NULL                  |    0.000 |\n|    637 | neutron             | controller2:38956 | neutron             | Sleep   |      3 |                         | NULL                  |    0.000 |\n|    724 | designate           | controller2:44502 | designate           | Sleep   |      4 |                         | NULL                  |    0.000 |\n|   1055 | neutron             | controller2:50494 | neutron             | Sleep   |      1 |                         | NULL                  |    0.000 |\n|   6148 | cinder              | controller2:55846 | cinder              | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 170898 | monitor             | controller2:49882 | NULL                | Sleep   |      1 |                         | NULL                  |    0.000 |\n| 327479 | cinder              | controller2:45764 | cinder              | Sleep   |      1 |                         | NULL                  |    0.000 |\n| 327481 | designate           | controller2:45774 | designate           | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 327482 | cinder              | controller2:45778 | cinder              | Sleep   |      4 |                         | NULL                  |    0.000 |\n| 376885 | monitor             | controller2:50912 | NULL                | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992342 | root_shard_1        | deploy:36982      | NULL                | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+---------------------+-------------------+---------------------+---------+--------+-------------------------+-----------------------+----------+\n(kolla-ansible)[root]# mysql -h 192.168.205.11 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User         | Host              | db   | Command | Time   | State                   | Info                  | Progress |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n|      2 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|      1 | system user  |                   | NULL | Sleep   | 647672 | wsrep aborter idle      | NULL                  |    0.000 |\n|      6 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      8 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      9 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|     14 | monitor      | controller2:41224 | NULL | Sleep   |      3 |                         | NULL                  |    0.000 |\n| 687811 | monitor      | controller2:45344 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 992274 | root_shard_1 | deploy:37770      | NULL | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n(kolla-ansible)[root]# mysql -h 192.168.205.12 -u root_shard_1 -p -e \u0027show full processlist;\u0027 \n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n| Id     | User         | Host              | db   | Command | Time   | State                   | Info                  | Progress |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n|      1 | system user  |                   | NULL | Sleep   | 647654 | wsrep aborter idle      | NULL                  |    0.000 |\n|      2 | system user  |                   | NULL | Sleep   |      1 | wsrep applier committed | NULL                  |    0.000 |\n|      6 | system user  |                   | NULL | Sleep   |      2 | wsrep applier committed | NULL                  |    0.000 |\n|      7 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|      8 | system user  |                   | NULL | Sleep   |      0 | wsrep applier committed | NULL                  |    0.000 |\n|   1423 | monitor      | controller2:56430 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 774317 | monitor      | controller2:58942 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992194 | monitor      | controller0:54706 | NULL | Sleep   |      0 |                         | NULL                  |    0.000 |\n| 992196 | monitor      | controller1:50192 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992197 | monitor      | controller1:50198 | NULL | Sleep   |      2 |                         | NULL                  |    0.000 |\n| 992202 | root_shard_1 | deploy:55846      | NULL | Query   |      0 | starting                | show full processlist |    0.000 |\n+--------+--------------+-------------------+------+---------+--------+-------------------------+-----------------------+----------+\n\n```","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a94a5a40553fb6415371c91ca01b523ad6c8e2bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d9b5aa9b_68844149","updated":"2024-10-07 12:15:20.000000000","message":"Can we approve this finally ? Another review is approved waiting for this one ... All comments are resolved now, everything explained... What we are waiting for ?","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"239061698efebfdb60f7ca02502c50f367694742","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ce2a07ea_ed152a1d","updated":"2024-10-07 12:33:13.000000000","message":"Shouldn\u0027t we just fully move the logic into Kolla-Ansible? It seems it\u0027s artificially in Kolla?","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fdd5716098f2f7476d1b99d01eb17677082e6eb4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e3b9e27f_714a368d","in_reply_to":"44852b85_a4578e09","updated":"2024-10-09 08:11:20.000000000","message":"https://mariadb.com/kb/en/incremental-backup-and-restore-with-mariabackup/#combining-with-stream-output\n\nTheir docs are worse than ours :)","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8221c3cb1d798cce84569b222228dab7bdee7bda","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"92cce7d6_08b35139","in_reply_to":"50e3a0e0_19a3f48a","updated":"2024-10-09 07:49:42.000000000","message":"But you’re contradicting yourself and your own statement. You’re saying that there might be some people who could use this script, and at the same time, you’re saying you want to remove it from the image. From a backup perspective, it’s better to back up MariaDB directly rather than through a proxy. And btw, we have a release notes where we can specify this was changed of course, also script can be changed to if/else clause ...so the haproxy users will backup same as before and proxysql as i proposed... Wdyt ?","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"791d484f5cbc23577becbac14b45e6478bc00bd9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"50e3a0e0_19a3f48a","in_reply_to":"53fdec82_7bd6b9a6","updated":"2024-10-09 07:42:05.000000000","message":"No, it\u0027s not done.\nI just meant it\u0027s so much logic here (that also is only needed for proxysql - and you\u0027re forcing that on non-proxysql users) that it just hurts.\nLogic for doing backups should be outside of Kolla from my perspective, we\u0027re just delivering MariaDB images.\nThere are people using those images, that might be using that script in environments that we have no clue about (such as people using their own automation to deploy Kolla images).\nSo please - stop forcing ProxySQL logic on other people at least.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f91da0ebb59c030858cef7a88821510566b138b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"db8b3e54_60b40d80","in_reply_to":"82440227_25ac3b01","updated":"2024-10-09 08:00:50.000000000","message":"Ah, okay - let me revert original script and propose the new one.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"67ba5588b3ef53848cb25bb82fffc5ef142a398f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e714434d_17644da1","in_reply_to":"82440227_25ac3b01","updated":"2024-10-09 08:07:06.000000000","message":"It\u0027s also interesting we still use xbstream compared to mbstream from mariadb docs.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4950227e4d9b7f4e077fcc50fd8dbf1bc1c54555","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"82440227_25ac3b01","in_reply_to":"92cce7d6_08b35139","updated":"2024-10-09 07:56:31.000000000","message":"You need to start reading carefully, when I\u0027m asking something - I\u0027m not saying it needs to be done.\nSecond of all - I think instead of if/else clauses, let\u0027s leave the old script alone and create a new one for proxysql.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9993c520e23aaface598949eaedea13acf405a2a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d3d2a77c_2dcfe595","in_reply_to":"ce2a07ea_ed152a1d","updated":"2024-10-07 13:11:18.000000000","message":"What does \"artificially in Kolla\" mean? Isn’t Kolla specifically designed to provide images that expose certain APIs as scripts, which are then utilized by Kolla-Ansible? Aren\u0027t other scripts also \"artificially\" in Kolla? Are we planning to move everything into Kolla-Ansible? We could remove all similar elements from images, move them into Kolla-Ansible, and eventually end up with images that only contain the software without \"artificial\" scripts. At that point, we could also drop Kolla and just use upstream images, couldn\u0027t we ? \n\nAnsible is a fantastic tool, but it\u0027s important to remember that it’s not meant for programming. Each additional task involves SSH, rsync, Python on the target server, registering variables, and so on, which unnecessarily adds complexity. Why go through all that when a well-functioning script exists in the image, in a normal scripting language, which I can simply run with Ansible and evaluate the output? Instead, the trend should be towards wrapping the logic in the image itself, whether in Python, Bash, Go, or something else. Ansible should be used for templating, deploying the images, restarting services, and general management—not for programming complex tasks. That\u0027s my perspective. So what does \"artificial\" actually mean? Let\u0027s Encrypt, for example, has several scripts, as or as haproxy-ssh does. Rewriting those in Ansible would be extremely complex and unnecessary for example, so why here ? Because it\u0027s simpler ? \n\nMoreover, there are patches that focus more on generating config tasks and then, for example, restarting services. For this reason alone, we should minimize \"programming\" tasks in Ansible and avoid using cmd: and shell:. These should rather be part of the image, exposed to Kolla-Ansible as some form of API.\n\nAlso, an operator might have a simple cron job that starts a mariadb_backup container to make a backup—without needing to use Ansible at all. Why should we force that into Kolla-Ansible? What\u0027s the point? What would be the benefit?\n\nI\u0027d like to hear some arguments on why this approach is better and why the current setup is considered problematic.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"03316090069533b9ff9d5b5bc0851fb7c1f2f7f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"53fdec82_7bd6b9a6","in_reply_to":"d3d2a77c_2dcfe595","updated":"2024-10-07 13:46:01.000000000","message":"Done","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3f29b264e02746f37db16733d5c9d3fb8a936543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"946ee29c_db08a916","in_reply_to":"dc824a1e_3d13990f","updated":"2024-10-09 10:51:46.000000000","message":"Added new one for proxysql  and leave old alone as requested.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5558ba8035f7cd5b3f70e7bcfd339829219b5195","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dc824a1e_3d13990f","in_reply_to":"e3b9e27f_714a368d","updated":"2024-10-09 08:22:44.000000000","message":":D :D :D, okaaay. Let me check if it\u0027s solving the issue.\n\nAlso I think a few people only if anybody is using mariadb backup from Kolla, but don\u0027t know.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"08668b00ee2c5d858dbb4857239c5826d62c9116","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f14f1988_7e07f122","in_reply_to":"e714434d_17644da1","updated":"2024-10-09 08:08:08.000000000","message":"Hmm, really ? Because maybe it can fix issue in overall.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7acce93876c14ac7e6a9907a3d5d117f758e95fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"44852b85_a4578e09","in_reply_to":"f14f1988_7e07f122","updated":"2024-10-09 08:09:26.000000000","message":"Hmm, only xbstream is supported https://mariadb.com/kb/en/mariabackup-options/   \"Using this command option, you can set Mariabackup to stream the backup files to stdout in the given format. Currently, the supported format is xbstream.\"\n\nMbstream is tool for extract.","commit_id":"afd9801a96bf67ea1c88bf24eaed38ce21187a37"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"49f259a72ca82231175a526e1dc231f9cdae51ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f20a8cb0_0071d4f5","updated":"2024-10-14 20:13:07.000000000","message":"checking online zuul status and it\u0027s not gating ? why ? :/","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b2097a2e345e93c58797e93698d51cb259b80fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fd5bd0b3_c9593cb2","updated":"2024-10-09 19:47:00.000000000","message":"nit: could add some \"ERROR: \" strings to the error logging in bash ;)","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"816c663b33f033001afcf879f7a861569b1cd6d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"25f600e5_a2a85b3a","updated":"2024-10-14 20:46:44.000000000","message":"okay, now it\u0027s gating ..but why it didn\u0027t gate before ...is there some max time required with verified by zuul +1 or similar ? why now it is gating after recheck ?","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"32e32f95ca9b082a364388aba188e08bd04e579f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d0dca363_e9af53d4","updated":"2024-10-14 17:35:54.000000000","message":"recheck as gate is somehow frozen ...","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3aee50216004cb0f4e12871307eed2d0eeb38512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"781e0300_8bb2da66","in_reply_to":"25f600e5_a2a85b3a","updated":"2024-10-14 20:48:33.000000000","message":"I think it didn\u0027t have backport-candidate flag set - and we require that in master.","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f2c1e2b979f4ab53127b7c3a42f53f9919b20f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"59587227_43ec2c99","in_reply_to":"781e0300_8bb2da66","updated":"2024-10-14 20:51:10.000000000","message":"Ahaaa, is it somewhere specified ? some documentation ?","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bf3d31f0cf64272d11f5edd6d3980fa4a0d73482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a5834ff6_e78f1b27","in_reply_to":"fd5bd0b3_c9593cb2","updated":"2024-10-14 17:18:04.000000000","message":"This will be addresses as separate change as this change changed how it works, formatting and bash outputs i will handle in another review.","commit_id":"ec4c4310dd870ff5bbdfd9762a0beb8389009b9f"}],"docker/mariadb/mariadb-server/backup.sh":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4c55d501c1ef62e6fa97db8df1dd6303d8f22639","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    exit 1"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"rm -f $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":7,"id":"66601988_9cf1a329","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":20},"updated":"2024-09-20 23:37:02.000000000","message":"executed only on successful backup. run without option or any error upon script run will leave the file. should be controlled by the bash trap.","commit_id":"5f3013a2bc0bef84a9271e634033e6a35bdb9ee2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8feb80697dd3db0e49c84c5f5acc8980c776820f","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    exit 1"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"rm -f $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":7,"id":"687a9bc4_2dbac15c","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":20},"in_reply_to":"66601988_9cf1a329","updated":"2024-09-21 01:12:25.000000000","message":"I can remove it completely if you like ..as whole script is executed in temporary container which will die after backup is done.","commit_id":"5f3013a2bc0bef84a9271e634033e6a35bdb9ee2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"34bdf7285a3b75535e7e97bc869920b61f00bc51","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    exit 1"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"rm -f $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bb56c0f9_93b12215","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":20},"in_reply_to":"687a9bc4_2dbac15c","updated":"2024-09-21 07:17:34.000000000","message":"Done","commit_id":"5f3013a2bc0bef84a9271e634033e6a35bdb9ee2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e6ff2ce86dc84df16d3f28bc3adcc3e573e31f4d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    exit 1"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"rm -f $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9548ae13_50ce8e81","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":20},"in_reply_to":"bb56c0f9_93b12215","updated":"2024-09-21 20:27:15.000000000","message":"why not simple change it to:\ntrap \"{ rm -f $ACTIVE_MY_CNF; exit 0; }\" EXIT","commit_id":"5f3013a2bc0bef84a9271e634033e6a35bdb9ee2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4e7f2226151da9f8be8203fe7e2161761ef530c3","unresolved":true,"context_lines":[{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Set trap to ensure cleanup occurs on exit or error"},{"line_number":16,"context_line":"trap cleanup EXIT"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"cd $BACKUP_DIR"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"9c2a04f6_663525d6","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":17},"updated":"2024-09-21 20:29:14.000000000","message":"trap \"{ cleanup; exit 0; }\" EXIT","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0be46caf7ee2f6e71d422e914157fd9835bf7b9e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Set trap to ensure cleanup occurs on exit or error"},{"line_number":16,"context_line":"trap cleanup EXIT"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"cd $BACKUP_DIR"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"d6f53e36_d9fffb28","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"9c2a04f6_663525d6","updated":"2024-09-21 20:54:27.000000000","message":"Why ? \n\ntrap cleanup EXIT : \n\nThis implementation sets a trap to call the cleanup function when the script exits (on receiving the EXIT signal). So, when the script finishes, it simply runs the cleanup function.\nAfter that, the script will terminate as usual with whatever exit status the script has.\n\ntrap \"{ cleanup; exit 0; }\" EXIT\n\nIn this case, when the script exits (on the EXIT signal), it calls the cleanup function, and then it explicitly calls exit 0.. So, it means that if backup failed ansible playbook will will be green and success which we of course don\u0027t want, right ?\n\nWe want to fail if backup failed and don\u0027t mask with exit 0 in any case.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"91ce5724ce1bca24bf1c22d2f6f4cd94bd7bed59","unresolved":false,"context_lines":[{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Set trap to ensure cleanup occurs on exit or error"},{"line_number":16,"context_line":"trap cleanup EXIT"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"cd $BACKUP_DIR"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"4185220a_7db0fd91","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"c5b7ef4e_883d308f","updated":"2024-09-21 22:06:11.000000000","message":"no problem, I think whole stuff around proxysql and mariadb now working and is ready","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cd405f384c4d297e988133431c9758245520d8c0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Set trap to ensure cleanup occurs on exit or error"},{"line_number":16,"context_line":"trap cleanup EXIT"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"cd $BACKUP_DIR"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"c5b7ef4e_883d308f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"d6f53e36_d9fffb28","updated":"2024-09-21 21:50:26.000000000","message":"you right) \u0027exit 0\u0027 is a copy-paste from my script with other logic.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5e6c6f6d6ea2d52f9e41d6da666b374849d19caa","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    USER\u003d\"$(grep \u0027^user\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":8,"id":"d0827696_a7dd2727","line":56,"updated":"2024-09-27 07:37:53.000000000","message":"This seems to be plain wrong to me, the \"HOST\" field shows the IP of the client, not the one of the server.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"47964f4368515684b05aef0c533271738c7c0657","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    USER\u003d\"$(grep \u0027^user\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":8,"id":"e491976c_1cff0690","line":56,"in_reply_to":"d0827696_a7dd2727","updated":"2024-09-27 09:25:35.000000000","message":"Hmm, yeah you are probably right, good catch. I will use \u0027select @@hostname\u0027.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d18e2e6c8a8bc32384980f550f29b62b794e07f6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    USER\u003d\"$(grep \u0027^user\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"}],"source_content_type":"text/x-sh","patch_set":8,"id":"792258d0_c062659a","line":56,"in_reply_to":"e491976c_1cff0690","updated":"2024-09-30 10:27:20.000000000","message":"Done","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5e6c6f6d6ea2d52f9e41d6da666b374849d19caa","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"cd6af2a1_35fe4717","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"updated":"2024-09-27 07:37:53.000000000","message":"Why is the getent needed, shouldn\u0027t it be enough to let the mariabackup command resolve this?\n\nAlso wouldn\u0027t this need some better error handling?","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5b85b0882f672a7b63a618c50c4e84fad7fbaf54","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9c6e0e15_ccf7b684","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"in_reply_to":"0adbdc0a_2748001b","updated":"2024-09-27 13:42:57.000000000","message":"It\u0027s like you said ..but firstly i needed to parse original and replace the VIP.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8df18c45583e83d5020a2aac2f81e14b26418b4a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"51eb5611_2042d80e","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"in_reply_to":"0d8210b7_8101c6ff","updated":"2024-09-29 11:06:34.000000000","message":"Done","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2f6e43b2f67a79b269c7f6a2eef6db093ca9ef54","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"0adbdc0a_2748001b","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"in_reply_to":"93332ad0_67d7b152","updated":"2024-09-27 12:47:20.000000000","message":"Making this whole action as simple as possible would likely improve the confidence of reviewers that this will actually work.\n\nAnother thing: Instead of passing all the dedicated options on the command line (which I think is particularly bad for a password), can\u0027t you just use `--defaults-file\u003d$DEFAULT_MY_CNF`? Or wouldn\u0027t that even be the default?","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1eacfff44d052c97685c0d34ebed6f5268e8ad6e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"0d8210b7_8101c6ff","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"in_reply_to":"9c6e0e15_ccf7b684","updated":"2024-09-28 19:12:37.000000000","message":"@frickler@offenerstapel.de and it\u0027s of course working ... added test here https://review.opendev.org/c/openstack/kolla-ansible/+/929771/20 (which btw showed that it didn\u0027t work :D ... not because of proxysql ..but because of history table)\n\nMoreover there is no set -x in bash ...this can\u0027t be viewed anywhere ...","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"47964f4368515684b05aef0c533271738c7c0657","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SELECT\u003d\u0027SELECT HOST FROM information_schema.PROCESSLIST WHERE ID \u003d CONNECTION_ID();\u0027"},{"line_number":57,"context_line":"    ACTIVE_HOST\u003d$(getent hosts $(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$SELECT\" | awk -F \u0027:\u0027 \u0027{print $1}\u0027) | awk \u0027{print $1}\u0027)"},{"line_number":58,"context_line":"    cp $DEFAULT_MY_CNF $ACTIVE_MY_CNF"},{"line_number":59,"context_line":"    sed -i \"s/$HOST/$ACTIVE_HOST/g\" $ACTIVE_MY_CNF"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"93332ad0_67d7b152","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":30},"in_reply_to":"cd6af2a1_35fe4717","updated":"2024-09-27 09:25:35.000000000","message":"yes, it can be resolved by mariabackup ...i just wanted IP.","commit_id":"453c7adf4cd289cabc9cb5cc84c76f0a70e4be5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7f9dce00768965fb8dcfc54dff25332531e35341","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if [ -z $LAST_FULL_DATE ]; then"},{"line_number":40,"context_line":"        LAST_FULL_DATE\u003d$(date +%d-%m-%Y)"},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    mariabackup \\"},{"line_number":43,"context_line":"        --defaults-file\u003d$REPLICA_MY_CNF \\"},{"line_number":44,"context_line":"        --backup \\"},{"line_number":45,"context_line":"        --stream\u003dxbstream \\"},{"line_number":46,"context_line":"        --incremental-history-name\u003d$LAST_FULL_DATE \\"},{"line_number":47,"context_line":"        --history\u003d$LAST_FULL_DATE | gzip \u003e \\"},{"line_number":48,"context_line":"        $BACKUP_DIR/incremental-$(date +%H)-mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs.gz"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"get_and_set_replica_server() {"}],"source_content_type":"text/x-sh","patch_set":11,"id":"28451421_aa64658e","line":48,"range":{"start_line":42,"start_character":1,"end_line":48,"end_character":90},"updated":"2024-09-30 11:57:44.000000000","message":"What about this ? this is also error prone ... if mysql protocol not working it will not work also ...","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3de8cde1033f22d12b9f3875f732174677089b43","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    if [ -z $LAST_FULL_DATE ]; then"},{"line_number":40,"context_line":"        LAST_FULL_DATE\u003d$(date +%d-%m-%Y)"},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    mariabackup \\"},{"line_number":43,"context_line":"        --defaults-file\u003d$REPLICA_MY_CNF \\"},{"line_number":44,"context_line":"        --backup \\"},{"line_number":45,"context_line":"        --stream\u003dxbstream \\"},{"line_number":46,"context_line":"        --incremental-history-name\u003d$LAST_FULL_DATE \\"},{"line_number":47,"context_line":"        --history\u003d$LAST_FULL_DATE | gzip \u003e \\"},{"line_number":48,"context_line":"        $BACKUP_DIR/incremental-$(date +%H)-mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs.gz"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"get_and_set_replica_server() {"}],"source_content_type":"text/x-sh","patch_set":11,"id":"620709b1_cadb7dc3","line":48,"range":{"start_line":42,"start_character":1,"end_line":48,"end_character":90},"in_reply_to":"28451421_aa64658e","updated":"2024-09-30 12:27:19.000000000","message":"Done","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"407dfd856c7964fe3595bc594be00502aa34b39b","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    ALL_HOSTS_SELECT\u003d\"SELECT REGEXP_REPLACE(VARIABLE_VALUE, \u0027:[0-9]*\u0027,\u0027\u0027) FROM information_schema.GLOBAL_STATUS WHERE VARIABLE_NAME \u003d \u0027wsrep_incoming_addresses\u0027;\""},{"line_number":57,"context_line":"    ALL_HOSTS\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ALL_HOSTS_SELECT\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    ACTIVE_HOST_SELECT\u003d\u0027SELECT @@hostname;\u0027"},{"line_number":60,"context_line":"    ACTIVE_HOST\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ACTIVE_HOST_SELECT\" | xargs getent hosts | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"037948a4_e2397d76","line":57,"updated":"2024-09-30 11:51:20.000000000","message":"This is hacky and error prone at best, without any error handling.","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7f9dce00768965fb8dcfc54dff25332531e35341","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    ALL_HOSTS_SELECT\u003d\"SELECT REGEXP_REPLACE(VARIABLE_VALUE, \u0027:[0-9]*\u0027,\u0027\u0027) FROM information_schema.GLOBAL_STATUS WHERE VARIABLE_NAME \u003d \u0027wsrep_incoming_addresses\u0027;\""},{"line_number":57,"context_line":"    ALL_HOSTS\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ALL_HOSTS_SELECT\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    ACTIVE_HOST_SELECT\u003d\u0027SELECT @@hostname;\u0027"},{"line_number":60,"context_line":"    ACTIVE_HOST\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ACTIVE_HOST_SELECT\" | xargs getent hosts | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"ba485294_824591a7","line":57,"in_reply_to":"037948a4_e2397d76","updated":"2024-09-30 11:57:44.000000000","message":"Some more details ? Because mysql command shouldn\u0027t fail ...if it will fail ..it just means that even without this function ...below backup_full and backup_incremental will also fail - and that\u0027s ok in overall ..because you can see in a log that backup failed.","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8508924bf27e3447bfbc93e4f764bee6efe0b44b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    PASS\u003d\"$(grep \u0027^password\u0027 $DEFAULT_MY_CNF | awk -F \u0027\u003d\u0027 \u0027{print $2}\u0027 | xargs)\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    ALL_HOSTS_SELECT\u003d\"SELECT REGEXP_REPLACE(VARIABLE_VALUE, \u0027:[0-9]*\u0027,\u0027\u0027) FROM information_schema.GLOBAL_STATUS WHERE VARIABLE_NAME \u003d \u0027wsrep_incoming_addresses\u0027;\""},{"line_number":57,"context_line":"    ALL_HOSTS\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ALL_HOSTS_SELECT\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    ACTIVE_HOST_SELECT\u003d\u0027SELECT @@hostname;\u0027"},{"line_number":60,"context_line":"    ACTIVE_HOST\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ACTIVE_HOST_SELECT\" | xargs getent hosts | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7dac81d4_0cf5fce9","line":57,"in_reply_to":"ba485294_824591a7","updated":"2024-09-30 12:22:26.000000000","message":"Added retry mechanism.\n\nHowever, if we were to really go into detail ... even without my patch, the backup should use SET GLOBAL wsrep_desync \u003d ON and SET GLOBAL wsrep_on \u003d OFF during the backup. \n\nFor example, during a backup, if the node is busy syncing large data changes from the cluster, it could lead to inconsistencies or slow down the backup process.","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"407dfd856c7964fe3595bc594be00502aa34b39b","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    ALL_HOSTS\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ALL_HOSTS_SELECT\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    ACTIVE_HOST_SELECT\u003d\u0027SELECT @@hostname;\u0027"},{"line_number":60,"context_line":"    ACTIVE_HOST\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ACTIVE_HOST_SELECT\" | xargs getent hosts | awk \u0027{print $1}\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    REPLICA_HOST\u003d$(echo $ALL_HOSTS | sed -e \"s/$ACTIVE_HOST//g\" | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"4b38da91_3ec4af16","line":60,"updated":"2024-09-30 11:51:20.000000000","message":"the same here","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8508924bf27e3447bfbc93e4f764bee6efe0b44b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ALL_HOSTS\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ALL_HOSTS_SELECT\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    ACTIVE_HOST_SELECT\u003d\u0027SELECT @@hostname;\u0027"},{"line_number":60,"context_line":"    ACTIVE_HOST\u003d$(mysql -h $HOST -u ${USER} -p${PASS} -s -N -e \"$ACTIVE_HOST_SELECT\" | xargs getent hosts | awk \u0027{print $1}\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    REPLICA_HOST\u003d$(echo $ALL_HOSTS | sed -e \"s/$ACTIVE_HOST//g\" | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"46d0cd48_e75a45ec","line":60,"in_reply_to":"4b38da91_3ec4af16","updated":"2024-09-30 12:22:26.000000000","message":"Added retry mechanism.","commit_id":"02d7e71563bbb66ed6bf50b60821269931580e25"}]}