)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5ccf472d9df4406adaf34e440ec6f1f56b574c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fbe7e5d_366166f7","updated":"2024-12-02 08:20:42.000000000","message":"recheck - check r9 ironic","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2391a7b9acd31f9fb8a762d90bac8b88e6822e4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db3ecce2_8d428a43","updated":"2025-03-12 14:23:25.000000000","message":"we likely don\u0027t want to enable it by default, but I think it would also be good to add a note in the docs on how to tell ironic to use the ESP image (might be in k-a instead of kolla)","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa4a1ce4c63ea37904665b5aa478ed1f16fbb0ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d30ab4d_acaaa63e","updated":"2025-03-19 17:07:49.000000000","message":"not sure whether you\u0027d want to backport, but it looks possible?","commit_id":"5025ab688be5d484ae2c4ab798a5be13a3489026"}],"docker/ironic/ironic-pxe/Dockerfile.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"440d1f8def838838817da17c70beeac6193d2dcd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        \u0027grub2-efi-*64\u0027,"},{"line_number":15,"context_line":"        \u0027grub2-efi-aa64-modules\u0027,"},{"line_number":16,"context_line":"        \u0027ipxe-bootimgs\u0027,"},{"line_number":17,"context_line":"        \u0027mtools\u0027,"},{"line_number":18,"context_line":"        \u0027shim-*64\u0027,"},{"line_number":19,"context_line":"        \u0027tftp-server\u0027,"},{"line_number":20,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"4d48923e_0ef58424","line":17,"updated":"2025-02-28 07:20:40.000000000","message":"mtools are also needed in the conductor, see https://review.opendev.org/c/openstack/kolla/+/942785, should we merge these changes and install it into the base image?","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b960cbaade66b6ee53ecd54bfc29bf7e77461eec","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        \u0027grub2-efi-*64\u0027,"},{"line_number":15,"context_line":"        \u0027grub2-efi-aa64-modules\u0027,"},{"line_number":16,"context_line":"        \u0027ipxe-bootimgs\u0027,"},{"line_number":17,"context_line":"        \u0027mtools\u0027,"},{"line_number":18,"context_line":"        \u0027shim-*64\u0027,"},{"line_number":19,"context_line":"        \u0027tftp-server\u0027,"},{"line_number":20,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"44332ace_b781458e","line":17,"in_reply_to":"4d48923e_0ef58424","updated":"2025-03-19 13:17:39.000000000","message":"let\u0027s separate this as we don\u0027t need it in ironic-api container","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"}],"docker/ironic/ironic-pxe/extend_start.sh":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"117afcb6e689ab4babd899c8ac0b01674323a3cb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    DEST\u003d${HTTPBOOT_PATH}/esp.img"},{"line_number":76,"context_line":"    dd if\u003d/dev/zero of\u003d$DEST bs\u003d4096 count\u003d2048"},{"line_number":77,"context_line":"    mkfs.msdos -F 12 -n ESP_IMAGE $DEST"},{"line_number":78,"context_line":"    mmd -i $DEST EFI EFI/BOOT"},{"line_number":79,"context_line":"    mcopy -i $DEST -v $shim_src_file ::EFI/BOOT/$shim_dst_file"},{"line_number":80,"context_line":"    mcopy -i $DEST -v $grub_src_file ::EFI/BOOT/$grub_dst_file"},{"line_number":81,"context_line":"    mdir -i $DEST ::EFI/BOOT"}],"source_content_type":"text/x-sh","patch_set":5,"id":"a4f567bb_5fef6aba","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":10},"updated":"2024-11-30 17:19:09.000000000","message":"strange, mmd/mcopy/mdir doesn\u0027t have \u0027-i\u0027 options\nhttps://www.gnu.org/software/mtools/manual/mtools.html#mmd\nbut this works)","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa4a1ce4c63ea37904665b5aa478ed1f16fbb0ea","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    DEST\u003d${HTTPBOOT_PATH}/esp.img"},{"line_number":76,"context_line":"    dd if\u003d/dev/zero of\u003d$DEST bs\u003d4096 count\u003d2048"},{"line_number":77,"context_line":"    mkfs.msdos -F 12 -n ESP_IMAGE $DEST"},{"line_number":78,"context_line":"    mmd -i $DEST EFI EFI/BOOT"},{"line_number":79,"context_line":"    mcopy -i $DEST -v $shim_src_file ::EFI/BOOT/$shim_dst_file"},{"line_number":80,"context_line":"    mcopy -i $DEST -v $grub_src_file ::EFI/BOOT/$grub_dst_file"},{"line_number":81,"context_line":"    mdir -i $DEST ::EFI/BOOT"}],"source_content_type":"text/x-sh","patch_set":5,"id":"79900f86_3e3e4fdc","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":10},"in_reply_to":"3d3e21e1_b9e2b69f","updated":"2025-03-19 17:07:49.000000000","message":"Done","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"440d1f8def838838817da17c70beeac6193d2dcd","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    DEST\u003d${HTTPBOOT_PATH}/esp.img"},{"line_number":76,"context_line":"    dd if\u003d/dev/zero of\u003d$DEST bs\u003d4096 count\u003d2048"},{"line_number":77,"context_line":"    mkfs.msdos -F 12 -n ESP_IMAGE $DEST"},{"line_number":78,"context_line":"    mmd -i $DEST EFI EFI/BOOT"},{"line_number":79,"context_line":"    mcopy -i $DEST -v $shim_src_file ::EFI/BOOT/$shim_dst_file"},{"line_number":80,"context_line":"    mcopy -i $DEST -v $grub_src_file ::EFI/BOOT/$grub_dst_file"},{"line_number":81,"context_line":"    mdir -i $DEST ::EFI/BOOT"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3d3e21e1_b9e2b69f","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":10},"in_reply_to":"5befe08b_c2ccaf4d","updated":"2025-02-28 07:20:40.000000000","message":"I think it would make sense to add a link to https://docs.openstack.org/ironic/2024.2/install/configure-esp.html as comment here for future reference","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"856427d4261c580ad146e5454b438fc58d1b1ccd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    DEST\u003d${HTTPBOOT_PATH}/esp.img"},{"line_number":76,"context_line":"    dd if\u003d/dev/zero of\u003d$DEST bs\u003d4096 count\u003d2048"},{"line_number":77,"context_line":"    mkfs.msdos -F 12 -n ESP_IMAGE $DEST"},{"line_number":78,"context_line":"    mmd -i $DEST EFI EFI/BOOT"},{"line_number":79,"context_line":"    mcopy -i $DEST -v $shim_src_file ::EFI/BOOT/$shim_dst_file"},{"line_number":80,"context_line":"    mcopy -i $DEST -v $grub_src_file ::EFI/BOOT/$grub_dst_file"},{"line_number":81,"context_line":"    mdir -i $DEST ::EFI/BOOT"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5befe08b_c2ccaf4d","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":10},"in_reply_to":"a4f567bb_5fef6aba","updated":"2024-12-02 08:20:14.000000000","message":"\"All commands accept the -i flag which allows to specify an image file (See Drive letters).\" - https://www.gnu.org/software/mtools/manual/mtools.html#drive-letters","commit_id":"4fe169884bd997b003a88ef09189180344a044a6"}]}