)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"d426e2aff5ed75f831be9817e3545b6105c18872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dab8395f_1877783e","updated":"2024-11-11 21:27:42.000000000","message":"recheck (Timeout)","commit_id":"16d766bbaa3c07695d3681041d6c105df1a76e22"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"d16c7d39d89f72bfe6f5152e4569316d3489f635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3734345_0468944e","updated":"2024-11-12 17:20:10.000000000","message":"recheck (failed on grafana)","commit_id":"27ad5d81dc97abf857808686f0bd3f804f697d5b"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"06a407653de63671d88d625f3c6fa58edbffeb57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"249d49fb_cf6ca9c8","updated":"2024-11-12 22:18:27.000000000","message":"recheck (post_failure)","commit_id":"27ad5d81dc97abf857808686f0bd3f804f697d5b"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"2a4a1c417e43ba92e635ee87c12977f92a7fadc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"944c67f6_6878b486","updated":"2024-12-10 18:18:54.000000000","message":"The EAB change was pulled in prematurely.","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90a109092a56b94df823afe024482fb34c170a3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1106af6f_327cbfee","updated":"2025-01-21 12:56:20.000000000","message":"okay, this makes sense","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"b45ef152334b9ec9febffe261758ee2a9c1e6ef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"81212d0b_47a427bd","in_reply_to":"944c67f6_6878b486","updated":"2024-12-11 01:31:02.000000000","message":"Nevermind - that was the original change.","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"36bdcb05e5fca55613c7cb586d8edade67a675a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b5bb4413_359b63da","updated":"2025-05-06 06:08:17.000000000","message":"trivial","commit_id":"f1248fe58a2e51a679d033c401e5d8953b04c8da"}],"docker/letsencrypt/letsencrypt-lego/letsencrypt-certificates.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ed7d5899b085f28bef5895f349a0b2a9646280f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    local eab\u003d\"${8}\""},{"line_number":24,"context_line":"    local hmac\u003d\"${9}\""},{"line_number":25,"context_line":"    local key_id\u003d\"${10}\""},{"line_number":26,"context_line":"    local letsencrypt_key_type\u003d\"${11:-ec256}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    certificate_domain_opts\u003d$(echo ${certificate_fqdns} | sed -r -e \u0027s/^/,/g\u0027 -e \u0027s/,/--domains\u003d/g\u0027 -e \u0027s/--/ --/g\u0027)"},{"line_number":29,"context_line":"    certificate_fqdn\u003d$(echo ${certificate_fqdns} | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"0bc4863b_589e39ff","line":26,"updated":"2025-01-16 19:50:17.000000000","message":"this makes us own the default, can we rely on lego default?","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"363e578c6c9205fa569013c481cb0ab1a0359718","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    local eab\u003d\"${8}\""},{"line_number":24,"context_line":"    local hmac\u003d\"${9}\""},{"line_number":25,"context_line":"    local key_id\u003d\"${10}\""},{"line_number":26,"context_line":"    local letsencrypt_key_type\u003d\"${11:-ec256}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    certificate_domain_opts\u003d$(echo ${certificate_fqdns} | sed -r -e \u0027s/^/,/g\u0027 -e \u0027s/,/--domains\u003d/g\u0027 -e \u0027s/--/ --/g\u0027)"},{"line_number":29,"context_line":"    certificate_fqdn\u003d$(echo ${certificate_fqdns} | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5ea8cc83_aa969cef","line":26,"in_reply_to":"0bc4863b_589e39ff","updated":"2025-01-21 11:56:14.000000000","message":"\u0027--key-type value, -k value   Key type to use for private keys. Supported: rsa2048, rsa4096, rsa8192, ec256, ec384. (default: \"ec256\")\u0027\n\nec256 is default","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8893869f013f9fe6c4475219dde8daa5a1f13083","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    local eab\u003d\"${8}\""},{"line_number":24,"context_line":"    local hmac\u003d\"${9}\""},{"line_number":25,"context_line":"    local key_id\u003d\"${10}\""},{"line_number":26,"context_line":"    local letsencrypt_key_type\u003d\"${11:-ec256}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    certificate_domain_opts\u003d$(echo ${certificate_fqdns} | sed -r -e \u0027s/^/,/g\u0027 -e \u0027s/,/--domains\u003d/g\u0027 -e \u0027s/--/ --/g\u0027)"},{"line_number":29,"context_line":"    certificate_fqdn\u003d$(echo ${certificate_fqdns} | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"725233da_d12bed16","line":26,"in_reply_to":"5ea8cc83_aa969cef","updated":"2025-01-21 11:59:41.000000000","message":"But it can change in lego upstream in future - I don\u0027t want Kolla to own that default.","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"7ab5834ffac5ca639cee014baa8be6e144920753","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    local eab\u003d\"${8}\""},{"line_number":24,"context_line":"    local hmac\u003d\"${9}\""},{"line_number":25,"context_line":"    local key_id\u003d\"${10}\""},{"line_number":26,"context_line":"    local letsencrypt_key_type\u003d\"${11:-ec256}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    certificate_domain_opts\u003d$(echo ${certificate_fqdns} | sed -r -e \u0027s/^/,/g\u0027 -e \u0027s/,/--domains\u003d/g\u0027 -e \u0027s/--/ --/g\u0027)"},{"line_number":29,"context_line":"    certificate_fqdn\u003d$(echo ${certificate_fqdns} | awk -F \u0027,\u0027 \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"e39d0f11_767248fc","line":26,"in_reply_to":"725233da_d12bed16","updated":"2025-04-24 13:11:17.000000000","message":"I added a check to omit --key-type if its not present. However, it looks a little clunky and I\u0027m not sure if its the right way to exclude it.","commit_id":"b64abe151439c91f3f778d2e4cea2873f21fb560"}]}