)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"71228510c282a662f4423062573f8dedf0368372","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upper-constraints.txt on OpenStack images on build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a part for updating or removing specific upper-constraints"},{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bcbbc524_1427deff","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":64},"updated":"2024-11-14 20:11:58.000000000","message":"there is no such block in the dockerfile","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"210703e6534838d50779147eee0af7bf917d473f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"upper-constraints.txt on OpenStack images on build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a part for updating or removing specific upper-constraints"},{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93fee293_839de202","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":64},"in_reply_to":"5b112712_eac2343d","updated":"2024-11-15 10:23:46.000000000","message":"Acknowledged","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"10d97ba4145c05bc41bf1f11105a117d3e3a3645","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upper-constraints.txt on OpenStack images on build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a part for updating or removing specific upper-constraints"},{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5b112712_eac2343d","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":64},"in_reply_to":"5ec4ec6e_0d97127a","updated":"2024-11-15 09:30:41.000000000","message":"oh, this is not the \u0027docker/base/Dockerfile.j2\u0027 modified in this change. so the message should be more specific or completely removed because this change doesn\u0027t adds it.","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"cbc744e230dc006d5dec06012ce64e01d435a60f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upper-constraints.txt on OpenStack images on build."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a part for updating or removing specific upper-constraints"},{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ec4ec6e_0d97127a","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":64},"in_reply_to":"bcbbc524_1427deff","updated":"2024-11-15 08:49:48.000000000","message":"https://opendev.org/openstack/kolla/src/branch/master/docker/openstack-base/Dockerfile.j2#L201-L207 Does this not work then?","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"71228510c282a662f4423062573f8dedf0368372","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"},{"line_number":17,"context_line":"kolla-toolbox image, added a part that guides setting variable for"},{"line_number":18,"context_line":"Dockerfile of kolla-toolbox instead of Dockerfile of base image."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f9a890d3_7e41f16b","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":50},"updated":"2024-11-14 20:11:58.000000000","message":"it also used to build Bifrost container...","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"210703e6534838d50779147eee0af7bf917d473f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"},{"line_number":17,"context_line":"kolla-toolbox image, added a part that guides setting variable for"},{"line_number":18,"context_line":"Dockerfile of kolla-toolbox instead of Dockerfile of base image."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b2512039_7cb83c05","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":50},"in_reply_to":"62090059_c19f8439","updated":"2024-11-15 10:23:46.000000000","message":"Make sense. I\u0027ll close this and merge these changes into one in https://review.opendev.org/c/openstack/kolla/+/934735","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"10d97ba4145c05bc41bf1f11105a117d3e3a3645","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"},{"line_number":17,"context_line":"kolla-toolbox image, added a part that guides setting variable for"},{"line_number":18,"context_line":"Dockerfile of kolla-toolbox instead of Dockerfile of base image."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"62090059_c19f8439","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":50},"in_reply_to":"74739946_4970062c","updated":"2024-11-15 09:30:41.000000000","message":"I\u0027m not against the https://review.opendev.org/c/openstack/kolla/+/934735 - both changes should be merged into the one.","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"cbc744e230dc006d5dec06012ce64e01d435a60f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Python package using ``openstack_base_override_upper_constraints``"},{"line_number":14,"context_line":"block."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the environment variable UPPER_CONSTRAINTS_FILE is only affecting"},{"line_number":17,"context_line":"kolla-toolbox image, added a part that guides setting variable for"},{"line_number":18,"context_line":"Dockerfile of kolla-toolbox instead of Dockerfile of base image."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74739946_4970062c","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":50},"in_reply_to":"f9a890d3_7e41f16b","updated":"2024-11-15 08:49:48.000000000","message":"Which is counter-intuitive in my opinion. Bifrost is built with ``openstack-base`` as a base image not ``base``. So, it should be using ``/requirements/upper-constraints.txt`` as a source of upper-constraints (Which is created by openstack-base Dockerfile) not by this environment variable.\nKolla-toolbox case makes sense to use UPPER_CONSTRAINTS_FILE because it\u0027s using ``base`` as a base image. (So, we can\u0027t guarantee ``/requirements`` exists on kolla-toolbox build time)\n\nhttps://review.opendev.org/c/openstack/kolla/+/934735 is the change that I\u0027m trying to ensures that Bifrost uses openstack-base as a source of upper-constraints","commit_id":"333759d13261958ce5831c963e8186a98410b035"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"71228510c282a662f4423062573f8dedf0368372","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla-toolbox image, added a part that guides setting variable for"},{"line_number":18,"context_line":"Dockerfile of kolla-toolbox instead of Dockerfile of base image."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Removed example UPPER_CONSTRAINTS_FILE in Dockerfile of base image."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ic351bec9466e2a659abc1c9fe8c82af1ee57023b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6d5b29_9df0fb54","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":7},"updated":"2024-11-14 20:11:58.000000000","message":"... and shouldn\u0027t be removed.","commit_id":"333759d13261958ce5831c963e8186a98410b035"}]}