)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37355,"name":"Pablo Colson","display_name":"Pablo Colson","email":"colson.pablo@gmail.com","username":"pabloclsn"},"change_message_id":"11473c15b5c6b36d3cbae1863e28c1075a81a26d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2686c2dc_8ed92970","updated":"2025-01-27 12:33:10.000000000","message":"Hi, why the merge request is not merged ?","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":37355,"name":"Pablo Colson","display_name":"Pablo Colson","email":"colson.pablo@gmail.com","username":"pabloclsn"},"change_message_id":"c37a2e530a5d15969e92e193283a41925b73a417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7fa64ce2_ceb8e88b","updated":"2025-01-06 15:59:48.000000000","message":"thanks for the work !","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5ab7d25dbf8a26ad60d978194095d078ad6fe68c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9251c48d_01ea1816","updated":"2025-01-27 20:13:06.000000000","message":"there is a lack of core reviewers :(","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":37355,"name":"Pablo Colson","display_name":"Pablo Colson","email":"colson.pablo@gmail.com","username":"pabloclsn"},"change_message_id":"8b1ecccfb1fe072940346ee74f018e6f1ca34391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ae7b20e9_47762a5f","in_reply_to":"9251c48d_01ea1816","updated":"2025-01-27 22:34:54.000000000","message":"oh ok .. :/","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"}],"docker/base/frr.repo":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd7268ef77c35db43a69e730aa36a0442ed3beb5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"name\u003dFRRouting 9.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr9"},{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[frr-extras]"},{"line_number":8,"context_line":"name\u003dFRRouting Dependencies for Enterprise Linux $releasever - $basearch"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"d4c9fbc9_599bc3fd","line":5,"updated":"2025-01-28 10:10:02.000000000","message":"Why?","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":true,"context_lines":[{"line_number":2,"context_line":"name\u003dFRRouting 9.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr9"},{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[frr-extras]"},{"line_number":8,"context_line":"name\u003dFRRouting Dependencies for Enterprise Linux $releasever - $basearch"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ff506ac5_3e92a967","line":5,"in_reply_to":"d4c9fbc9_599bc3fd","updated":"2025-01-29 18:32:16.000000000","message":"@mnasiadka@gmail.com carryover from previous MR. I\u0027m not sure what the reasoning is for this, but will check into it.","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"}],"docker/neutron/ovn-bgp-agent/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd7268ef77c35db43a69e730aa36a0442ed3beb5","unresolved":true,"context_lines":[{"line_number":38,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{{ macros.install_packages(ovn_bgp_agent_packages | customizable(\"packages\")) }} \\"},{"line_number":41,"context_line":"# NOTE(hrw): Upstream moved tcpdump to /usr/bin/ in 4.99 version (used in Debian)"},{"line_number":42,"context_line":"    \u0026\u0026 if [ -e /usr/sbin/tcpdump ]; then mv /usr/sbin/tcpdump /usr/bin/tcpdump; fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{% set ovn_bgp_agent_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"c79ebd27_d693a8c7","line":41,"updated":"2025-01-28 10:10:02.000000000","message":"Why do we need that?","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"6b8f86bade598355b262a2c00fbcd14e207a1232","unresolved":false,"context_lines":[{"line_number":38,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{{ macros.install_packages(ovn_bgp_agent_packages | customizable(\"packages\")) }} \\"},{"line_number":41,"context_line":"# NOTE(hrw): Upstream moved tcpdump to /usr/bin/ in 4.99 version (used in Debian)"},{"line_number":42,"context_line":"    \u0026\u0026 if [ -e /usr/sbin/tcpdump ]; then mv /usr/sbin/tcpdump /usr/bin/tcpdump; fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{% set ovn_bgp_agent_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"99da629b_da555922","line":41,"in_reply_to":"72c71ab7_73ff6a5d","updated":"2025-01-29 18:32:40.000000000","message":"Resolved","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":true,"context_lines":[{"line_number":38,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{{ macros.install_packages(ovn_bgp_agent_packages | customizable(\"packages\")) }} \\"},{"line_number":41,"context_line":"# NOTE(hrw): Upstream moved tcpdump to /usr/bin/ in 4.99 version (used in Debian)"},{"line_number":42,"context_line":"    \u0026\u0026 if [ -e /usr/sbin/tcpdump ]; then mv /usr/sbin/tcpdump /usr/bin/tcpdump; fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{% set ovn_bgp_agent_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"72c71ab7_73ff6a5d","line":41,"in_reply_to":"c79ebd27_d693a8c7","updated":"2025-01-29 18:32:16.000000000","message":"@mnasiadka@gmail.com This was carryover from the previous merge request. I don\u0027t know specifically where this is being referenced, so I will take it out.","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd7268ef77c35db43a69e730aa36a0442ed3beb5","unresolved":true,"context_lines":[{"line_number":50,"context_line":"RUN ln -s ovn-bgp-agent-source/* ovn-bgp-agent \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(ovn_bgp_agent_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/ovn-bgp-agent \\"},{"line_number":53,"context_line":"    \u0026\u0026 mkdir -p /etc/frr \\"},{"line_number":54,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/ovn-bgp-agent/* /etc/ovn-bgp-agent/ \\"},{"line_number":55,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr/* /etc/frr/ \\"},{"line_number":56,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"99b34f91_aa94cbd3","line":53,"updated":"2025-01-28 10:10:02.000000000","message":"nit: mkdir -p can create multiple directories in one invocation","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":false,"context_lines":[{"line_number":50,"context_line":"RUN ln -s ovn-bgp-agent-source/* ovn-bgp-agent \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(ovn_bgp_agent_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/ovn-bgp-agent \\"},{"line_number":53,"context_line":"    \u0026\u0026 mkdir -p /etc/frr \\"},{"line_number":54,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/ovn-bgp-agent/* /etc/ovn-bgp-agent/ \\"},{"line_number":55,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr/* /etc/frr/ \\"},{"line_number":56,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"09eb1c93_7e8508f9","line":53,"in_reply_to":"99b34f91_aa94cbd3","updated":"2025-01-29 18:32:16.000000000","message":"Resolved","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dd0d3e537fa24322b24ad0e00081e3a151d57854","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr/* /etc/frr/ \\"},{"line_number":56,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"},{"line_number":57,"context_line":"    \u0026\u0026 mkdir -p /var/run/ovn-bgp-agent \\"},{"line_number":58,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/ovn-bgp-agent \\"},{"line_number":59,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_ovn_bgp_agent_sudoers \\"},{"line_number":61,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bd20d8d3_e00ccbd0","line":58,"updated":"2025-01-28 10:10:40.000000000","message":"we don\u0027t use the variable in sudoers file, so let\u0027s not use it here as well","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr/* /etc/frr/ \\"},{"line_number":56,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"},{"line_number":57,"context_line":"    \u0026\u0026 mkdir -p /var/run/ovn-bgp-agent \\"},{"line_number":58,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/ovn-bgp-agent \\"},{"line_number":59,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_ovn_bgp_agent_sudoers \\"},{"line_number":61,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"2b0b68c8_ba1ffbad","line":58,"in_reply_to":"bd20d8d3_e00ccbd0","updated":"2025-01-29 18:32:16.000000000","message":"Resolved","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"}],"docker/neutron/ovn-bgp-agent/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd7268ef77c35db43a69e730aa36a0442ed3beb5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":7,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":10,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"85330f22_8d3b2b60","line":7,"updated":"2025-01-28 10:10:02.000000000","message":"OVN_BGP_AGENT_DIR\u003d\"/var/lib/ovn-bgp-agent\" and use that variable below?","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":7,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":10,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"e63f5aaf_a8802f6f","line":7,"in_reply_to":"85330f22_8d3b2b60","updated":"2025-01-29 18:32:16.000000000","message":"Resolved","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"}],"releasenotes/notes/add-ovn-bgp-agent-frr-21d0e02acaf69a2b.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd7268ef77c35db43a69e730aa36a0442ed3beb5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds FRR and ovn-bgp-agent to kolla"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"13371339_95bb9c02","line":4,"updated":"2025-01-28 10:10:02.000000000","message":"container image","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"393c57f81b0001b10fe2e808ecf337ef157ca0ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds FRR and ovn-bgp-agent to kolla"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"efa17907_aa3e4757","line":4,"in_reply_to":"13371339_95bb9c02","updated":"2025-01-29 18:32:16.000000000","message":"Resolved","commit_id":"1ce88a5280b86d341d7ac150ee451df7975f8119"}]}