)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1788f76427ec8b48994faae7dbe01e1ddf37d1d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7c8713f_e5da6e08","updated":"2024-12-08 14:42:41.000000000","message":"recheck ansible patch merged","commit_id":"1537574c29b4bde0f384a1c7155bf9ff11776ec6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bc49798386f7d820f02a7481c8c0661682cbfeca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec541a43_07905701","updated":"2024-12-09 08:48:25.000000000","message":"At least write in the commit message what are you fixing","commit_id":"708b460fac6978c734435f5615644c63f57ba9f9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76a4f879313e9f6455c7f3dd792f257e231ec5b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2902e2a7_e811c6ad","in_reply_to":"d1a980dc_ed94152f","updated":"2024-12-11 11:51:30.000000000","message":"Done, ready","commit_id":"708b460fac6978c734435f5615644c63f57ba9f9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ccf949a939dc6b38eabae2df05ca8e27cfa35168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1a980dc_ed94152f","in_reply_to":"ec541a43_07905701","updated":"2024-12-09 08:56:50.000000000","message":"Yep, stil  wip.","commit_id":"708b460fac6978c734435f5615644c63f57ba9f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0920ba747d6c3ca094666e278f5b79335cc2949e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4c4fa0c5_7794b085","updated":"2024-12-11 11:40:34.000000000","message":"for posterity","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dceb5f16c2606054d3f7f571f940faaaddceddc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"51e8d7a9_b35a10df","updated":"2024-12-11 11:29:46.000000000","message":"just to note that reno is not needed as this is only in master","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"779645a6546ac3ca40a1a67a9b35c9643e655b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"366ad5b4_e0d08038","updated":"2024-12-11 20:49:30.000000000","message":"recheck upgrade","commit_id":"6698a072d0169b2ecbad82322821eabd6186d090"}],"docker/letsencrypt/letsencrypt-lego/letsencrypt-certificates.sh":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a30679a2ddd2ef87661e1fa55020812cc7920a33","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"INTERNAL_SET\u003d\"false\""},{"line_number":110,"context_line":"EXTERNAL_SET\u003d\"false\""},{"line_number":111,"context_line":"EXTERNAL_ACCOUNT_BINDING\u003d\"false\""},{"line_number":112,"context_line":"EXTERNAL_ACCOUNT_BINDING\u003d\"false\""},{"line_number":113,"context_line":"HMAC\u003d\"NONE\""},{"line_number":114,"context_line":"KEY_ID\u003d\"NONE\""},{"line_number":115,"context_line":"LOG_FILE\u003d\"/var/log/kolla/letsencrypt/lesencrypt-lego.log\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"772797c7_b209870d","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":32},"updated":"2024-12-08 19:55:03.000000000","message":"duplicate","commit_id":"1537574c29b4bde0f384a1c7155bf9ff11776ec6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76a4f879313e9f6455c7f3dd792f257e231ec5b7","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"INTERNAL_SET\u003d\"false\""},{"line_number":110,"context_line":"EXTERNAL_SET\u003d\"false\""},{"line_number":111,"context_line":"EXTERNAL_ACCOUNT_BINDING\u003d\"false\""},{"line_number":112,"context_line":"EXTERNAL_ACCOUNT_BINDING\u003d\"false\""},{"line_number":113,"context_line":"HMAC\u003d\"NONE\""},{"line_number":114,"context_line":"KEY_ID\u003d\"NONE\""},{"line_number":115,"context_line":"LOG_FILE\u003d\"/var/log/kolla/letsencrypt/lesencrypt-lego.log\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7346f2cf_3d58d738","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":32},"in_reply_to":"772797c7_b209870d","updated":"2024-12-11 11:51:30.000000000","message":"Done","commit_id":"1537574c29b4bde0f384a1c7155bf9ff11776ec6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8d3a3948eaf61d3e5a0569704dc5ddd02429cb0f","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"69ee5040_6075dfe2","line":60,"updated":"2024-12-11 11:40:26.000000000","message":"so, if somebody sets eab, but hmac and key_id are NONE - we just silently ignore it?","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca6dae8c2c86cb4bb1bb7058687f5e1c8b66c856","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"4a840e46_c7528563","line":60,"in_reply_to":"10a75fe3_18365ee3","updated":"2024-12-11 11:56:37.000000000","message":"I guess kolla-ansible side is fine, but remembering Kolla User Forum sessions with half of the audience raising hands that they use Kolla images without Kolla-Ansible gives me proper chills ;-)","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a5b7976fec4168361712f0598f10f69052a6deb9","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ed0bc986_4a1099d2","line":60,"in_reply_to":"334550de_6d4d0f24","updated":"2024-12-11 12:05:12.000000000","message":"Sure, anything probably is better than nothing 😊","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"697bf16816bef27c3d8a6a87ca8e613494ac2bd4","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"334550de_6d4d0f24","line":60,"in_reply_to":"4a840e46_c7528563","updated":"2024-12-11 12:03:00.000000000","message":"well, I think I will add error here or maybe warning ? that there options are required and script will continue without ? WDYT ?","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76a4f879313e9f6455c7f3dd792f257e231ec5b7","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"10a75fe3_18365ee3","line":60,"in_reply_to":"69ee5040_6075dfe2","updated":"2024-12-11 11:51:30.000000000","message":"Well, I can add log_error and exit 1 of course, but this can be handled with prechecks in kolla-ansible in https://review.opendev.org/c/openstack/kolla-ansible/+/935656/11 as it is for example for letsencrypt_email.\n\nThis patch fixing the script, and original script also ignored EAB if it was not set ...\n\nSo, what is your opinion ? \nI think it\u0027s enough if @piotr@stackhpc.com will add prechecks as HMAC and KEY_ID are required when EAB turned on.","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7e21d0b8956d0424614d9e260e66a7649590771c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    [ ! -e \"/etc/letsencrypt/lego/${certificate_type}/certificates/${certificate_fqdn}.pem\" ] \u0026\u0026 local lego_action\u003d\"run\" || local lego_action\u003d\"renew\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if [ \"${eab}\" \u003d \"true\" ] \u0026\u0026 [ \"${hmac}\" !\u003d \"NONE\" ] \u0026\u0026 [ \"${key_id}\" !\u003d \"NONE\" ]; then"},{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7c07f5bc_1c8fb72d","line":60,"in_reply_to":"ed0bc986_4a1099d2","updated":"2024-12-11 12:51:35.000000000","message":"Done","commit_id":"3e69a4d7944f6a1adf7152138be0536feda077a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9dc76cd7458605e73a7c834c5c9b0367254de2c1","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""},{"line_number":64,"context_line":"        log_error \"External Account Binding requires EAB key ID and EAB HMAC key.\""},{"line_number":65,"context_line":"        exit 1"},{"line_number":66,"context_line":"    fi"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"2394287d_f5062368","line":64,"updated":"2024-12-11 13:39:45.000000000","message":"won\u0027t that fail every time now?","commit_id":"002360d2e61b2a41e3b1ec81268e38f73e2196ac"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9bd0431d4e23b9f4e1014c94f0679b4f7c3eb59e","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""},{"line_number":64,"context_line":"        log_error \"External Account Binding requires EAB key ID and EAB HMAC key.\""},{"line_number":65,"context_line":"        exit 1"},{"line_number":66,"context_line":"    fi"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"c7ad0066_89a1fdbe","line":64,"in_reply_to":"2394287d_f5062368","updated":"2024-12-11 13:41:49.000000000","message":"Good catch, ups :/ Sorry","commit_id":"002360d2e61b2a41e3b1ec81268e38f73e2196ac"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc3d965c746fb5c4f8707ee7bd892352a3ce2ea9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        eab_opts\u003d\"--eab --hmac ${hmac} --kid ${key_id}\""},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        eab_opts\u003d\"\""},{"line_number":64,"context_line":"        log_error \"External Account Binding requires EAB key ID and EAB HMAC key.\""},{"line_number":65,"context_line":"        exit 1"},{"line_number":66,"context_line":"    fi"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"9799ef43_142b521f","line":64,"in_reply_to":"c7ad0066_89a1fdbe","updated":"2024-12-11 13:47:45.000000000","message":"Done","commit_id":"002360d2e61b2a41e3b1ec81268e38f73e2196ac"}]}