)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ecd2c3964678d50b69d8ca299ac945262ab86fa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89e14dd6_726a641b","updated":"2025-06-10 14:45:00.000000000","message":"@will@stackhpc.com Do we still need that given inspector has been sunset?","commit_id":"55045c594df5ea53323a1428d63eb4d7166e2c29"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a99ee21608053291fa30395a6bbcb48deec7129e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2bfe388c_6a9a9f29","in_reply_to":"89e14dd6_726a641b","updated":"2025-08-20 11:33:25.000000000","message":"We do indeed. This is the for the new inspector rather than the standalone one. See:\n\nhttps://docs.openstack.org/ironic/latest/admin/inspection/pxe_filter.html","commit_id":"55045c594df5ea53323a1428d63eb4d7166e2c29"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ab01bd43d3124b56da8173f0fce529476a8452cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff5e13af_9cce14b8","updated":"2025-09-09 16:43:40.000000000","message":"recheck depends-on changed","commit_id":"a64871f33d4fdf011c82b76d5b16d80e51c50c1c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d72fdfa9ceb100678cf8f8ede4ff1f34c475f43e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5dd23ab8_961b0e30","updated":"2025-09-12 08:56:32.000000000","message":"recheck","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98f1dbb8002c6f593dc39da712a9a672bbe40252","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2bd7d1d0_3dea6f8e","updated":"2025-09-19 12:03:40.000000000","message":"please fix docker/dnsmasq/extend_start.sh\notherwise LGTM","commit_id":"dbbce823eee02c072f1bedb0e18d61b71eb25727"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1509f4aee18497784b27de0f7078d4ec6c99af50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"33939197_ffb3d716","in_reply_to":"2bd7d1d0_3dea6f8e","updated":"2025-09-19 15:50:12.000000000","message":"Oops, good spot - totally missed that","commit_id":"dbbce823eee02c072f1bedb0e18d61b71eb25727"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d882b0916ac985e02e38b583546bea51136ccd2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"da34c4bf_87f48794","in_reply_to":"33939197_ffb3d716","updated":"2025-09-19 15:51:15.000000000","message":"Done","commit_id":"dbbce823eee02c072f1bedb0e18d61b71eb25727"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"23789bfd982e300ead3de1416c9174b940b9dc3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"69a511d3_e45e1338","updated":"2025-10-03 10:39:35.000000000","message":"recheck - debian repo issues","commit_id":"bacaf8f49412271ebcd3ed5294e2b1435d74ed29"}],"docker/dnsmasq/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1225c7affe016f31c2b76d16bfac4eac3ab9fcab","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"4db7c930_dc7fc494","line":18,"updated":"2025-09-12 08:57:57.000000000","message":"Why not just change dnsmasq pid file location?","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"50382c892b13437ac27b31732a8e3e27b929c02c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"45075dc0_e2e77316","line":18,"in_reply_to":"252071c8_d9dd2bf9","updated":"2025-09-12 17:35:47.000000000","message":"Seems like that is the behaviour:\n\n    [1]+  Stopped                 dnsmasq -x /tmp/test --no-daemon\n    (ironic-dnsmasq)[root@kayobe-dev-ubuntu /]# cat /tmp/test\n    cat: /tmp/test: No such file or directory\n\nBut without --no-daemon:\n\n\t(ironic-dnsmasq)[root@kayobe-dev-ubuntu /]# dnsmasq -x /tmp/test\n\t(ironic-dnsmasq)[root@kayobe-dev-ubuntu /]# cat /tmp/test\n\t42420","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a802ea5d021dc9b758843226265a9f229803cae9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ac70e2c0_00e48b9c","line":18,"in_reply_to":"32a4cde9_2afc3f8a","updated":"2025-09-16 05:10:08.000000000","message":"Should we use —keep-in-foreground then?","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0e447cfd7e00a7ee6bb81da16dc4c1d3ec85c66e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"32a4cde9_2afc3f8a","line":18,"in_reply_to":"45075dc0_e2e77316","updated":"2025-09-12 18:05:37.000000000","message":"-d, --no-daemon\n\t    Debug mode: don\u0027t fork to the background, don\u0027t write a pid file, don\u0027t change user id, generate a complete cache dump on receipt on SIGUSR1, log to stderr as well as syslog, don\u0027t fork new processes to handle TCP queries. Note that this option is for use in debugging only, to stop dnsmasq daemonising in production, use --keep-in-foreground.","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a35e3604bd81e1c0200b65edac96d9207d0156fe","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"a72441c4_93bedf78","line":18,"in_reply_to":"4db7c930_dc7fc494","updated":"2025-09-12 12:27:25.000000000","message":"I\u0027d missed that option. Should we switch?","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e9a625008a314cabeba02b8bffc68b125ab1170e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"c8254613_e7cd265c","line":18,"in_reply_to":"60e8147e_d756819b","updated":"2025-09-19 10:18:46.000000000","message":"Can you update the Kolla-Ansible side of this?","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d39d1b3cfea906d6c409cf7c9d15150a7e39702c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"252071c8_d9dd2bf9","line":18,"in_reply_to":"a72441c4_93bedf78","updated":"2025-09-12 17:30:41.000000000","message":"So I gave it a go and it didn\u0027t seem to work:\n\n    # NOTE(yoctozepto): ironic-dnsmasq is used to deliver DHCP(v6) service\n    # DNS service is disabled:\n    port\u003d0\n    pid-file\u003d/tmp/test\n    interface\u003dbreth1\n    bind-interfaces\n\nAnd that didn\u0027t seem to write a file. Perhaps because we use dnsmasq --no-daemon?","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e0bba0530bace3bc7c48d00b82659ee708dc237b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ef86bae5_8f2e3d7a","line":18,"in_reply_to":"ac70e2c0_00e48b9c","updated":"2025-09-19 10:17:04.000000000","message":"Seems like we should use `—keep-in-foreground ` given the comment: \"to stop dnsmasq daemonising in production, use --keep-in-foreground\". That said, it still doesn\u0027t create the pidfile. I did some digging and that only seems to get created when the process forks i.e not using --keep-in-foreground or --no-daemon. So if we wanted to use the pid file feature, I guess we\u0027d need some other process to manage the forked process (systemd?), which doesn\u0027t seem desirable.","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"72723df73487bc5e3a9b368b0b5cc92c86fcc328","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"d3166eb9_191fc339","line":18,"in_reply_to":"c8254613_e7cd265c","updated":"2025-09-19 10:22:18.000000000","message":"Yep, no worries. I\u0027ll get that done today.","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9ae26ce199e9d8b9768885d7fda074f6f87b3d01","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"058cfe8a_fc7d52f8","line":18,"in_reply_to":"d3166eb9_191fc339","updated":"2025-09-19 11:36:26.000000000","message":"Done","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0fb5d83ab88b634011c855539e066b009806e11","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    mkdir -p /run/ironic/"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $$ \u003e /run/ironic/dnsmasq.pid"}],"source_content_type":"text/x-sh","patch_set":8,"id":"60e8147e_d756819b","line":18,"in_reply_to":"ef86bae5_8f2e3d7a","updated":"2025-09-19 10:18:24.000000000","message":"I didn\u0027t mean it\u0027s going to be better and we don\u0027t need that ,,hack\u0027\u0027, but we should switch to --keep-in-foreground instead of --no-daemon (whatever the difference between them is). :-)","commit_id":"1e219f43d7ebb12ef1ac5a413bf5bf2f942f5198"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3bf114b3e829edb63a606408fa82c254d58987f4","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    mkdir -p \"$DNSMASQ_PIDFILE_DIR\""},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"echo $$ \u003e \"$DNSMASQ_PIDFILE\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"86a6bbd6_3073f38d","line":21,"updated":"2025-09-19 10:19:25.000000000","message":"Let\u0027s add a NOTE here why we\u0027re doing it","commit_id":"15c941a7edc954802a4e2b1bea24e22531d2b908"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"88d95b86fdf88b90090e31c757d7eefc44cf796e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    mkdir -p \"$DNSMASQ_PIDFILE_DIR\""},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"echo $$ \u003e \"$DNSMASQ_PIDFILE\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"6ce59ef1_c43cedda","line":21,"in_reply_to":"6107e1a5_e1f3b277","updated":"2025-09-19 10:34:27.000000000","message":"Done","commit_id":"15c941a7edc954802a4e2b1bea24e22531d2b908"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"72723df73487bc5e3a9b368b0b5cc92c86fcc328","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    mkdir -p \"$DNSMASQ_PIDFILE_DIR\""},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"echo $$ \u003e \"$DNSMASQ_PIDFILE\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"6107e1a5_e1f3b277","line":21,"in_reply_to":"86a6bbd6_3073f38d","updated":"2025-09-19 10:22:18.000000000","message":"Sounds reasonable - thanks","commit_id":"15c941a7edc954802a4e2b1bea24e22531d2b908"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98f1dbb8002c6f593dc39da712a9a672bbe40252","unresolved":true,"context_lines":[{"line_number":1,"context_line":"]#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"DNSMASQ_PIDFILE\u003d${DNSMASQ_PIDFILE:-/run/ironic/dnsmasq.pid}"},{"line_number":4,"context_line":"DNSMASQ_PIDFILE_DIR\u003d\"$(dirname $DNSMASQ_PIDFILE)\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"d3397806_d63b6236","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2025-09-19 12:03:40.000000000","message":"extra symbol","commit_id":"dbbce823eee02c072f1bedb0e18d61b71eb25727"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1509f4aee18497784b27de0f7078d4ec6c99af50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"]#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"DNSMASQ_PIDFILE\u003d${DNSMASQ_PIDFILE:-/run/ironic/dnsmasq.pid}"},{"line_number":4,"context_line":"DNSMASQ_PIDFILE_DIR\u003d\"$(dirname $DNSMASQ_PIDFILE)\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"71c8c886_140ace58","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"in_reply_to":"d3397806_d63b6236","updated":"2025-09-19 15:50:12.000000000","message":"Oops, good spot - totally missed that - thanks","commit_id":"dbbce823eee02c072f1bedb0e18d61b71eb25727"}]}