)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"9fa2af06fa7f9f7e2d5841a26246152a8d737420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"909245a6_320ec2cf","updated":"2025-03-19 08:49:54.000000000","message":"recheck - ci should be fixed by now","commit_id":"113c75ac872ce228d8b37fbc1134e3b840788625"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"745813884b81a5d736d2e5914600fd61662eec00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3cd678b6_c85f1928","updated":"2025-03-25 16:14:02.000000000","message":"Needs also a reno (or a bug if you want to backport that)","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ed0ce80d2321e6b75349dfbd0ecc58580057d143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6ad2ba26_41dc1ad8","updated":"2025-03-25 15:48:03.000000000","message":"reno would be nice","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":34212,"name":"Matt Anson","email":"matta@stackhpc.com","username":"m-anson","status":"StackHPC"},"change_message_id":"4ef665f6a82a28dec0512a5848b499d8eec20c24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ffa040e_c9c5f9ff","in_reply_to":"3cd678b6_c85f1928","updated":"2025-03-26 18:29:35.000000000","message":"Added","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"}],"docker/ironic/ironic-pxe/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"745813884b81a5d736d2e5914600fd61662eec00","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # was ipxe.efi. Ensure that both exist, using symlinks where the files are"},{"line_number":44,"context_line":"    # named differently to allow the original names to be used in ironic.conf."},{"line_number":45,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]]; then"},{"line_number":46,"context_line":"        # NOTE(m-anson): Debian ipxe package doesn\u0027t create /boot/ipxe-arm64.efi"},{"line_number":47,"context_line":"        cp /usr/lib/ipxe/{undionly.kpxe,ipxe.efi,snponly.efi} ${TFTPBOOT_PATH}/"},{"line_number":48,"context_line":"    elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":49,"context_line":"        # NOTE(m-anson): ipxe-arm64.efi is not symlinked from /boot to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ce9cc204_681f5a20","line":46,"updated":"2025-03-25 16:14:02.000000000","message":"What\u0027s the relevance of that NOTE since the next line has not been changed in any way? \nDo you mean that Debian packaged files only end up in /usr/lib/ipxe so no need for linking? \nIf that\u0027s the case, we could just check for the existence of /usr/lib/ipxe/ipxe-arm64.efi instead of multiplying the same code?","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96e4727291ecc7c8c1d3f67ce3acc335ca79e3a5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # was ipxe.efi. Ensure that both exist, using symlinks where the files are"},{"line_number":44,"context_line":"    # named differently to allow the original names to be used in ironic.conf."},{"line_number":45,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]]; then"},{"line_number":46,"context_line":"        # NOTE(m-anson): Debian ipxe package doesn\u0027t create /boot/ipxe-arm64.efi"},{"line_number":47,"context_line":"        cp /usr/lib/ipxe/{undionly.kpxe,ipxe.efi,snponly.efi} ${TFTPBOOT_PATH}/"},{"line_number":48,"context_line":"    elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":49,"context_line":"        # NOTE(m-anson): ipxe-arm64.efi is not symlinked from /boot to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"826e7ed7_7114dfd0","line":46,"in_reply_to":"13b68155_fdcf2474","updated":"2025-03-27 10:00:59.000000000","message":"I\u0027d say let\u0027s don\u0027t repeat the same lines please","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dbc69a25fc09f134321708a8c354dbb584955221","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # was ipxe.efi. Ensure that both exist, using symlinks where the files are"},{"line_number":44,"context_line":"    # named differently to allow the original names to be used in ironic.conf."},{"line_number":45,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]]; then"},{"line_number":46,"context_line":"        # NOTE(m-anson): Debian ipxe package doesn\u0027t create /boot/ipxe-arm64.efi"},{"line_number":47,"context_line":"        cp /usr/lib/ipxe/{undionly.kpxe,ipxe.efi,snponly.efi} ${TFTPBOOT_PATH}/"},{"line_number":48,"context_line":"    elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":49,"context_line":"        # NOTE(m-anson): ipxe-arm64.efi is not symlinked from /boot to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"c2e0c351_0447f5e3","line":46,"in_reply_to":"49941240_a0916f60","updated":"2025-03-30 21:54:49.000000000","message":"Done","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":34212,"name":"Matt Anson","email":"matta@stackhpc.com","username":"m-anson","status":"StackHPC"},"change_message_id":"2b146bb0bd91dff4dc37fae97327c4a73174378f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # was ipxe.efi. Ensure that both exist, using symlinks where the files are"},{"line_number":44,"context_line":"    # named differently to allow the original names to be used in ironic.conf."},{"line_number":45,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]]; then"},{"line_number":46,"context_line":"        # NOTE(m-anson): Debian ipxe package doesn\u0027t create /boot/ipxe-arm64.efi"},{"line_number":47,"context_line":"        cp /usr/lib/ipxe/{undionly.kpxe,ipxe.efi,snponly.efi} ${TFTPBOOT_PATH}/"},{"line_number":48,"context_line":"    elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":49,"context_line":"        # NOTE(m-anson): ipxe-arm64.efi is not symlinked from /boot to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"49941240_a0916f60","line":46,"in_reply_to":"826e7ed7_7114dfd0","updated":"2025-03-27 11:34:34.000000000","message":"Updated","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"},{"author":{"_account_id":34212,"name":"Matt Anson","email":"matta@stackhpc.com","username":"m-anson","status":"StackHPC"},"change_message_id":"4ef665f6a82a28dec0512a5848b499d8eec20c24","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # was ipxe.efi. Ensure that both exist, using symlinks where the files are"},{"line_number":44,"context_line":"    # named differently to allow the original names to be used in ironic.conf."},{"line_number":45,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]]; then"},{"line_number":46,"context_line":"        # NOTE(m-anson): Debian ipxe package doesn\u0027t create /boot/ipxe-arm64.efi"},{"line_number":47,"context_line":"        cp /usr/lib/ipxe/{undionly.kpxe,ipxe.efi,snponly.efi} ${TFTPBOOT_PATH}/"},{"line_number":48,"context_line":"    elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":49,"context_line":"        # NOTE(m-anson): ipxe-arm64.efi is not symlinked from /boot to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"13b68155_fdcf2474","line":46,"in_reply_to":"ce9cc204_681f5a20","updated":"2025-03-26 18:29:35.000000000","message":"The Debian package doesn\u0027t build ipxe-arm64.efi at all. The Ubuntu package does build it, and puts the resulting file at /boot, but doesn\u0027t symlink it back to /usr/lib/ipxe like it does the other (x86-related) files in /boot.\n\nI suggested this approach as it obviously splits the Debian and Ubuntu approaches to packaging, and there\u0027s some obvious notes to come back to, though I\u0027m happy to try and reduce the code duplication if that\u0027s more important","commit_id":"12ddfb7dc4eca50d1df6339116bbb18bcf3bc3cc"}]}