)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f27bbfeebd09ddca3de94e30711c595c62028c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97187532_23884ebf","updated":"2025-05-22 06:44:27.000000000","message":"backport might be good if we want to support py313 on 2025.1","commit_id":"e13801b4a1e5f587ee0581168eea0d42fea6cb66"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2a77f4b590d8177dfca07b4daf90ed998f64e890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad48bed7_596dfc97","updated":"2025-05-22 08:48:33.000000000","message":"recheck ubuntu-upgrade inline-blo issue","commit_id":"e13801b4a1e5f587ee0581168eea0d42fea6cb66"}],"tests/test_set_config.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"58f40805cbae77110b14ffb2acc8d8bd387878ab","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        with mock.patch.object(set_configs, \u0027open\u0027, mo):"},{"line_number":49,"context_line":"            config \u003d set_configs.load_config()"},{"line_number":50,"context_line":"            set_configs.copy_config(config)"},{"line_number":51,"context_line":"            self.assertEqual(["},{"line_number":52,"context_line":"                mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027),"},{"line_number":53,"context_line":"                mock.call().__enter__(),"},{"line_number":54,"context_line":"                mock.call().read(),"},{"line_number":55,"context_line":"                mock.call().__exit__(None, None, None),"},{"line_number":56,"context_line":"                mock.call(\u0027/run_command\u0027, \u0027w+\u0027),"},{"line_number":57,"context_line":"                mock.call().__enter__(),"},{"line_number":58,"context_line":"                mock.call().write(\u0027/bin/true\u0027),"},{"line_number":59,"context_line":"                mock.call().__exit__(None, None, None)], mo.mock_calls)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"FAKE_CONFIG_FILES \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"36f04272_7cfc9e9b","side":"PARENT","line":59,"range":{"start_line":51,"start_character":12,"end_line":59,"end_character":71},"updated":"2025-05-20 14:01:46.000000000","message":"maybe ?\n```\n            self.assertEqual(\n                [mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027)]+\n                [mock.call().__enter__()]+\n                [mock.call().read()]+\n                [mock.call().__exit__(None, None, None)]+\n                ([mock.call().close()] if sys.version_info \u003e\u003d (3, 13) else []+\n                [mock.call(\u0027/run_command\u0027, \u0027w+\u0027)]+\n                [mock.call().__enter__()]+\n                [mock.call().write(\u0027/bin/true\u0027)]+\n                [mock.call().__exit__(None, None, None)]+\n                ([mock.call().close()] if sys.version_info \u003e\u003d (3, 13) else [],\n                mo.mock_calls)\n```","commit_id":"8af831c75afd2d6fa19123748d4237c56cc07b33"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f4ced9e7ba19158045e1e49b3def5d07f463315f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        with mock.patch.object(set_configs, \u0027open\u0027, mo):"},{"line_number":49,"context_line":"            config \u003d set_configs.load_config()"},{"line_number":50,"context_line":"            set_configs.copy_config(config)"},{"line_number":51,"context_line":"            self.assertEqual(["},{"line_number":52,"context_line":"                mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027),"},{"line_number":53,"context_line":"                mock.call().__enter__(),"},{"line_number":54,"context_line":"                mock.call().read(),"},{"line_number":55,"context_line":"                mock.call().__exit__(None, None, None),"},{"line_number":56,"context_line":"                mock.call(\u0027/run_command\u0027, \u0027w+\u0027),"},{"line_number":57,"context_line":"                mock.call().__enter__(),"},{"line_number":58,"context_line":"                mock.call().write(\u0027/bin/true\u0027),"},{"line_number":59,"context_line":"                mock.call().__exit__(None, None, None)], mo.mock_calls)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"FAKE_CONFIG_FILES \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"94c0fa0b_4b92557d","side":"PARENT","line":59,"range":{"start_line":51,"start_character":12,"end_line":59,"end_character":71},"in_reply_to":"36f04272_7cfc9e9b","updated":"2025-05-21 15:51:54.000000000","message":"Acknowledged","commit_id":"8af831c75afd2d6fa19123748d4237c56cc07b33"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f56e47824e8af2b65e9b7c71e48892e96cb71452","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        with mock.patch.object(set_configs, \u0027open\u0027, mo):"},{"line_number":49,"context_line":"            config \u003d set_configs.load_config()"},{"line_number":50,"context_line":"            set_configs.copy_config(config)"},{"line_number":51,"context_line":"            self.assertEqual(["},{"line_number":52,"context_line":"                mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027),"},{"line_number":53,"context_line":"                mock.call().__enter__(),"},{"line_number":54,"context_line":"                mock.call().read(),"},{"line_number":55,"context_line":"                mock.call().__exit__(None, None, None),"},{"line_number":56,"context_line":"                mock.call(\u0027/run_command\u0027, \u0027w+\u0027),"},{"line_number":57,"context_line":"                mock.call().__enter__(),"},{"line_number":58,"context_line":"                mock.call().write(\u0027/bin/true\u0027),"},{"line_number":59,"context_line":"                mock.call().__exit__(None, None, None)], mo.mock_calls)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"FAKE_CONFIG_FILES \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bd45bdf5_6bc71a41","side":"PARENT","line":59,"range":{"start_line":51,"start_character":12,"end_line":59,"end_character":71},"in_reply_to":"94c0fa0b_4b92557d","updated":"2025-05-21 17:00:42.000000000","message":"or even:\n```\n            mock_close\u003d[mock.call().close()] if sys.version_info \u003e\u003d (3, 13) else []\n            self.assertEqual(\n                [mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027)]+\n                [mock.call().__enter__()]+\n                [mock.call().read()]+\n                [mock.call().__exit__(None, None, None)] + mock_call +\n                [mock.call(\u0027/run_command\u0027, \u0027w+\u0027)]+\n                [mock.call().__enter__()]+\n                [mock.call().write(\u0027/bin/true\u0027)]+\n                [mock.call().__exit__(None, None, None)] + mock_call, mo.mock_calls)\n```","commit_id":"8af831c75afd2d6fa19123748d4237c56cc07b33"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f27bbfeebd09ddca3de94e30711c595c62028c4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        with mock.patch.object(set_configs, \u0027open\u0027, mo):"},{"line_number":49,"context_line":"            config \u003d set_configs.load_config()"},{"line_number":50,"context_line":"            set_configs.copy_config(config)"},{"line_number":51,"context_line":"            self.assertEqual(["},{"line_number":52,"context_line":"                mock.call(\u0027/var/lib/kolla/config_files/config.json\u0027),"},{"line_number":53,"context_line":"                mock.call().__enter__(),"},{"line_number":54,"context_line":"                mock.call().read(),"},{"line_number":55,"context_line":"                mock.call().__exit__(None, None, None),"},{"line_number":56,"context_line":"                mock.call(\u0027/run_command\u0027, \u0027w+\u0027),"},{"line_number":57,"context_line":"                mock.call().__enter__(),"},{"line_number":58,"context_line":"                mock.call().write(\u0027/bin/true\u0027),"},{"line_number":59,"context_line":"                mock.call().__exit__(None, None, None)], mo.mock_calls)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"FAKE_CONFIG_FILES \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bdfff32f_105d90e3","side":"PARENT","line":59,"range":{"start_line":51,"start_character":12,"end_line":59,"end_character":71},"in_reply_to":"bd45bdf5_6bc71a41","updated":"2025-05-22 06:44:27.000000000","message":"While I agree that avoiding duplications is a good goal, I\u0027m not sure that it is necessary in this case, so I\u0027m approving this as is now, feel free to submit an update if you want","commit_id":"8af831c75afd2d6fa19123748d4237c56cc07b33"}]}