)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"b3c339e92e060d455ee833a2bb4e9cb44aad5b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c837e894_6081d412","updated":"2025-10-01 14:40:01.000000000","message":"recheck unrelated error","commit_id":"fc7867d5eb7c334c8140d46d51586bbb4da6720a"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2a06a65e44e49e9dd4b39a1e692dde6f3c4470dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c8b3eea_49bcebf5","updated":"2025-10-02 08:09:02.000000000","message":"recheck another unrelated failure","commit_id":"1f2e4e2173f8f2ae7633ac4ce580bf2bbdb6df5f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"fd358a5828e63e847784124297fa359e7c6e9d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c5997fb_50e21b87","updated":"2025-10-01 16:38:44.000000000","message":"recheck unrelated error","commit_id":"1f2e4e2173f8f2ae7633ac4ce580bf2bbdb6df5f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"bacbaba8f503b2a490263e936c55239436f605be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e4b3ee67_e60e9912","updated":"2025-10-02 15:14:28.000000000","message":"Looks good, nice and simple.","commit_id":"af5a7216e1d348b4d7fcec792c2142e50af3effd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"abaf2437d0abf04035edaddce9e12d71dc225be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"921cedd6_c0190963","updated":"2025-10-06 08:55:26.000000000","message":"LGTM","commit_id":"683ae79657532243a31ead1b35e82877f1778991"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"149703b9563ce212b49d4d6c1a35305c24db1609","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bff725e8_2f40e83b","updated":"2025-10-03 13:48:50.000000000","message":"Thanks Seunghun","commit_id":"683ae79657532243a31ead1b35e82877f1778991"}],"docker/mariadb/mariadb-base/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fdb897836f61161094e714d04b2475d3606f0f03","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ARG mariadb_version\u003d10.11"},{"line_number":38,"context_line":"ARG mariadb_healthcheck_url\u003dhttps://raw.githubusercontent.com/MariaDB/mariadb-docker/refs/heads/master/${mariadb_version}/healthcheck.sh"},{"line_number":39,"context_line":"{% endblock %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"RUN curl -o /usr/bin/healthcheck.sh ${mariadb_healthcheck_url} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fc52b356_c1834258","line":38,"updated":"2025-10-02 11:10:45.000000000","message":"Other option is to add this repo to sources.py and use the more natural mechanism - I think we tried to get rid of curl usage in all container images.","commit_id":"1f2e4e2173f8f2ae7633ac4ce580bf2bbdb6df5f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"45198aa87c63633be3d349689b69f7d15404be54","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ARG mariadb_version\u003d10.11"},{"line_number":38,"context_line":"ARG mariadb_healthcheck_url\u003dhttps://raw.githubusercontent.com/MariaDB/mariadb-docker/refs/heads/master/${mariadb_version}/healthcheck.sh"},{"line_number":39,"context_line":"{% endblock %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"RUN curl -o /usr/bin/healthcheck.sh ${mariadb_healthcheck_url} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6756e183_1fabd2dc","line":38,"in_reply_to":"fc52b356_c1834258","updated":"2025-10-02 14:45:20.000000000","message":"Acknowledged","commit_id":"1f2e4e2173f8f2ae7633ac4ce580bf2bbdb6df5f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c7b4fe5761448b219885fe94e0d570c09c6f4b5d","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ADD additions-archive /"},{"line_number":38,"context_line":"RUN cp /additions/mariadb-healthcheck/healthcheck.sh /usr/bin/healthcheck.sh \\"},{"line_number":39,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/healthcheck.sh"},{"line_number":40,"context_line":"{% endblock %}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"b5f8573d_adb23296","line":38,"updated":"2025-10-02 15:24:30.000000000","message":"nit: you can use install here to replace `cp` and `chmod`","commit_id":"d4f366759764f31d7090a8b7d676f1c1bfa7e2c6"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"def8d543f310ea8ff02a403e3ddeebf81d3a6e97","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ADD additions-archive /"},{"line_number":38,"context_line":"RUN cp /additions/mariadb-healthcheck/healthcheck.sh /usr/bin/healthcheck.sh \\"},{"line_number":39,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/healthcheck.sh"},{"line_number":40,"context_line":"{% endblock %}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1db209c9_b5229ae0","line":38,"in_reply_to":"b5f8573d_adb23296","updated":"2025-10-02 15:58:41.000000000","message":"Done","commit_id":"d4f366759764f31d7090a8b7d676f1c1bfa7e2c6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"837bab0f9e5a89d4735f01c1f17a861d21e80286","unresolved":true,"context_lines":[{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ENV MARIADB_VERSION\u003d10.11"},{"line_number":38,"context_line":"ADD plugins-archive /"},{"line_number":39,"context_line":"RUN HEALTHCHECK_PATH\u003d$(find / -wholename \"*/$MARIADB_VERSION/healthcheck.sh\") \\"},{"line_number":40,"context_line":"    \u0026\u0026 echo \"HEALTHCHECK_PATH: $HEALTHCHECK_PATH\" \\"},{"line_number":41,"context_line":"    \u0026\u0026 install -m 755 \"$HEALTHCHECK_PATH\" /usr/bin/healthcheck.sh"},{"line_number":42,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"76ba9b49_1d419f91","line":39,"updated":"2025-10-03 13:40:02.000000000","message":"Line 39-41 could be simplified to:\n\n```\nRUN install -m 755  /plugins/mariadb-base-plugin-mariadb-docker-archive-*/$MARIADB_VERSION/healthcheck.sh /usr/bin/healthcheck.sh\n``","commit_id":"dbad9866c1fece11cb232f5a9db354a6b79dd8de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"01731435085f53c3fcb1741e5d95e85bcbdd4fcf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"{% block mariadb_healthcheck %}"},{"line_number":37,"context_line":"ENV MARIADB_VERSION\u003d10.11"},{"line_number":38,"context_line":"ADD plugins-archive /"},{"line_number":39,"context_line":"RUN HEALTHCHECK_PATH\u003d$(find / -wholename \"*/$MARIADB_VERSION/healthcheck.sh\") \\"},{"line_number":40,"context_line":"    \u0026\u0026 echo \"HEALTHCHECK_PATH: $HEALTHCHECK_PATH\" \\"},{"line_number":41,"context_line":"    \u0026\u0026 install -m 755 \"$HEALTHCHECK_PATH\" /usr/bin/healthcheck.sh"},{"line_number":42,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"d2a207da_a07795c8","line":39,"in_reply_to":"76ba9b49_1d419f91","updated":"2025-10-03 13:44:57.000000000","message":"Acknowledged","commit_id":"dbad9866c1fece11cb232f5a9db354a6b79dd8de"}],"kolla/common/sources.py":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e26ad6249ca47acb10de5a29d80958820ce49064","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":194,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/manila/\u0027"},{"line_number":195,"context_line":"                     \u0027manila-${openstack_branch}.tar.gz\u0027)},"},{"line_number":196,"context_line":"    \u0027mariadb-healthcheck\u0027: {"},{"line_number":197,"context_line":"        \u0027version\u0027: \u002710.11\u0027,"},{"line_number":198,"context_line":"        \u0027reference\u0027: \u0027d5561744ccb530d4bfda0d873f318152ddc7ce8f\u0027,"},{"line_number":199,"context_line":"        \u0027type\u0027: \u0027url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b068bae6_09ef25ab","line":196,"updated":"2025-10-02 15:09:04.000000000","message":"I guess this needs to be named mariadb-base as it needs to be in that image context\n\nand then in Dockerfile\nADD mariadb-base-archive /usr/bin/healthcheck.sh","commit_id":"af5a7216e1d348b4d7fcec792c2142e50af3effd"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"44eeb3061f4ea1e61286ce8c3abf404dca9d94c8","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":194,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/manila/\u0027"},{"line_number":195,"context_line":"                     \u0027manila-${openstack_branch}.tar.gz\u0027)},"},{"line_number":196,"context_line":"    \u0027mariadb-healthcheck\u0027: {"},{"line_number":197,"context_line":"        \u0027version\u0027: \u002710.11\u0027,"},{"line_number":198,"context_line":"        \u0027reference\u0027: \u0027d5561744ccb530d4bfda0d873f318152ddc7ce8f\u0027,"},{"line_number":199,"context_line":"        \u0027type\u0027: \u0027url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"890365dd_e83c9ae0","line":196,"in_reply_to":"3d08e065_f925951c","updated":"2025-10-02 15:59:48.000000000","message":"looks like \u0027url\u0027 type sources always need to be a tar file. Switching to pulling the entire mariadb-docker repo then just installing healthcheck.sh","commit_id":"af5a7216e1d348b4d7fcec792c2142e50af3effd"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"4880b5c7490dfe09c337924101c84e39e2bd3334","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":194,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/manila/\u0027"},{"line_number":195,"context_line":"                     \u0027manila-${openstack_branch}.tar.gz\u0027)},"},{"line_number":196,"context_line":"    \u0027mariadb-healthcheck\u0027: {"},{"line_number":197,"context_line":"        \u0027version\u0027: \u002710.11\u0027,"},{"line_number":198,"context_line":"        \u0027reference\u0027: \u0027d5561744ccb530d4bfda0d873f318152ddc7ce8f\u0027,"},{"line_number":199,"context_line":"        \u0027type\u0027: \u0027url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3d08e065_f925951c","line":196,"in_reply_to":"b068bae6_09ef25ab","updated":"2025-10-02 15:19:24.000000000","message":"Yes I found this does not work. But as this is just a single script. I\u0027ll try using \u0027additions\u0027","commit_id":"af5a7216e1d348b4d7fcec792c2142e50af3effd"}]}
