)]}'
{"docker/nova/nova-compute-ironic/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1c054d48a09b95eb34d4c28e97fe451376f6a885","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":22,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":23,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":24,"context_line":"    \u0027xorriso\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a4b375f1_5320309a","line":21,"updated":"2026-07-10 15:19:54.000000000","message":"This needs to be reconciled with lines 10-19 above.","commit_id":"e317a43f115b328883d5643dc82d818c9166f85b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2903e213d104e0a9ffc3de9fde824769d061c543","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":22,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":23,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":24,"context_line":"    \u0027xorriso\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"854f3c1d_67ad942a","line":21,"in_reply_to":"a4b375f1_5320309a","updated":"2026-07-10 15:23:02.000000000","message":"Done","commit_id":"e317a43f115b328883d5643dc82d818c9166f85b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"bd59cf37c9bf840eda0535de856e909101852dc1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":11,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":12,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":13,"context_line":"    \u0027xorriso\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"df531054_5c893ac8","line":13,"updated":"2026-07-10 15:31:24.000000000","message":"You could add genisoimage to the list on line10 and keep the if statement?\n\nThat way, you don\u0027t install `xorriso` into anything in the else branch keeping the old behaviour","commit_id":"41252f756d5f389ee267cf1a871fa8091e135659"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"11631c74407d95a7b4fe2a5e84f31520ee5e6039","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":11,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":12,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":13,"context_line":"    \u0027xorriso\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"2313b7c8_5bdd0d0c","line":13,"in_reply_to":"8ff1902b_cc9aee09","updated":"2026-07-14 15:05:52.000000000","message":"Done","commit_id":"41252f756d5f389ee267cf1a871fa8091e135659"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c015f67223f3288cad867e4d2f0557cc05de0ade","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":11,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":12,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":13,"context_line":"    \u0027xorriso\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ecf56743_bc5775b6","line":13,"in_reply_to":"df531054_5c893ac8","updated":"2026-07-13 07:36:44.000000000","message":"Wouldn\u0027t applying the newer code from 2025.2 make more sense?","commit_id":"41252f756d5f389ee267cf1a871fa8091e135659"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c00725dec7355566be7bb99b25b4fb6f31e418cf","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":11,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":12,"context_line":"    \u0027nvme-cli\u0027,"},{"line_number":13,"context_line":"    \u0027xorriso\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8ff1902b_cc9aee09","line":13,"in_reply_to":"ecf56743_bc5775b6","updated":"2026-07-13 08:26:38.000000000","message":"I don\u0027t think so - the images in the else branch already have ``genisoimage`` installed. There is no need to install ``xorriso`` into them.","commit_id":"41252f756d5f389ee267cf1a871fa8091e135659"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"285fc14af3756590958e93c5280c9b1a9dbb2ed8","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        \u0027xorriso\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"    {% set nova_compute_ironic_packages \u003d nova_compute_ironic_packages + ["},{"line_number":20,"context_line":"        \u0027genisoimage\u0027"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d1064038_f35585c1","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":39},"updated":"2026-07-14 20:12:29.000000000","message":"nova_compute_ironic_packages already contains \u0027genisoimage\u0027","commit_id":"82972528e552c27d0b09f23ecf27790c1fbb4721"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9b620ad0dec9e8b21ce9ad2357cfa583bac65e4d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027xorriso\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"    {% set nova_compute_ironic_packages \u003d nova_compute_ironic_packages + ["},{"line_number":20,"context_line":"        \u0027genisoimage\u0027"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"2c9dd2c0_935d2497","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":39},"in_reply_to":"70363b5a_29409547","updated":"2026-07-15 08:50:53.000000000","message":"Done","commit_id":"82972528e552c27d0b09f23ecf27790c1fbb4721"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f830cb8ccfb1767f736312db0cc88b047f0e87d4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        \u0027xorriso\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"    {% set nova_compute_ironic_packages \u003d nova_compute_ironic_packages + ["},{"line_number":20,"context_line":"        \u0027genisoimage\u0027"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"70363b5a_29409547","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":39},"in_reply_to":"d1064038_f35585c1","updated":"2026-07-15 08:22:27.000000000","message":"+1","commit_id":"82972528e552c27d0b09f23ecf27790c1fbb4721"}]}
