)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"4f80e472216bda6c7aabfbbc55a468083e558acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b2607ddc_2e2793ec","updated":"2025-12-14 22:27:28.000000000","message":"Looks reasonable to me.","commit_id":"23e0bd27955c34a278527b648cfd84527162d32a"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"4add1f88e01df1aa6cb8a35bc2cfe150f80d7d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"93bac558_7de0613d","updated":"2025-12-15 21:51:00.000000000","message":"Still looks reasonable to me.","commit_id":"807ed9744f35cd7ae8d6795ae6692bcf98da185c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf5c1638d5e582ff2aab63e579bb95c9bbf77183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"148c1fbf_34ab2c5b","updated":"2025-12-16 10:02:48.000000000","message":"merging given previous +2","commit_id":"a7ee5ccb2b551af5be80c0f082e503f6cbd54096"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"91b39fbc00a8357f33116f8c4f63be6fc66c1b51","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"d58279a3_556708c2","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"updated":"2025-12-15 16:26:50.000000000","message":"shouldn\u0027t we use force copy since removed rm -f ?","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"69213bf1f36e673a2f0b5a1398de60cf3ea6edbf","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"776073f4_6b8a1f94","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"0f33897f_d3de8eb3","updated":"2025-12-15 16:32:55.000000000","message":"RUN cp -f ?","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"906e3bd45f7d1a8aa5dbcef37096366ee0f3f2ac","unresolved":false,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"20e40b76_cfa57de1","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"3a8b6e2b_f671db8d","updated":"2025-12-15 16:55:03.000000000","message":"okay, will check it later","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"58f06f9137d39b8dd5397b564c025fbbaec2f8ce","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"967e4fb4_993acd36","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"4f6bf3ac_1b0341f6","updated":"2025-12-15 16:36:32.000000000","message":"so shouldn\u0027t we leave RUN rm -f untouched?","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"24c32cd1949444bd151db4f76376019aa5167197","unresolved":false,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"4f6bf3ac_1b0341f6","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"776073f4_6b8a1f94","updated":"2025-12-15 16:35:04.000000000","message":"It won\u0027t copy from outside the container, and debian/ubuntu.sources that we copy in is in docker/base/, not inside the image we\u0027re running the commands.","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"adf418c576efd2ded2f11a9eac84aec2a91135b7","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"e0fda07a_31570aa5","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"86846f45_c45aa209","updated":"2025-12-15 16:38:45.000000000","message":"The file can exist if it is, for example, a custom image.","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"90beaa3b653776d8af518bb7b94808687aa99ebd","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"86846f45_c45aa209","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"967e4fb4_993acd36","updated":"2025-12-15 16:37:23.000000000","message":"Why?","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce523e72e25147b42f5b9835c901b6b6d190a283","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"0f33897f_d3de8eb3","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"d58279a3_556708c2","updated":"2025-12-15 16:30:07.000000000","message":"What do you mean by force copy? There\u0027s no --force in https://docs.docker.com/reference/dockerfile/#copy","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f6b384bf073aacca7dbabe4fc9774fe225b6056a","unresolved":true,"context_lines":[{"line_number":190,"context_line":"{# NOTE(mnasiadka): Ubuntu arm64 uses ports.ubuntu.com #}"},{"line_number":191,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":192,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":193,"context_line":"COPY {{ base_distro }}.sources.arm64 /etc/apt/sources.list.d/{{ base_distro }}.sources"},{"line_number":194,"context_line":"{% else %}"},{"line_number":195,"context_line":"COPY {{ base_distro }}.sources /etc/apt/sources.list.d/"},{"line_number":196,"context_line":"{% endif %}"},{"line_number":197,"context_line":"COPY sources.list /etc/apt/sources.list.d/kolla-custom.list"},{"line_number":198,"context_line":"{% endblock %}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"{% block base_debian_after_sources_list %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3a8b6e2b_f671db8d","line":197,"range":{"start_line":193,"start_character":0,"end_line":197,"end_character":59},"in_reply_to":"e0fda07a_31570aa5","updated":"2025-12-15 16:47:30.000000000","message":"It does exist even on the upstream image we use, and we just copy it over as a new layer - what\u0027s wrong with that?","commit_id":"09a907808417a5d77c35b9c7616fc0ce8875baf3"}],"docker/base/ubuntu.sources":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6588519e5840d0edfc4c14d3c0523433b903497f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Signed-By: /usr/share/keyrings/ubuntu-archive-keyring.gpg"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"## Ubuntu security updates. Aside from URIs and Suites,"},{"line_number":8,"context_line":"## this should mirror your choices in the previous section."},{"line_number":9,"context_line":"Types: deb"},{"line_number":10,"context_line":"URIs: http://security.ubuntu.com/ubuntu/"},{"line_number":11,"context_line":"Suites: noble-security"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"f201426e_1fb9a9a3","line":8,"range":{"start_line":8,"start_character":3,"end_line":8,"end_character":58},"updated":"2025-12-16 05:58:15.000000000","message":"above we have `Components: main universe`, so shouldn\u0027t we use the same here?","commit_id":"807ed9744f35cd7ae8d6795ae6692bcf98da185c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9273ede0ae926cf15ca7c2c43378095761bf6d01","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Signed-By: /usr/share/keyrings/ubuntu-archive-keyring.gpg"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"## Ubuntu security updates. Aside from URIs and Suites,"},{"line_number":8,"context_line":"## this should mirror your choices in the previous section."},{"line_number":9,"context_line":"Types: deb"},{"line_number":10,"context_line":"URIs: http://security.ubuntu.com/ubuntu/"},{"line_number":11,"context_line":"Suites: noble-security"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"8e860589_89e800b3","line":8,"range":{"start_line":8,"start_character":3,"end_line":8,"end_character":58},"in_reply_to":"f201426e_1fb9a9a3","updated":"2025-12-16 06:05:45.000000000","message":"Good catch, fixed.","commit_id":"807ed9744f35cd7ae8d6795ae6692bcf98da185c"}]}