)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d7dbd6421bea019e2643879a9931de7adc330b54","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92c3a096_2ede2fc5","updated":"2026-02-24 09:41:04.000000000","message":"How do you want to run that exporter? We usually have separate images for exporters","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9635233cc4d92f0dfd457c325c54f5d517efdc8b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9178f229_0df768f0","updated":"2026-02-24 09:02:12.000000000","message":"Please use sources.py like mostly everything else does","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"77ffe43c5b60e644d7832b6c74b2706ae8051c48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d542cda1_f9b69520","in_reply_to":"6c39d6d1_7828e167","updated":"2026-03-09 05:50:05.000000000","message":"This is what I wanted to write, that I prefer to wait until this gets properly packaged in rpm/deb","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"e14a59c50bb223b160329a83562ac4668a32ba3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b980b664_6eef6516","in_reply_to":"9178f229_0df768f0","updated":"2026-02-26 11:17:48.000000000","message":"The installation of the plugin requires the exact opensearch version which isn\u0027t available until the container is built so I don\u0027t think it\u0027s possible to use source.py(?) I will make sure to add a note explaining this in the dockerfile if so.","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fcfd8c349de297a488b39be3fe7d94d4b447216f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2a1cdd1_5b2a82d9","in_reply_to":"92c3a096_2ede2fc5","updated":"2026-02-25 11:52:13.000000000","message":"This is a plugin for the OpenSearch container. It adds a metrics endpoint to the OpenSearch service. I believe we only have separate images when there is no integrated metrics source, or we haven\u0027t switched to using one.\n\nAnother example of providing metrics via a plugin is RabbitMQ:\n\n```\n{% block rabbitmq_install_plugins %}\n\nRUN rm -rf /var/lib/rabbitmq/* \\\n    \u0026\u0026 mkdir -p /usr/lib/rabbitmq/plugins \\\n    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\\n       rabbitmq_management \\\n       rabbitmq_prometheus\n\n{% endblock %}\n```","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"1ff3b1f6e0b23ecfb463a53b6932430e842c33c4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c39d6d1_7828e167","in_reply_to":"b980b664_6eef6516","updated":"2026-03-08 10:54:04.000000000","message":"I am against this change. From what I checked some time ago, there is ongoing work to make the plugin available natively, so the installation will be done in the standard way:\n\n./bin/opensearch-plugin install opensearch-prometheus-exporter\n\nCurrently there is work in progress on building proper packages and CI so that everything stays aligned with the standards enforced by the OpenSearch core.","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ecb494cdcee3ad99436b7d8fb1d4a265521bcd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55106378_4a9e1a29","in_reply_to":"d542cda1_f9b69520","updated":"2026-03-09 10:18:49.000000000","message":"I think the plugin packaging method is to publish a zip on Maven? I\u0027m not sure that we will ever see a rpm/dev package.\n\nGiven that there is an alternative, it seems reasonable to block until the plugin can be \u0027installed by name\u0027 rather than directly from a versioned zip file using the plugin installer. Installing by name means that the version detection is handled automatically, under-the-hood. I hadn\u0027t realised that it wasn\u0027t supported yet.","commit_id":"44366e4afec352b7d0fc75df5ea913068d62b137"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"85bbda89c97abfca024af5f7ebc6570e31cba72b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e1036de_6e24b18d","updated":"2026-02-25 12:35:52.000000000","message":"I noticed that the ElasticSearch exporter now claims to support both OpenSearch and ElasticSearch which is new to me. That makes the argument to switch less clear. They both look to be maintained currently.","commit_id":"3aea7e1940297fcaa029238654ccdeb2e5124ec2"}],"docker/opensearch/opensearch/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"85bbda89c97abfca024af5f7ebc6570e31cba72b","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% block opensearch_plugins_install %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% set opensearch_version \u003d \u0027`/usr/share/opensearch/bin/opensearch --version | awk \\\u0027{print substr($2, 1, length($2)-1 ) \".0\" }\\\u0027`\u0027 %}"},{"line_number":32,"context_line":"{% set opensearch_default_plugins \u003d ["},{"line_number":33,"context_line":"    \"https://github.com/opensearch-project/opensearch-prometheus-exporter/releases/download/\" ~ opensearch_version ~ \"/prometheus-exporter-\" ~ opensearch_version ~ \".zip\""},{"line_number":34,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c5ec752b_d7d9d065","line":31,"updated":"2026-02-25 12:35:52.000000000","message":"It would be worth explaining the version detection. If you check `kolla/template/repos.yaml` the repos all use 3.x, but I guess it is required because you need an exact match as per\nhttps://github.com/opensearch-project/opensearch-prometheus-exporter/blob/main/COMPATIBILITY.md ?\n\n\nI was also wondering if you can install the plugin \u0027by name\u0027, rather than the zip file, and whether that handles the version detection transparently? If that works, you could also skip defining the plugin in sources.yml","commit_id":"3aea7e1940297fcaa029238654ccdeb2e5124ec2"}]}