)]}'
{"kuryr_kubernetes/controller/drivers/public_ip.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"cb1c34c4568a73fcf96f84a2ad9abbf41a557038","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if port_id_to_be_associated is not None:"},{"line_number":113,"context_line":"            floating_ips_list \u003d neutron.list_floatingips("},{"line_number":114,"context_line":"                port_id\u003dport_id_to_be_associated)"},{"line_number":115,"context_line":"            for entry in floating_ips_list[\u0027floatingips\u0027]:"},{"line_number":116,"context_line":"                if not entry:"},{"line_number":117,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_04cf6655","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":49},"updated":"2018-12-05 09:50:34.000000000","message":"Just asking as I\u0027m not sure how this works. The port_id passed here is the VIP port ID, not the Floating IP port ID. If this filter working this way? Will it return the list of floating ips associated to the VIP port?","commit_id":"8d6c86db52ca7598b5addc7250394aaea1f7a5ef"},{"author":{"_account_id":21041,"name":"Yossi Boaron","email":"yossi.boaron.dev@gmail.com","username":"yboaron"},"change_message_id":"9be4eacecf4f949bd376681900364513a36e8e24","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if port_id_to_be_associated is not None:"},{"line_number":113,"context_line":"            floating_ips_list \u003d neutron.list_floatingips("},{"line_number":114,"context_line":"                port_id\u003dport_id_to_be_associated)"},{"line_number":115,"context_line":"            for entry in floating_ips_list[\u0027floatingips\u0027]:"},{"line_number":116,"context_line":"                if not entry:"},{"line_number":117,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a750f409","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":49},"in_reply_to":"3f79a3b5_04cf6655","updated":"2018-12-05 10:14:15.000000000","message":"TBH, I didn\u0027t check it in my local environment.\nBut this is how it described at Neutron floating IP list documentation [1] :\n\n\"\nport_id (Optional) Filter the floating IP list result by the ID of a port associated with the floating IP.\n\"\nSeems to me that it\u0027s fine, and with the temporary delay we could easily verify that it\u0027s working as expected.\n\n\n[1] https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003dlist-floating-ips-detail#floating-ips-floatingips","commit_id":"8d6c86db52ca7598b5addc7250394aaea1f7a5ef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"53e146117cb9fd3f838d96bdc1e0d936ae40dc97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if port_id_to_be_associated is not None:"},{"line_number":113,"context_line":"            floating_ips_list \u003d neutron.list_floatingips("},{"line_number":114,"context_line":"                port_id\u003dport_id_to_be_associated)"},{"line_number":115,"context_line":"            for entry in floating_ips_list[\u0027floatingips\u0027]:"},{"line_number":116,"context_line":"                if not entry:"},{"line_number":117,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_87f4d88b","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":49},"in_reply_to":"3f79a3b5_a750f409","updated":"2018-12-05 10:39:10.000000000","message":"Great!","commit_id":"8d6c86db52ca7598b5addc7250394aaea1f7a5ef"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"73249810fba1e9d21f87bd0c6e1394e7b3ebb9a3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    description\u003dNone, port_id_to_be_associated\u003dNone):"},{"line_number":110,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if port_id_to_be_associated is not None:"},{"line_number":113,"context_line":"            floating_ips_list \u003d neutron.list_floatingips("},{"line_number":114,"context_line":"                port_id\u003dport_id_to_be_associated)"},{"line_number":115,"context_line":"            for entry in floating_ips_list[\u0027floatingips\u0027]:"},{"line_number":116,"context_line":"                if not entry:"},{"line_number":117,"context_line":"                    continue"},{"line_number":118,"context_line":"                if (entry[\u0027floating_ip_address\u0027]):"},{"line_number":119,"context_line":"                    LOG.debug(\u0027FIP %s already allocated to port %s\u0027,"},{"line_number":120,"context_line":"                              entry[\u0027floating_ip_address\u0027],"},{"line_number":121,"context_line":"                              port_id_to_be_associated)"},{"line_number":122,"context_line":"                    return entry[\u0027id\u0027], entry[\u0027floating_ip_address\u0027]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        request \u003d {\u0027floatingip\u0027: {"},{"line_number":125,"context_line":"            \u0027tenant_id\u0027: project_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_60eff4b1","line":122,"range":{"start_line":112,"start_character":0,"end_line":122,"end_character":68},"updated":"2018-12-07 11:07:10.000000000","message":"This is awesome.","commit_id":"300dc36b062aaa2c5eb1c3ee2f8c041e1e33a99d"}]}