)]}'
{"doc/source/installation/sriov.rst":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"c9f05c98308b88050ac02f16dcb40c7ef0c542cd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"4. Specify resource names"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Resource name *intel.com/sriov* used in example above is default resource name."},{"line_number":81,"context_line":"This name was used in SR-IOV network device plugin in version 1 (release-v1 branch)."},{"line_number":82,"context_line":"But latest version of SR-IOV network device plugin can use arbitrary"},{"line_number":83,"context_line":"name of the resources [3]_. To be able to work with arbitrary resource names"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_755e8a77","line":80,"updated":"2019-04-01 08:09:49.000000000","message":"how about \u0027The resource name \u0027foo\u0027, which is used in the above example is the default resource name\u0027?","commit_id":"f179efce45732e6b24204c263d788d5256702182"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"c9f05c98308b88050ac02f16dcb40c7ef0c542cd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"4. Specify resource names"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Resource name *intel.com/sriov* used in example above is default resource name."},{"line_number":81,"context_line":"This name was used in SR-IOV network device plugin in version 1 (release-v1 branch)."},{"line_number":82,"context_line":"But latest version of SR-IOV network device plugin can use arbitrary"},{"line_number":83,"context_line":"name of the resources [3]_. To be able to work with arbitrary resource names"},{"line_number":84,"context_line":"physnet_resource_mappings and device_plugin_resource_prefix in [sriov] section"},{"line_number":85,"context_line":"of kuryr-controller configuration file should be filled. The default value for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_f5491ab7","line":82,"range":{"start_line":81,"start_character":83,"end_line":82,"end_character":68},"updated":"2019-04-01 08:09:49.000000000","message":"But since latest version the device plugin can use any arbitrary name.","commit_id":"f179efce45732e6b24204c263d788d5256702182"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"c9f05c98308b88050ac02f16dcb40c7ef0c542cd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Assume we have following SR-IOV network device plugin (defined by -config-file option)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. code-block:: json"},{"line_number":94,"context_line":"    {"},{"line_number":95,"context_line":"        \"resourceList\":"},{"line_number":96,"context_line":"            ["},{"line_number":97,"context_line":"               {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_75852acf","line":94,"updated":"2019-04-01 08:09:49.000000000","message":"You need to leave an empty line here.","commit_id":"f179efce45732e6b24204c263d788d5256702182"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"c9f05c98308b88050ac02f16dcb40c7ef0c542cd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"device plugin, we can see following state of kubernetes"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. code-block:: bash"},{"line_number":112,"context_line":"    $ kubectl get node node1 -o json | jq \u0027.status.allocatable\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    {"},{"line_number":115,"context_line":"      \"cpu\": \"4\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_156aa61a","line":112,"updated":"2019-04-01 08:09:49.000000000","message":"same here","commit_id":"f179efce45732e6b24204c263d788d5256702182"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"c9f05c98308b88050ac02f16dcb40c7ef0c542cd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"We have to add to the sriov section following mapping:"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. code-block:: ini"},{"line_number":127,"context_line":"  [sriov]"},{"line_number":128,"context_line":"  device_plugin_resource_prefix \u003d samsung.com"},{"line_number":129,"context_line":"  physnet_resource_mappings \u003d physnet1:numa0"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_3567a254","line":127,"updated":"2019-04-01 08:09:49.000000000","message":"same here","commit_id":"f179efce45732e6b24204c263d788d5256702182"}],"kuryr_kubernetes/config.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1462d6c0136ccc6cf7582cea6f03f670212e34d9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                       \"physical network device interfaces of SR-IOV physical \""},{"line_number":263,"context_line":"                       \"function to be used for VLAN networks.\")),"},{"line_number":264,"context_line":"    cfg.DictOpt(\u0027physnet_resource_mappings\u0027,"},{"line_number":265,"context_line":"                help\u003d_(\"A mapping of physnets for certain sriov dp\""},{"line_number":266,"context_line":"                       \"resource name in a form of physnet-name:resource name.\""},{"line_number":267,"context_line":"                       \"Resource name is listed in sriov device plugin \""},{"line_number":268,"context_line":"                       \"configuation file\"),"},{"line_number":269,"context_line":"                default\u003dDEFAULT_PHYSNET_SUBNET_MAPPINGS),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027device_plugin_resource_prefix\u0027,"},{"line_number":271,"context_line":"               help\u003d_(\"This prefix is used by sriov-network-device-plugin\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_bb486a5c","line":268,"range":{"start_line":265,"start_character":23,"end_line":268,"end_character":43},"updated":"2019-03-19 14:36:50.000000000","message":"You\u0027re missing spaces at the end or beginning of the lines.","commit_id":"fee6d2ddb20daf6ac46fb7ed693b51587d00a587"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1462d6c0136ccc6cf7582cea6f03f670212e34d9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                       \"configuation file\"),"},{"line_number":269,"context_line":"                default\u003dDEFAULT_PHYSNET_SUBNET_MAPPINGS),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027device_plugin_resource_prefix\u0027,"},{"line_number":271,"context_line":"               help\u003d_(\"This prefix is used by sriov-network-device-plugin\""},{"line_number":272,"context_line":"                      \"It concatenates with resource suffix defined in\""},{"line_number":273,"context_line":"                      \"sriov device plugin configuration file\"),"},{"line_number":274,"context_line":"               default\u003dconstants.K8S_SRIOV_PREFIX),"},{"line_number":275,"context_line":"]"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_db453645","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":64},"updated":"2019-03-19 14:36:50.000000000","message":"Same here.","commit_id":"fee6d2ddb20daf6ac46fb7ed693b51587d00a587"}],"kuryr_kubernetes/constants.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1462d6c0136ccc6cf7582cea6f03f670212e34d9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"DEFAULT_IFNAME \u003d \u0027eth0\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"ADDITIONAL_IFNAME_PREFIX \u003d \u0027eth\u0027"},{"line_number":75,"context_line":"K8S_SRIOV_PREFIX \u003d \u0027intel.com/\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"K8S_OPERATOR_IN \u003d \u0027in\u0027"},{"line_number":78,"context_line":"K8S_OPERATOR_NOT_IN \u003d \u0027notin\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5ba866da","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":31},"updated":"2019-03-19 14:36:50.000000000","message":"Does this change render older annotations useless? What\u0027s the upgrade scenario here?","commit_id":"fee6d2ddb20daf6ac46fb7ed693b51587d00a587"},{"author":{"_account_id":28396,"name":"Alexey Perevalov","email":"alexey.perevalov@huawei.com","username":"a.perevalov"},"change_message_id":"539533ae17839d8a8286e6c6ac69eab60226cf69","unresolved":false,"context_lines":[{"line_number":72,"context_line":"DEFAULT_IFNAME \u003d \u0027eth0\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"ADDITIONAL_IFNAME_PREFIX \u003d \u0027eth\u0027"},{"line_number":75,"context_line":"K8S_SRIOV_PREFIX \u003d \u0027intel.com/\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"K8S_OPERATOR_IN \u003d \u0027in\u0027"},{"line_number":78,"context_line":"K8S_OPERATOR_NOT_IN \u003d \u0027notin\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_9bca4e18","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":31},"in_reply_to":"5fc1f717_5ba866da","updated":"2019-03-19 14:56:57.000000000","message":"this is default prefix, this constant used in early version of sriovdp, now it\u0027s cmd line parameter of the sriovdp. And also a default one, if cmd line parameter wasn\u0027t specified.\nSo I just splited K8S_NPWG_SRIOV_PREFIX. And repeated sriovdp behaviour here.\nI don\u0027t think any upgrade movement is necessary, due to suffix will be sriov by default, so new kuryr-kuberntes will be compatible with old sriovdp.\nBut if we use new sriovdp, with modified prefix and new resource names (new sriovdp supports many different resources in its config) old kuryr-kubernetes (w/o this patch ;) will not work (due to trivial mismatch)","commit_id":"fee6d2ddb20daf6ac46fb7ed693b51587d00a587"}]}