)]}'
{"kuryr_kubernetes/controller/handlers/vif.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fccf2cbdf5d3201823c6e1787f6fd6ed48756f2c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                                   security_groups)"},{"line_number":121,"context_line":"        else:"},{"line_number":122,"context_line":"            changed \u003d False"},{"line_number":123,"context_line":"            try:"},{"line_number":124,"context_line":"                for ifname, vif in state.vifs.items():"},{"line_number":125,"context_line":"                    if vif.plugin \u003d\u003d constants.KURYR_VIF_TYPE_SRIOV:"},{"line_number":126,"context_line":"                        driver_utils.update_port_pci_info(pod, vif)"},{"line_number":127,"context_line":"                    if not vif.active:"},{"line_number":128,"context_line":"                        self._drv_vif_pool.activate_vif(pod, vif)"},{"line_number":129,"context_line":"                        changed \u003d True"},{"line_number":130,"context_line":"            finally:"},{"line_number":131,"context_line":"                if changed:"},{"line_number":132,"context_line":"                    self._set_pod_state(pod, state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_0adbd07b","line":129,"range":{"start_line":123,"start_character":0,"end_line":129,"end_character":38},"updated":"2019-05-28 12:40:17.000000000","message":"Shouldn\u0027t we at least log the exception here?","commit_id":"06e21b26596875983476361c80e2f0fbd94614a3"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"6cfd4a85477fb3a42cd39d7f9159aba881d84ef1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                                   security_groups)"},{"line_number":121,"context_line":"        else:"},{"line_number":122,"context_line":"            changed \u003d False"},{"line_number":123,"context_line":"            try:"},{"line_number":124,"context_line":"                for ifname, vif in state.vifs.items():"},{"line_number":125,"context_line":"                    if vif.plugin \u003d\u003d constants.KURYR_VIF_TYPE_SRIOV:"},{"line_number":126,"context_line":"                        driver_utils.update_port_pci_info(pod, vif)"},{"line_number":127,"context_line":"                    if not vif.active:"},{"line_number":128,"context_line":"                        self._drv_vif_pool.activate_vif(pod, vif)"},{"line_number":129,"context_line":"                        changed \u003d True"},{"line_number":130,"context_line":"            finally:"},{"line_number":131,"context_line":"                if changed:"},{"line_number":132,"context_line":"                    self._set_pod_state(pod, state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_053f41b4","line":129,"range":{"start_line":123,"start_character":0,"end_line":129,"end_character":38},"in_reply_to":"bfb3d3c7_0adbd07b","updated":"2019-05-28 13:28:30.000000000","message":"I think it is not necessary, just because exception \"ResourceNotReady\" will be caught by retry module. Other exceptions are not interesting for us , I think","commit_id":"06e21b26596875983476361c80e2f0fbd94614a3"},{"author":{"_account_id":30247,"name":"Ilya Maximets","email":"i.maximets@ovn.org","username":"i.maximets"},"change_message_id":"d7fa745ddcc65845633596c93addb20b386d3ab2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    if not vif.active:"},{"line_number":128,"context_line":"                        self._drv_vif_pool.activate_vif(pod, vif)"},{"line_number":129,"context_line":"                        changed \u003d True"},{"line_number":130,"context_line":"            except k_exc.ResourceNotReady as ex:"},{"line_number":131,"context_line":"                LOG.debug(\"Failed to activate vif: %s\", ex)"},{"line_number":132,"context_line":"            finally:"},{"line_number":133,"context_line":"                if changed:"},{"line_number":134,"context_line":"                    self._set_pod_state(pod, state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_cabff8a7","line":131,"range":{"start_line":130,"start_character":12,"end_line":131,"end_character":59},"updated":"2019-05-28 13:02:19.000000000","message":"You must rise it up. Otherwise, retry mechanism will be broken.","commit_id":"d27d20e4a60302199418fd99746d21ca72fa0093"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1849205e8d70ef81f8edbe5c02b40c479da38962","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            finally:"},{"line_number":131,"context_line":"                if changed:"},{"line_number":132,"context_line":"                    self._set_pod_state(pod, state)"},{"line_number":133,"context_line":"                    crd_pod_selectors \u003d self._drv_sg.create_sg_rules(pod)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"                    if self._is_network_policy_enabled():"},{"line_number":136,"context_line":"                        services \u003d driver_utils.get_services("}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_bc52003a","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":73},"updated":"2019-05-29 07:23:26.000000000","message":"as you are modifying this, perhaps worth to move this inside the if at line 135","commit_id":"fe22fbb79a45836a01cadd7b4c7051f8033564bc"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"48046dc1b4713dd50ab42916490641e1e9b3a184","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            finally:"},{"line_number":131,"context_line":"                if changed:"},{"line_number":132,"context_line":"                    self._set_pod_state(pod, state)"},{"line_number":133,"context_line":"                    crd_pod_selectors \u003d self._drv_sg.create_sg_rules(pod)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"                    if self._is_network_policy_enabled():"},{"line_number":136,"context_line":"                        services \u003d driver_utils.get_services("}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_b7ef791c","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":73},"in_reply_to":"bfb3d3c7_bc52003a","updated":"2019-05-29 07:43:15.000000000","message":"I agree. Done","commit_id":"fe22fbb79a45836a01cadd7b4c7051f8033564bc"}]}