)]}'
{"kuryr_kubernetes/controller/handlers/lbaas.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b749b8c4ac3f10d275ddeda0bbdf91848cf0d9b6","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def _add_new_listeners(self, endpoints, lbaas_spec, lbaas_state):"},{"line_number":510,"context_line":"        changed \u003d False"},{"line_number":511,"context_line":"        for port_spec in lbaas_spec.ports:"},{"line_number":512,"context_line":"            protocol \u003d port_spec.protocol"},{"line_number":513,"context_line":"            port \u003d port_spec.port"},{"line_number":514,"context_line":"            # NOTE (maysams): Due to a bug in Octavia, which does"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_87d652f1","line":511,"range":{"start_line":511,"start_character":8,"end_line":511,"end_character":42},"updated":"2019-07-24 14:35:11.000000000","message":"How about:\n\n for port_spec in sorted(lbaas_spec.ports, key\u003dlamdba x: x.protocol): \n\n?\n\nThat way we always get predictable results.","commit_id":"502182e6dacf88b478b8c1ad8c962d7a7fbee0b6"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"ec39e5cd88e58409e47c23fa0be15e8061e92521","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def _add_new_listeners(self, endpoints, lbaas_spec, lbaas_state):"},{"line_number":510,"context_line":"        changed \u003d False"},{"line_number":511,"context_line":"        for port_spec in lbaas_spec.ports:"},{"line_number":512,"context_line":"            protocol \u003d port_spec.protocol"},{"line_number":513,"context_line":"            port \u003d port_spec.port"},{"line_number":514,"context_line":"            # NOTE (maysams): Due to a bug in Octavia, which does"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e73946f2","line":511,"range":{"start_line":511,"start_character":8,"end_line":511,"end_character":42},"in_reply_to":"7faddb67_87d652f1","updated":"2019-07-24 14:56:27.000000000","message":"Good point!","commit_id":"502182e6dacf88b478b8c1ad8c962d7a7fbee0b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b749b8c4ac3f10d275ddeda0bbdf91848cf0d9b6","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        for port_spec in lbaas_spec.ports:"},{"line_number":512,"context_line":"            protocol \u003d port_spec.protocol"},{"line_number":513,"context_line":"            port \u003d port_spec.port"},{"line_number":514,"context_line":"            # NOTE (maysams): Due to a bug in Octavia, which does"},{"line_number":515,"context_line":"            # not allows listeners with same port but different"},{"line_number":516,"context_line":"            # protocols to co-exist, we need to skip the creation of"},{"line_number":517,"context_line":"            # listeners that have the same port as an existing one."}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c79e8a53","line":514,"range":{"start_line":514,"start_character":14,"end_line":514,"end_character":18},"updated":"2019-07-24 14:35:11.000000000","message":"Let\u0027s put FIXME here - Octavia will fix that eventually and we\u0027ll need to revisit this.","commit_id":"502182e6dacf88b478b8c1ad8c962d7a7fbee0b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b749b8c4ac3f10d275ddeda0bbdf91848cf0d9b6","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            # not allows listeners with same port but different"},{"line_number":516,"context_line":"            # protocols to co-exist, we need to skip the creation of"},{"line_number":517,"context_line":"            # listeners that have the same port as an existing one."},{"line_number":518,"context_line":"            if any(listener.port \u003d\u003d port"},{"line_number":519,"context_line":"                   for listener in lbaas_state.listeners):"},{"line_number":520,"context_line":"                continue"},{"line_number":521,"context_line":"            listener \u003d self._drv_lbaas.ensure_listener("},{"line_number":522,"context_line":"                loadbalancer\u003dlbaas_state.loadbalancer,"},{"line_number":523,"context_line":"                protocol\u003dprotocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e797063a","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":24},"updated":"2019-07-24 14:35:11.000000000","message":"Would be good to log a warning here - otherwise it\u0027s quite confusing for the user that Kuryr is not reacting to his Services as it should.","commit_id":"502182e6dacf88b478b8c1ad8c962d7a7fbee0b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687442ae7d0d53f762471c08e0aedd742205324","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            # protocols to co-exist, we need to skip the creation of"},{"line_number":518,"context_line":"            # listeners that have the same port as an existing one."},{"line_number":519,"context_line":"            name \u003d \"%s:%s\" % (lbaas_state.loadbalancer.name, protocol)"},{"line_number":520,"context_line":"            if any(listener.port \u003d\u003d port"},{"line_number":521,"context_line":"                   for listener in lbaas_state.listeners):"},{"line_number":522,"context_line":"                LOG.warning(\"Skipping listener creation for %s \""},{"line_number":523,"context_line":"                            \"as another one already exists with port %r\","},{"line_number":524,"context_line":"                            name, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3611b205","line":521,"range":{"start_line":520,"start_character":0,"end_line":521,"end_character":58},"updated":"2019-07-26 10:50:51.000000000","message":"This should be:\n\n            if any(listener.port \u003d\u003d port and listener.protocol !\u003d protocol\n                   for listener in lbaas_state.listeners):\n\nOtherwise it\u0027ll produce a warning for listeners that are already created.","commit_id":"16aab1d2f043eb08581b4af917e56d4b94a8c51b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6383ba61aa2cd846f712081c49a6b3ac80469ff0","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            # protocols to co-exist, we need to skip the creation of"},{"line_number":518,"context_line":"            # listeners that have the same port as an existing one."},{"line_number":519,"context_line":"            name \u003d \"%s:%s\" % (lbaas_state.loadbalancer.name, protocol)"},{"line_number":520,"context_line":"            if any(listener.port \u003d\u003d port"},{"line_number":521,"context_line":"                   for listener in lbaas_state.listeners):"},{"line_number":522,"context_line":"                LOG.warning(\"Skipping listener creation for %s \""},{"line_number":523,"context_line":"                            \"as another one already exists with port %r\","},{"line_number":524,"context_line":"                            name, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_16983668","line":521,"range":{"start_line":520,"start_character":0,"end_line":521,"end_character":58},"in_reply_to":"7faddb67_3611b205","updated":"2019-07-26 11:06:37.000000000","message":"Or even:\n\n            if any(listener.port \u003d\u003d port\n                   for listener in lbaas_state.listeners):\n                if listener.protocol !\u003d protocol\n                    LOG.warning(\"Skipping listener creation for %s \"\n                                \"as another one already exists with port %r\",\n                                name, port)\n                continue","commit_id":"16aab1d2f043eb08581b4af917e56d4b94a8c51b"}]}