)]}'
{"kuryr_kubernetes/controller/drivers/namespace_subnet.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97bdad6bc96a450ece141a76b06a57e07a118733","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                }).get(\u0027network\u0027)"},{"line_number":144,"context_line":"            c_utils.tag_neutron_resources(\u0027networks\u0027, [neutron_net[\u0027id\u0027]])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            # create a subnet within that network"},{"line_number":147,"context_line":"            try:"},{"line_number":148,"context_line":"                neutron_subnet \u003d neutron.create_subnet("},{"line_number":149,"context_line":"                    {"},{"line_number":150,"context_line":"                        \"subnet\": {"},{"line_number":151,"context_line":"                            \"network_id\": neutron_net[\u0027id\u0027],"},{"line_number":152,"context_line":"                            \"ip_version\": 4,"},{"line_number":153,"context_line":"                            \"name\": subnet_name,"},{"line_number":154,"context_line":"                            \"enable_dhcp\": False,"},{"line_number":155,"context_line":"                            \"subnetpool_id\": subnet_pool_id,"},{"line_number":156,"context_line":"                            \"project_id\": project_id"},{"line_number":157,"context_line":"                        }"},{"line_number":158,"context_line":"                    }).get(\u0027subnet\u0027)"},{"line_number":159,"context_line":"            except n_exc.Conflict:"},{"line_number":160,"context_line":"                LOG.debug(\"Max number of retries on neutron side achieved, \""},{"line_number":161,"context_line":"                          \"raising ResourceNotReady to retry subnet creation \""},{"line_number":162,"context_line":"                          \"for %s\", subnet_name)"},{"line_number":163,"context_line":"                raise exceptions.ResourceNotReady(subnet_name)"},{"line_number":164,"context_line":"            c_utils.tag_neutron_resources(\u0027subnets\u0027, [neutron_subnet[\u0027id\u0027]])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"            # connect the subnet to the router"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d85564fa","line":163,"range":{"start_line":146,"start_character":0,"end_line":163,"end_character":62},"updated":"2019-09-05 08:57:47.000000000","message":"If you want to do retry through ResourceNotReady you need to delete that network created above, otherwise we\u0027re getting leftovers, right?","commit_id":"d6e5fe9f8305fc813b9d9799a183fb48f5881c5e"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ce81a229b46ebfce623120c46752b3cf825dee11","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                }).get(\u0027network\u0027)"},{"line_number":144,"context_line":"            c_utils.tag_neutron_resources(\u0027networks\u0027, [neutron_net[\u0027id\u0027]])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            # create a subnet within that network"},{"line_number":147,"context_line":"            try:"},{"line_number":148,"context_line":"                neutron_subnet \u003d neutron.create_subnet("},{"line_number":149,"context_line":"                    {"},{"line_number":150,"context_line":"                        \"subnet\": {"},{"line_number":151,"context_line":"                            \"network_id\": neutron_net[\u0027id\u0027],"},{"line_number":152,"context_line":"                            \"ip_version\": 4,"},{"line_number":153,"context_line":"                            \"name\": subnet_name,"},{"line_number":154,"context_line":"                            \"enable_dhcp\": False,"},{"line_number":155,"context_line":"                            \"subnetpool_id\": subnet_pool_id,"},{"line_number":156,"context_line":"                            \"project_id\": project_id"},{"line_number":157,"context_line":"                        }"},{"line_number":158,"context_line":"                    }).get(\u0027subnet\u0027)"},{"line_number":159,"context_line":"            except n_exc.Conflict:"},{"line_number":160,"context_line":"                LOG.debug(\"Max number of retries on neutron side achieved, \""},{"line_number":161,"context_line":"                          \"raising ResourceNotReady to retry subnet creation \""},{"line_number":162,"context_line":"                          \"for %s\", subnet_name)"},{"line_number":163,"context_line":"                raise exceptions.ResourceNotReady(subnet_name)"},{"line_number":164,"context_line":"            c_utils.tag_neutron_resources(\u0027subnets\u0027, [neutron_subnet[\u0027id\u0027]])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"            # connect the subnet to the router"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a2071217","line":163,"range":{"start_line":146,"start_character":0,"end_line":163,"end_character":62},"in_reply_to":"7faddb67_780d503c","updated":"2019-09-05 09:52:21.000000000","message":"that said, perhaps worth to call it here too","commit_id":"d6e5fe9f8305fc813b9d9799a183fb48f5881c5e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c99c3225bb97a0d783a37adf1bf4579c511388c4","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                }).get(\u0027network\u0027)"},{"line_number":144,"context_line":"            c_utils.tag_neutron_resources(\u0027networks\u0027, [neutron_net[\u0027id\u0027]])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            # create a subnet within that network"},{"line_number":147,"context_line":"            try:"},{"line_number":148,"context_line":"                neutron_subnet \u003d neutron.create_subnet("},{"line_number":149,"context_line":"                    {"},{"line_number":150,"context_line":"                        \"subnet\": {"},{"line_number":151,"context_line":"                            \"network_id\": neutron_net[\u0027id\u0027],"},{"line_number":152,"context_line":"                            \"ip_version\": 4,"},{"line_number":153,"context_line":"                            \"name\": subnet_name,"},{"line_number":154,"context_line":"                            \"enable_dhcp\": False,"},{"line_number":155,"context_line":"                            \"subnetpool_id\": subnet_pool_id,"},{"line_number":156,"context_line":"                            \"project_id\": project_id"},{"line_number":157,"context_line":"                        }"},{"line_number":158,"context_line":"                    }).get(\u0027subnet\u0027)"},{"line_number":159,"context_line":"            except n_exc.Conflict:"},{"line_number":160,"context_line":"                LOG.debug(\"Max number of retries on neutron side achieved, \""},{"line_number":161,"context_line":"                          \"raising ResourceNotReady to retry subnet creation \""},{"line_number":162,"context_line":"                          \"for %s\", subnet_name)"},{"line_number":163,"context_line":"                raise exceptions.ResourceNotReady(subnet_name)"},{"line_number":164,"context_line":"            c_utils.tag_neutron_resources(\u0027subnets\u0027, [neutron_subnet[\u0027id\u0027]])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"            # connect the subnet to the router"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_42c5fe8c","line":163,"range":{"start_line":146,"start_character":0,"end_line":163,"end_character":62},"in_reply_to":"7faddb67_a2071217","updated":"2019-09-05 10:05:03.000000000","message":"Okay, I see that method will be called when this event is retried, cool.","commit_id":"d6e5fe9f8305fc813b9d9799a183fb48f5881c5e"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b66d1d7aa050a355af04abe4d5da4af259428607","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                }).get(\u0027network\u0027)"},{"line_number":144,"context_line":"            c_utils.tag_neutron_resources(\u0027networks\u0027, [neutron_net[\u0027id\u0027]])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            # create a subnet within that network"},{"line_number":147,"context_line":"            try:"},{"line_number":148,"context_line":"                neutron_subnet \u003d neutron.create_subnet("},{"line_number":149,"context_line":"                    {"},{"line_number":150,"context_line":"                        \"subnet\": {"},{"line_number":151,"context_line":"                            \"network_id\": neutron_net[\u0027id\u0027],"},{"line_number":152,"context_line":"                            \"ip_version\": 4,"},{"line_number":153,"context_line":"                            \"name\": subnet_name,"},{"line_number":154,"context_line":"                            \"enable_dhcp\": False,"},{"line_number":155,"context_line":"                            \"subnetpool_id\": subnet_pool_id,"},{"line_number":156,"context_line":"                            \"project_id\": project_id"},{"line_number":157,"context_line":"                        }"},{"line_number":158,"context_line":"                    }).get(\u0027subnet\u0027)"},{"line_number":159,"context_line":"            except n_exc.Conflict:"},{"line_number":160,"context_line":"                LOG.debug(\"Max number of retries on neutron side achieved, \""},{"line_number":161,"context_line":"                          \"raising ResourceNotReady to retry subnet creation \""},{"line_number":162,"context_line":"                          \"for %s\", subnet_name)"},{"line_number":163,"context_line":"                raise exceptions.ResourceNotReady(subnet_name)"},{"line_number":164,"context_line":"            c_utils.tag_neutron_resources(\u0027subnets\u0027, [neutron_subnet[\u0027id\u0027]])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"            # connect the subnet to the router"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_780d503c","line":163,"range":{"start_line":146,"start_character":0,"end_line":163,"end_character":62},"in_reply_to":"7faddb67_d85564fa","updated":"2019-09-05 09:50:53.000000000","message":"there is a cleanup (cleanup_namespace_networks) on the handler that will ensure no leftovers are there if there is a need for creating the network. The method used is here at line 191","commit_id":"d6e5fe9f8305fc813b9d9799a183fb48f5881c5e"}]}