)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-09-25 14:10:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]"},{"line_number":8,"context_line":"Author: Sarka Scavnicka"},{"line_number":9,"context_line":"Date: Wed Sep 25 15:58 2019"},{"line_number":10,"context_line":"Implements for blueprint Move SVC annotations to CRDs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tMake a new YAML file in kubernetes_crds folder. This file is a CRD for loadbalancer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_bfbf64a8","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":27},"updated":"2019-09-25 14:31:54.000000000","message":"No need to add those, that data is part of the commit itself. Please take a quick glance at OpenStack\u0027s guidelines regarding commit messages [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-09-25 14:10:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]"},{"line_number":8,"context_line":"Author: Sarka Scavnicka"},{"line_number":9,"context_line":"Date: Wed Sep 25 15:58 2019"},{"line_number":10,"context_line":"Implements for blueprint Move SVC annotations to CRDs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tMake a new YAML file in kubernetes_crds folder. This file is a CRD for loadbalancer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_e0b52933","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":27},"in_reply_to":"3fa7e38b_bfbf64a8","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Date: Wed Sep 25 15:58 2019"},{"line_number":10,"context_line":"Implements for blueprint Move SVC annotations to CRDs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tMake a new YAML file in kubernetes_crds folder. This file is a CRD for loadbalancer."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4088ad09efe96b2d395fb892750adcb39abee3a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_5fde7011","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2019-09-25 14:31:54.000000000","message":"This indentation is unnecessary as well.","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Date: Wed Sep 25 15:58 2019"},{"line_number":10,"context_line":"Implements for blueprint Move SVC annotations to CRDs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tMake a new YAML file in kubernetes_crds folder. This file is a CRD for loadbalancer."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4088ad09efe96b2d395fb892750adcb39abee3a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_00b3a54e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"3fa7e38b_5fde7011","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6e0be3d7ee36d62dd526c29666008b07f18e471e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sarka_scavnicka \u003cscavnicka.sarka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-01 12:13:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add a loadbalancer CRD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds repair CRD to Kuryr that contains informations about"},{"line_number":10,"context_line":"service\u0027s annotations and endpoints\u0027 annotations, also there are some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_4a77370a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"updated":"2019-10-01 12:06:30.000000000","message":"Looks like this is not a work in progress anymore, so I think we can remove the WIP label.","commit_id":"acedadd6575ba06fe18d0242e206e6b1abd3d2a7"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"0f02cefa97b7c493ecddaaa41400cbf116b40429","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sarka_scavnicka \u003cscavnicka.sarka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-01 12:13:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add a loadbalancer CRD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds repair CRD to Kuryr that contains informations about"},{"line_number":10,"context_line":"service\u0027s annotations and endpoints\u0027 annotations, also there are some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_8dd8e91e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"in_reply_to":"3fa7e38b_4a77370a","updated":"2019-10-01 12:49:20.000000000","message":"Done","commit_id":"acedadd6575ba06fe18d0242e206e6b1abd3d2a7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6e0be3d7ee36d62dd526c29666008b07f18e471e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add a loadbalancer CRD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds repair CRD to Kuryr that contains informations about"},{"line_number":10,"context_line":"service\u0027s annotations and endpoints\u0027 annotations, also there are some"},{"line_number":11,"context_line":"changes in several files to ensure that CRD is created on the cluster"},{"line_number":12,"context_line":"when using devstack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_0a813fc4","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":23},"updated":"2019-10-01 12:06:30.000000000","message":"repair?","commit_id":"acedadd6575ba06fe18d0242e206e6b1abd3d2a7"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"0f02cefa97b7c493ecddaaa41400cbf116b40429","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add a loadbalancer CRD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds repair CRD to Kuryr that contains informations about"},{"line_number":10,"context_line":"service\u0027s annotations and endpoints\u0027 annotations, also there are some"},{"line_number":11,"context_line":"changes in several files to ensure that CRD is created on the cluster"},{"line_number":12,"context_line":"when using devstack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_add5a5e7","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":23},"in_reply_to":"3fa7e38b_0a813fc4","updated":"2019-10-01 12:49:20.000000000","message":"Done","commit_id":"acedadd6575ba06fe18d0242e206e6b1abd3d2a7"}],"kubernetes_crds/kuryrloadbalancer.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    singular: kuryrloadbalancer"},{"line_number":12,"context_line":"    kind: KuryrLoadBalancer"},{"line_number":13,"context_line":"    shortNames:"},{"line_number":14,"context_line":"      - klb"},{"line_number":15,"context_line":"  additionalPrinterColumns:"},{"line_number":16,"context_line":"    - name: PROJECT-ID"},{"line_number":17,"context_line":"      type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5f7af0f0","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":11},"updated":"2019-09-25 14:31:54.000000000","message":"I wonder when we\u0027ll start having conflicting shortNames with other CRD\u0027s. Anyway let\u0027s leave it like that as it\u0027ll make development easier, but when moving that to other Kuryr installers (like OpenShift\u0027s cluster-network-operator) it might make sense to remove it.","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    singular: kuryrloadbalancer"},{"line_number":12,"context_line":"    kind: KuryrLoadBalancer"},{"line_number":13,"context_line":"    shortNames:"},{"line_number":14,"context_line":"      - klb"},{"line_number":15,"context_line":"  additionalPrinterColumns:"},{"line_number":16,"context_line":"    - name: PROJECT-ID"},{"line_number":17,"context_line":"      type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_75b304ea","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":11},"in_reply_to":"3fa7e38b_5f7af0f0","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      type: string"},{"line_number":18,"context_line":"      description: The ID of the PROJECT associated to the loadbalancer"},{"line_number":19,"context_line":"      JSONPath: .spec.project_id"},{"line_number":20,"context_line":"    - name: Age"},{"line_number":21,"context_line":"      type: date"},{"line_number":22,"context_line":"      JSONPath: .metadata.creationTimestamp"},{"line_number":23,"context_line":"  validation:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7f680c1c","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":15},"updated":"2019-09-25 14:31:54.000000000","message":"I guess this should be `AGE` to be consistent with how kubectl shows those columns.","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      type: string"},{"line_number":18,"context_line":"      description: The ID of the PROJECT associated to the loadbalancer"},{"line_number":19,"context_line":"      JSONPath: .spec.project_id"},{"line_number":20,"context_line":"    - name: Age"},{"line_number":21,"context_line":"      type: date"},{"line_number":22,"context_line":"      JSONPath: .metadata.creationTimestamp"},{"line_number":23,"context_line":"  validation:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1bd20129","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":15},"in_reply_to":"3fa7e38b_7f680c1c","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            ip:"},{"line_number":38,"context_line":"              type: string"},{"line_number":39,"context_line":"            lb_ip:"},{"line_number":40,"context_line":"              type: null"},{"line_number":41,"context_line":"            ports:"},{"line_number":42,"context_line":"              type: array"},{"line_number":43,"context_line":"              items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3fd374d7","line":40,"range":{"start_line":40,"start_character":20,"end_line":40,"end_character":24},"updated":"2019-09-25 14:31:54.000000000","message":"This should be string, doesn\u0027t it?","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            ip:"},{"line_number":38,"context_line":"              type: string"},{"line_number":39,"context_line":"            lb_ip:"},{"line_number":40,"context_line":"              type: null"},{"line_number":41,"context_line":"            ports:"},{"line_number":42,"context_line":"              type: array"},{"line_number":43,"context_line":"              items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_95080092","line":40,"range":{"start_line":40,"start_character":20,"end_line":40,"end_character":24},"in_reply_to":"3fa7e38b_3fd374d7","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                  protocol:"},{"line_number":56,"context_line":"                    type: string"},{"line_number":57,"context_line":"                  targetPort:"},{"line_number":58,"context_line":"                    type: integer"},{"line_number":59,"context_line":"            project_id:"},{"line_number":60,"context_line":"              type: string"},{"line_number":61,"context_line":"            security_groups_ids:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7ff6cc65","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":33},"updated":"2019-09-25 14:31:54.000000000","message":"This is string in our current implementation [1].\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/dfa9a392f1d3b777a68adda9f5e06d36575bf5a1/kuryr_kubernetes/objects/lbaas.py#L131","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                  protocol:"},{"line_number":56,"context_line":"                    type: string"},{"line_number":57,"context_line":"                  targetPort:"},{"line_number":58,"context_line":"                    type: integer"},{"line_number":59,"context_line":"            project_id:"},{"line_number":60,"context_line":"              type: string"},{"line_number":61,"context_line":"            security_groups_ids:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_cc94b839","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":33},"in_reply_to":"3fa7e38b_7ff6cc65","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            project_id:"},{"line_number":60,"context_line":"              type: string"},{"line_number":61,"context_line":"            security_groups_ids:"},{"line_number":62,"context_line":"              type: array"},{"line_number":63,"context_line":"            subnet_id:"},{"line_number":64,"context_line":"              type: string"},{"line_number":65,"context_line":"            type:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3fa13447","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":25},"updated":"2019-09-25 14:31:54.000000000","message":"We could add \n\n  \"items\": {\n    \"type\": \"string\"\n  }\n\nas ID\u0027s are strings.","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            project_id:"},{"line_number":60,"context_line":"              type: string"},{"line_number":61,"context_line":"            security_groups_ids:"},{"line_number":62,"context_line":"              type: array"},{"line_number":63,"context_line":"            subnet_id:"},{"line_number":64,"context_line":"              type: string"},{"line_number":65,"context_line":"            type:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9886f765","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":25},"in_reply_to":"3fa7e38b_3fa13447","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                  type: string"},{"line_number":122,"context_line":"                provider:"},{"line_number":123,"context_line":"                  type: string"},{"line_number":124,"context_line":"                security_groups:"},{"line_number":125,"context_line":"                  type: array"},{"line_number":126,"context_line":"                subnet_id:"},{"line_number":127,"context_line":"                  type: string"},{"line_number":128,"context_line":"            members:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1fb5587e","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":29},"updated":"2019-09-25 14:31:54.000000000","message":"Same here, this will be array of strings.","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                  type: string"},{"line_number":122,"context_line":"                provider:"},{"line_number":123,"context_line":"                  type: string"},{"line_number":124,"context_line":"                security_groups:"},{"line_number":125,"context_line":"                  type: array"},{"line_number":126,"context_line":"                subnet_id:"},{"line_number":127,"context_line":"                  type: string"},{"line_number":128,"context_line":"            members:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_189a07b8","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":29},"in_reply_to":"3fa7e38b_1fb5587e","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcd2b46e9dccc174837b96a4304414766ca1a4ab","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                    type: string"},{"line_number":177,"context_line":"                  protocol:"},{"line_number":178,"context_line":"                    type: string"},{"line_number":179,"context_line":"            service_pub_ip_info:"},{"line_number":180,"context_line":"              type: null"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9f7dc8b3","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":24},"updated":"2019-09-25 14:31:54.000000000","message":"It\u0027s this object [1], so it\u0027ll be a `type: object`.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/dfa9a392f1d3b777a68adda9f5e06d36575bf5a1/kuryr_kubernetes/objects/lbaas.py#L91-L98","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                    type: string"},{"line_number":177,"context_line":"                  protocol:"},{"line_number":178,"context_line":"                    type: string"},{"line_number":179,"context_line":"            service_pub_ip_info:"},{"line_number":180,"context_line":"              type: null"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_356a6c19","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":24},"in_reply_to":"3fa7e38b_9f7dc8b3","updated":"2019-09-30 15:49:11.000000000","message":"Done","commit_id":"7118090903f1b420d63a9e628c2f58d13a82f0fd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"64780faa3d07d8077a35d2a92c5ca6254880acaf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        spec:"},{"line_number":27,"context_line":"          type: object"},{"line_number":28,"context_line":"          required:"},{"line_number":29,"context_line":"          - ip"},{"line_number":30,"context_line":"          - lb_ip"},{"line_number":31,"context_line":"          - ports"},{"line_number":32,"context_line":"          - project_id"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f4e3af32","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":14},"updated":"2019-09-26 09:01:28.000000000","message":"what IP is this? Not sure the tenant has access to it...","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"ba7aaf5c2bd5bdda7cd1860550e852de7b0be42d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        spec:"},{"line_number":27,"context_line":"          type: object"},{"line_number":28,"context_line":"          required:"},{"line_number":29,"context_line":"          - ip"},{"line_number":30,"context_line":"          - lb_ip"},{"line_number":31,"context_line":"          - ports"},{"line_number":32,"context_line":"          - project_id"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d5751833","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":14},"in_reply_to":"3fa7e38b_f4e3af32","updated":"2019-09-30 15:49:11.000000000","message":"From service annotations\nopenstack.org/kuryr-lbaas-spec: \n\u0027{\"versioned_object.data\": {\"ip\": \"10.0.0.149\",\n \"lb_ip\": null,\n  ...}}","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e9a190fd22fae42e481eef2fbed1d1a0b4812d4b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          type: object"},{"line_number":28,"context_line":"          required:"},{"line_number":29,"context_line":"          - ip"},{"line_number":30,"context_line":"          - lb_ip"},{"line_number":31,"context_line":"          - ports"},{"line_number":32,"context_line":"          - project_id"},{"line_number":33,"context_line":"          - security_groups_ids"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f84dab3a","line":30,"range":{"start_line":30,"start_character":12,"end_line":30,"end_character":17},"updated":"2019-09-30 15:03:57.000000000","message":"I believe this field shouldn\u0027t be marked as required, as it\u0027s only used when the SVC is of type LoadBalancer.","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9fd2daf51603050d0c63ce6009c9157ffc952505","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          type: object"},{"line_number":28,"context_line":"          required:"},{"line_number":29,"context_line":"          - ip"},{"line_number":30,"context_line":"          - lb_ip"},{"line_number":31,"context_line":"          - ports"},{"line_number":32,"context_line":"          - project_id"},{"line_number":33,"context_line":"          - security_groups_ids"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ca100753","line":30,"range":{"start_line":30,"start_character":12,"end_line":30,"end_character":17},"in_reply_to":"3fa7e38b_f84dab3a","updated":"2019-10-01 11:35:19.000000000","message":"Done","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6e79442eb907b9a573ea68e09f9035357202c2bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          - loadbalancer"},{"line_number":72,"context_line":"          - members"},{"line_number":73,"context_line":"          - pools"},{"line_number":74,"context_line":"          - service_pub_ip_info"},{"line_number":75,"context_line":"          properties:"},{"line_number":76,"context_line":"            listeners:"},{"line_number":77,"context_line":"              type: array"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e8d2b2ff","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":31},"updated":"2019-10-01 06:22:03.000000000","message":"This field shouldn\u0027t also be required, as it might happen that it\u0027s not always defined.","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9fd2daf51603050d0c63ce6009c9157ffc952505","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          - loadbalancer"},{"line_number":72,"context_line":"          - members"},{"line_number":73,"context_line":"          - pools"},{"line_number":74,"context_line":"          - service_pub_ip_info"},{"line_number":75,"context_line":"          properties:"},{"line_number":76,"context_line":"            listeners:"},{"line_number":77,"context_line":"              type: array"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6a02330c","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":31},"in_reply_to":"3fa7e38b_e8d2b2ff","updated":"2019-10-01 11:35:19.000000000","message":"Done","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6e79442eb907b9a573ea68e09f9035357202c2bb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                    type: string"},{"line_number":177,"context_line":"                  protocol:"},{"line_number":178,"context_line":"                    type: string"},{"line_number":179,"context_line":"            service_pub_ip_info:"},{"line_number":180,"context_line":"              type: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_48018669","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":24},"updated":"2019-10-01 06:22:03.000000000","message":"This field should be an object. Note that in Kuryr[1] this is currently defined as a LBaaSPubIp obj.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/objects/lbaas.py#L115-L117","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9fd2daf51603050d0c63ce6009c9157ffc952505","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                    type: string"},{"line_number":177,"context_line":"                  protocol:"},{"line_number":178,"context_line":"                    type: string"},{"line_number":179,"context_line":"            service_pub_ip_info:"},{"line_number":180,"context_line":"              type: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2a0c3b3a","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":24},"in_reply_to":"3fa7e38b_48018669","updated":"2019-10-01 11:35:19.000000000","message":"Done","commit_id":"10cbbefe4f6c8a90d6a7acd950003ee908ebe891"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"62f1476b75a53bfc9912b69471af362919b51082","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                name:"},{"line_number":117,"context_line":"                  type: string"},{"line_number":118,"context_line":"                port_id:"},{"line_number":119,"context_line":"                  type: integer"},{"line_number":120,"context_line":"                project_id:"},{"line_number":121,"context_line":"                  type: string"},{"line_number":122,"context_line":"                provider:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_ec7a83b8","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":31},"updated":"2019-10-04 16:14:23.000000000","message":"This should be a string, as described in the obj[1].\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/objects/lbaas.py#L37","commit_id":"2eaf0b95d30c1f72213fa8295e00dada6546329b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5c49057e604aebdc007662f115afa0d767945eec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                name:"},{"line_number":117,"context_line":"                  type: string"},{"line_number":118,"context_line":"                port_id:"},{"line_number":119,"context_line":"                  type: integer"},{"line_number":120,"context_line":"                project_id:"},{"line_number":121,"context_line":"                  type: string"},{"line_number":122,"context_line":"                provider:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_08378701","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":31},"in_reply_to":"3fa7e38b_ec7a83b8","updated":"2019-10-09 15:10:58.000000000","message":"Nice!","commit_id":"2eaf0b95d30c1f72213fa8295e00dada6546329b"}]}