)]}'
{"kuryr_kubernetes/controller/handlers/namespace.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d8fdff1f9c2df5a8676c9315dcb530695458a6d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if current_namespace_labels !\u003d previous_namespace_labels:"},{"line_number":72,"context_line":"            crd_selectors \u003d self._drv_sg.update_namespace_sg_rules(namespace)"},{"line_number":73,"context_line":"            self._set_namespace_labels(namespace, current_namespace_labels)"},{"line_number":74,"context_line":"            services \u003d driver_utils.get_services()"},{"line_number":75,"context_line":"            self._update_services(services, crd_selectors, project_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        net_crd_id \u003d self._get_net_crd_id(namespace)"},{"line_number":78,"context_line":"        if net_crd_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c84816b4","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":70},"updated":"2019-10-01 06:38:29.000000000","message":"As this handler can be enabled regardless of Network Policy support, we should include the following check:\n\"if (self._is_network_policy_enabled() and crd_selectors and\n     oslo_cfg.CONF.octavia_defaults.enforce_sg_rules):\"\nOtherwise we\u0027ll always try to update the LBaaS SG.","commit_id":"8cb90168b0ce26f7c5ee62ed3b7e154f18f7ab34"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f58bc3aab1925f5fddacf8fec9f4b7d1dd20dea6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if current_namespace_labels !\u003d previous_namespace_labels:"},{"line_number":72,"context_line":"            crd_selectors \u003d self._drv_sg.update_namespace_sg_rules(namespace)"},{"line_number":73,"context_line":"            self._set_namespace_labels(namespace, current_namespace_labels)"},{"line_number":74,"context_line":"            services \u003d driver_utils.get_services()"},{"line_number":75,"context_line":"            self._update_services(services, crd_selectors, project_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        net_crd_id \u003d self._get_net_crd_id(namespace)"},{"line_number":78,"context_line":"        if net_crd_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_838f5f28","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":70},"in_reply_to":"3fa7e38b_c84816b4","updated":"2019-10-01 07:48:57.000000000","message":"ohh! right!","commit_id":"8cb90168b0ce26f7c5ee62ed3b7e154f18f7ab34"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d8fdff1f9c2df5a8676c9315dcb530695458a6d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                self._drv_sg.delete_sg(net_crd_sg[\u0027sgId\u0027])"},{"line_number":124,"context_line":"            self._del_kuryrnet_crd(net_crd_name)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def on_deleted(self, namespace, net_crd\u003dNone):"},{"line_number":127,"context_line":"        LOG.debug(\"Deleting namespace: %s\", namespace)"},{"line_number":128,"context_line":"        if not net_crd:"},{"line_number":129,"context_line":"            net_crd_id \u003d self._get_net_crd_id(namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a846fabe","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":50},"updated":"2019-10-01 06:38:29.000000000","message":"We also need to ensure LBaaS SG is updated when the namespace is deleted.","commit_id":"8cb90168b0ce26f7c5ee62ed3b7e154f18f7ab34"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0678c10d04263bd4b9003c8ba62fa740dbbbea3d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    OBJECT_KIND \u003d constants.K8S_OBJ_NAMESPACE"},{"line_number":50,"context_line":"    OBJECT_WATCH_PATH \u003d constants.K8S_API_NAMESPACES"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self):"},{"line_number":53,"context_line":"        super(NamespaceHandler, self).__init__()"},{"line_number":54,"context_line":"        self._drv_project \u003d drivers.NamespaceProjectDriver.get_instance()"},{"line_number":55,"context_line":"        self._drv_subnets \u003d drivers.PodSubnetsDriver.get_instance()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_84b6863e","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":23},"updated":"2019-10-01 09:42:37.000000000","message":"You\u0027re missing the definition of the svc sg driver:\nself._drv_svc_sg \u003d drivers.ServiceSecurityGroupsDriver.get_instance()","commit_id":"9c9349c82468a26220da7aa63c3b7b77fdbec8ef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0aa6676ce40ccccb71b746e2feeef19db89fe762","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    OBJECT_KIND \u003d constants.K8S_OBJ_NAMESPACE"},{"line_number":50,"context_line":"    OBJECT_WATCH_PATH \u003d constants.K8S_API_NAMESPACES"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self):"},{"line_number":53,"context_line":"        super(NamespaceHandler, self).__init__()"},{"line_number":54,"context_line":"        self._drv_project \u003d drivers.NamespaceProjectDriver.get_instance()"},{"line_number":55,"context_line":"        self._drv_subnets \u003d drivers.PodSubnetsDriver.get_instance()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_58d14d2f","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_84b6863e","updated":"2019-10-01 13:28:41.000000000","message":"right!","commit_id":"9c9349c82468a26220da7aa63c3b7b77fdbec8ef"}]}