)]}'
{"kuryr_kubernetes/controller/drivers/network_policy_security_groups.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7e9b1718188fe0d07f1f71883ae573fb1bc7484c","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                # NOTE(maysams): We must ensure CRDs are not allowing ingress"},{"line_number":439,"context_line":"                # when should be blocked."},{"line_number":440,"context_line":"                if not rule_list:"},{"line_number":441,"context_line":"                    if len(policy_types) \u003d\u003d 1 and policy_types[0] \u003d\u003d \u0027Ingress\u0027:"},{"line_number":442,"context_line":"                        block_ingress \u003d True"},{"line_number":443,"context_line":"                matched_crds.append(crd)"},{"line_number":444,"context_line":"                sg_list.append(str(crd[\u0027spec\u0027][\u0027securityGroupId\u0027]))"},{"line_number":445,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1751420f","line":442,"range":{"start_line":441,"start_character":0,"end_line":442,"end_character":44},"updated":"2019-10-03 07:44:01.000000000","message":"what if the policy_type lenght is 2 and includes ingress? or if it is 0? Those cases also apply to ingress","commit_id":"cbf9f14b12ffd90abaa4a76b6bdb583b1cff2785"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7e9b1718188fe0d07f1f71883ae573fb1bc7484c","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            LOG.debug(\"Appending %s\", str(crd[\u0027spec\u0027][\u0027securityGroupId\u0027]))"},{"line_number":448,"context_line":"            sg_list.append(str(crd[\u0027spec\u0027][\u0027securityGroupId\u0027]))"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if block_ingress:"},{"line_number":451,"context_line":"        for crd in matched_crds:"},{"line_number":452,"context_line":"            matched \u003d False"},{"line_number":453,"context_line":"            updated_i_rules \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3749de5f","line":450,"range":{"start_line":450,"start_character":0,"end_line":450,"end_character":21},"updated":"2019-10-03 07:44:01.000000000","message":"I see this block has egress rules too. Aren\u0027t they needed even if ingress is not blocked?","commit_id":"cbf9f14b12ffd90abaa4a76b6bdb583b1cff2785"}]}