)]}'
{"kuryr_kubernetes/controller/drivers/neutron_vif.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4523a96ceef4f9dd41d58eecdcf09829e3ce75a6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            port \u003d neutron.show_port(vif.id).get(\u0027port\u0027)"},{"line_number":92,"context_line":"        except n_exc.ConnectFailure:"},{"line_number":93,"context_line":"            LOG.debug(\"Unable to obtain port information, retrying.\")"},{"line_number":94,"context_line":"            raise k_exc.ResourceNotReady(vif)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c614bb46","line":92,"range":{"start_line":92,"start_character":21,"end_line":92,"end_character":35},"updated":"2019-10-14 16:12:57.000000000","message":"Shouldn\u0027t this be a InternalServerError exception? Neutron Python client [1] has no ConnectFailure exception.\n[1] https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/exceptions.py","commit_id":"cfb87fda354dd6056c94b08d9e3a6863fbdfc04b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"996e277a730df5adc517ade777ae426ed9a03c38","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        neutron \u003d clients.get_neutron_client()"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            port \u003d neutron.show_port(vif.id).get(\u0027port\u0027)"},{"line_number":92,"context_line":"        except n_exc.ConnectFailure:"},{"line_number":93,"context_line":"            LOG.debug(\"Unable to obtain port information, retrying.\")"},{"line_number":94,"context_line":"            raise k_exc.ResourceNotReady(vif)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_399db0bb","line":92,"range":{"start_line":92,"start_character":21,"end_line":92,"end_character":35},"in_reply_to":"3fa7e38b_c614bb46","updated":"2019-10-14 16:53:29.000000000","message":"nice catch, I\u0027m going to use the ConnectionFailed instead!","commit_id":"cfb87fda354dd6056c94b08d9e3a6863fbdfc04b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3599522c7222df7c521072b8516f755f596d9730","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from kuryr.lib import constants as kl_const"},{"line_number":17,"context_line":"from neutronclient.common import exceptions as n_exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from kuryr_kubernetes import clients"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_203d53c3","line":18,"updated":"2019-10-16 10:22:12.000000000","message":"I guess this one is unnecessary?","commit_id":"9cd4ad3b14a4e6e59b9178743d04f6d22ebb5eb8"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f1889bbc8ec5b8d2d00dcec0279a14c4cd8cac2d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from kuryr.lib import constants as kl_const"},{"line_number":17,"context_line":"from neutronclient.common import exceptions as n_exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from kuryr_kubernetes import clients"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6ca8248b","line":18,"in_reply_to":"3fa7e38b_203d53c3","updated":"2019-10-16 14:22:46.000000000","message":"Yup, This empty line is not needed.","commit_id":"9cd4ad3b14a4e6e59b9178743d04f6d22ebb5eb8"}]}