)]}'
{"kuryr_kubernetes/controller/drivers/network_policy_security_groups.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"58e91bee03ddffcb32b11dd6663352af4f6f7e64","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                driver_utils.patch_kuryrnetworkpolicy_crd(crd, i_rules,"},{"line_number":552,"context_line":"                                                          e_rules,"},{"line_number":553,"context_line":"                                                          crd_selector)"},{"line_number":554,"context_line":"            if i_matched:"},{"line_number":555,"context_line":"                crd_selectors.append(crd_selector)"},{"line_number":556,"context_line":"        return crd_selectors"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_dccaa69f","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":25},"updated":"2019-10-24 16:25:27.000000000","message":"it is different that a policy is egress only or that there is no ingress matches right? I think _parse_rules does not account for policyType, so not sure this covers all the cases","commit_id":"cd0f3d38de63f0683c1b082bc73047fd49dcffb0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"35c1f9fe427de907a888bb892e6ec08ad99e807b","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                driver_utils.patch_kuryrnetworkpolicy_crd(crd, i_rules,"},{"line_number":552,"context_line":"                                                          e_rules,"},{"line_number":553,"context_line":"                                                          crd_selector)"},{"line_number":554,"context_line":"            if i_matched:"},{"line_number":555,"context_line":"                crd_selectors.append(crd_selector)"},{"line_number":556,"context_line":"        return crd_selectors"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8c97fd45","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":25},"in_reply_to":"3fa7e38b_73ab911d","updated":"2019-10-28 07:54:02.000000000","message":"ok","commit_id":"cd0f3d38de63f0683c1b082bc73047fd49dcffb0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"352200ededde5e68e1decb4cfd170468750e93fe","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                driver_utils.patch_kuryrnetworkpolicy_crd(crd, i_rules,"},{"line_number":552,"context_line":"                                                          e_rules,"},{"line_number":553,"context_line":"                                                          crd_selector)"},{"line_number":554,"context_line":"            if i_matched:"},{"line_number":555,"context_line":"                crd_selectors.append(crd_selector)"},{"line_number":556,"context_line":"        return crd_selectors"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_73ab911d","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":25},"in_reply_to":"3fa7e38b_dccaa69f","updated":"2019-10-25 12:40:54.000000000","message":"As we don\u0027t care about egress, we should only update the LBaaS SG (the return of selectors will trigger that) in case an ingress match has occurred, regardless of egress match.\nSo, in case of egress only, for sure the SG will not get update as we\u0027re only checking ingress.","commit_id":"cd0f3d38de63f0683c1b082bc73047fd49dcffb0"}],"kuryr_kubernetes/controller/handlers/policy.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"49b89b06f4ab12a7e7ae97f3d4e6d1734eb18cdd","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _is_egress_only_policy(self, policy):"},{"line_number":174,"context_line":"        policy_types \u003d policy[\u0027spec\u0027].get(\u0027policyTypes\u0027)"},{"line_number":175,"context_line":"        return ((len(policy_types) \u003d\u003d 1 and \u0027Egress\u0027 in policy_types) or"},{"line_number":176,"context_line":"                (policy[\u0027spec\u0027].get(\u0027egress\u0027) and"},{"line_number":177,"context_line":"                    not policy[\u0027spec\u0027].get(\u0027ingress\u0027)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b2ddaede","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":69},"updated":"2019-10-23 14:46:47.000000000","message":"Would just\n\n list(policy_types) \u003d\u003d [\u0027Egress\u0027]\n\nwork?","commit_id":"a6ab8b1d6e89efafab5062a6cbcb6d621c4f4c3c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"352200ededde5e68e1decb4cfd170468750e93fe","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _is_egress_only_policy(self, policy):"},{"line_number":174,"context_line":"        policy_types \u003d policy[\u0027spec\u0027].get(\u0027policyTypes\u0027)"},{"line_number":175,"context_line":"        return ((len(policy_types) \u003d\u003d 1 and \u0027Egress\u0027 in policy_types) or"},{"line_number":176,"context_line":"                (policy[\u0027spec\u0027].get(\u0027egress\u0027) and"},{"line_number":177,"context_line":"                    not policy[\u0027spec\u0027].get(\u0027ingress\u0027)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_adb1d346","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":69},"in_reply_to":"3fa7e38b_b2ddaede","updated":"2019-10-25 12:40:54.000000000","message":"Done","commit_id":"a6ab8b1d6e89efafab5062a6cbcb6d621c4f4c3c"}]}