)]}'
{"kuryr_kubernetes/tests/fake.py":[{"author":{"_account_id":29615,"name":"Nayan Deshmukh","email":"n.deshmukh@samsung.com","username":"n.deshmukh"},"change_message_id":"0f90fbcb75ff257a900338b5af00ec8368076189","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _fake_vifs(cls\u003dosv_vif.VIFOpenVSwitch):"},{"line_number":65,"context_line":"    return {\u0027eth0\u0027: _fake_vif(cls), \u0027eth1\u0027: _fake_vif(cls)}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _fake_vifs_dict(obj\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_97a08f93","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":58},"updated":"2019-11-14 08:05:20.000000000","message":"I think this set of tests for additional vifs should come as part of another patch as these are unrelated to changes made in this patch.","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"},{"author":{"_account_id":28082,"name":"Yash Gupta","email":"y.gupta@samsung.com","username":"y.gupta"},"change_message_id":"303751c37dcc488012123d047d72e66d6cce2733","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _fake_vifs(cls\u003dosv_vif.VIFOpenVSwitch):"},{"line_number":65,"context_line":"    return {\u0027eth0\u0027: _fake_vif(cls), \u0027eth1\u0027: _fake_vif(cls)}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _fake_vifs_dict(obj\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_77ddd3db","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":58},"in_reply_to":"3fa7e38b_97a08f93","updated":"2019-11-14 08:30:31.000000000","message":"this is needed to test default_gateway \u003d True and False cases individually. \n\nDo you suggest to write tests for old (incorrect) behavior first, and then write new tests for the correct behavior introduced in this patch?","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"}],"kuryr_kubernetes/tests/unit/cni/plugins/test_k8s_cni_registry.py":[{"author":{"_account_id":29615,"name":"Nayan Deshmukh","email":"n.deshmukh@samsung.com","username":"n.deshmukh"},"change_message_id":"74d6e66f975f74fa092f52e6f7908bdcfaa3e7d9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.plugin.add(self.params)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        m_lock.assert_called_with(\u0027default/foo\u0027, external\u003dTrue)"},{"line_number":48,"context_line":"        m_connect.assert_any_call(mock.ANY, mock.ANY, self.default_iface,"},{"line_number":49,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":50,"context_line":"                                  is_default_gateway\u003dTrue,"},{"line_number":51,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7752b337","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":72},"updated":"2019-11-14 08:52:43.000000000","message":"This change corresponds to the change that you made i.e. assigning the correct ifname.","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"},{"author":{"_account_id":29615,"name":"Nayan Deshmukh","email":"n.deshmukh@samsung.com","username":"n.deshmukh"},"change_message_id":"74d6e66f975f74fa092f52e6f7908bdcfaa3e7d9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":50,"context_line":"                                  is_default_gateway\u003dTrue,"},{"line_number":51,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":52,"context_line":"        m_connect.assert_any_call(mock.ANY, mock.ANY, self.additional_iface,"},{"line_number":53,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":54,"context_line":"                                  is_default_gateway\u003dFalse,"},{"line_number":55,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":56,"context_line":"        self.assertEqual(\u0027cont_id\u0027,"},{"line_number":57,"context_line":"                         self.plugin.registry[\u0027default/foo\u0027][\u0027containerid\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_772713c9","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":57},"updated":"2019-11-14 08:52:43.000000000","message":"Whereas this is the new test case which doesn\u0027t correspond to the change that you made in this patch. I just think that it will be good to have this test as a separate patch.","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"},{"author":{"_account_id":29615,"name":"Nayan Deshmukh","email":"n.deshmukh@samsung.com","username":"n.deshmukh"},"change_message_id":"93dc6c51373c2fd9dc68f01cad33058847e87900","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":50,"context_line":"                                  is_default_gateway\u003dTrue,"},{"line_number":51,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":52,"context_line":"        m_connect.assert_any_call(mock.ANY, mock.ANY, self.additional_iface,"},{"line_number":53,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":54,"context_line":"                                  is_default_gateway\u003dFalse,"},{"line_number":55,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":56,"context_line":"        self.assertEqual(\u0027cont_id\u0027,"},{"line_number":57,"context_line":"                         self.plugin.registry[\u0027default/foo\u0027][\u0027containerid\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c25ab5f0","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":57},"in_reply_to":"3fa7e38b_1a2cc648","updated":"2019-11-15 08:20:16.000000000","message":"From what I understand we are not changing the name of the interface that we use for additional interfaces. So this case should pass just fine even with the old code.","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"},{"author":{"_account_id":28082,"name":"Yash Gupta","email":"y.gupta@samsung.com","username":"y.gupta"},"change_message_id":"cfbb6abfc848b8d94ef98474f36d42ac7ab1a68c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":50,"context_line":"                                  is_default_gateway\u003dTrue,"},{"line_number":51,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":52,"context_line":"        m_connect.assert_any_call(mock.ANY, mock.ANY, self.additional_iface,"},{"line_number":53,"context_line":"                                  123, report_health\u003dmock.ANY,"},{"line_number":54,"context_line":"                                  is_default_gateway\u003dFalse,"},{"line_number":55,"context_line":"                                  container_id\u003d\u0027cont_id\u0027)"},{"line_number":56,"context_line":"        self.assertEqual(\u0027cont_id\u0027,"},{"line_number":57,"context_line":"                         self.plugin.registry[\u0027default/foo\u0027][\u0027containerid\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1a2cc648","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":57},"in_reply_to":"3fa7e38b_772713c9","updated":"2019-11-14 09:17:13.000000000","message":"just FYI, my intent was to test the negative case, that we connect using additional interface name when it is an additional vif.\n\na faulty implementation could use params.CNI_IFNAME for all interfaces (which would be \u003d self.default_iface here), which would fail this test.","commit_id":"67e5d7271c058bdfb72664c2842f33a8d1fd8b6f"}]}