)]}'
{"kuryr_kubernetes/cni/binding/base.py":[{"author":{"_account_id":28396,"name":"Alexey Perevalov","email":"alexey.perevalov@huawei.com","username":"a.perevalov"},"change_message_id":"e398f14c6994a08ab80621aff2efe77b6bbee651","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                routes.add(gateway\u003dstr(route.gateway),"},{"line_number":93,"context_line":"                           dst\u003dstr(route.cidr)).commit()"},{"line_number":94,"context_line":"            if is_default_gateway and hasattr(subnet, \u0027gateway\u0027):"},{"line_number":95,"context_line":"                try:"},{"line_number":96,"context_line":"                    routes.add(gateway\u003dstr(subnet.gateway),"},{"line_number":97,"context_line":"                               dst\u003d\u0027default\u0027).commit()"},{"line_number":98,"context_line":"                except pyroute2.NetlinkError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bb18261e","line":95,"updated":"2019-11-13 14:39:12.000000000","message":"I\u0027m ok with exception, it\u0027s necessary.\nBut what do you think, \"routes\" has also an interface - the list of dict with existing routes. We can just check whether dst \u003d\u003d \"default\" and gateway \u003d str(subnet.gateway) presents in routes and skip if it already there. Also I think it\u0027s possible to put it into _need_configure_l3.","commit_id":"22517039552c624045fcd380d5e43b7076e26af3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bc1d19cd9ea030b26f546b7948f6206693623af6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                routes.add(gateway\u003dstr(route.gateway),"},{"line_number":93,"context_line":"                           dst\u003dstr(route.cidr)).commit()"},{"line_number":94,"context_line":"            if is_default_gateway and hasattr(subnet, \u0027gateway\u0027):"},{"line_number":95,"context_line":"                try:"},{"line_number":96,"context_line":"                    routes.add(gateway\u003dstr(subnet.gateway),"},{"line_number":97,"context_line":"                               dst\u003d\u0027default\u0027).commit()"},{"line_number":98,"context_line":"                except pyroute2.NetlinkError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d96351b0","line":95,"in_reply_to":"3fa7e38b_bb18261e","updated":"2019-11-20 14:00:25.000000000","message":"It\u0027s better this way - checking first would be prone to a race condition. In terms of where the code should go, I\u0027m fine either way.","commit_id":"22517039552c624045fcd380d5e43b7076e26af3"}]}