)]}'
{"kuryr_kubernetes/handlers/retry.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8d67a28973c7bc902feafdc47f17c30224d5df8d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                with excutils.save_and_reraise_exception() as ex:"},{"line_number":84,"context_line":"                    if self._sleep(deadline, attempt, ex.value):"},{"line_number":85,"context_line":"                        ex.reraise \u003d False"},{"line_number":86,"context_line":"            except (self._exceptions, key_exc.connection.ConnectFailure,"},{"line_number":87,"context_line":"                    requests_exc.ConnectionError):"},{"line_number":88,"context_line":"                with excutils.save_and_reraise_exception() as ex:"},{"line_number":89,"context_line":"                    if self._sleep(deadline, attempt, ex.value):"},{"line_number":90,"context_line":"                        ex.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dc456a16","line":87,"range":{"start_line":86,"start_character":19,"end_line":87,"end_character":50},"updated":"2019-11-21 16:10:45.000000000","message":"Then why don\u0027t we put those in the self._exceptions to keep the RetryHandler generic? That can be done here: https://github.com/openstack/kuryr-kubernetes/blob/60213747a3eadf93437d96caf59530e28b847bb7/kuryr_kubernetes/controller/handlers/pipeline.py#L58","commit_id":"036a1a06b94e0a3a1de36dc59ee74f9792cbff28"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2266c88c1b7d31cb8895d90de50725990fd17dfd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                with excutils.save_and_reraise_exception() as ex:"},{"line_number":84,"context_line":"                    if self._sleep(deadline, attempt, ex.value):"},{"line_number":85,"context_line":"                        ex.reraise \u003d False"},{"line_number":86,"context_line":"            except (self._exceptions, key_exc.connection.ConnectFailure,"},{"line_number":87,"context_line":"                    requests_exc.ConnectionError):"},{"line_number":88,"context_line":"                with excutils.save_and_reraise_exception() as ex:"},{"line_number":89,"context_line":"                    if self._sleep(deadline, attempt, ex.value):"},{"line_number":90,"context_line":"                        ex.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f29ded56","line":87,"range":{"start_line":86,"start_character":19,"end_line":87,"end_character":50},"in_reply_to":"3fa7e38b_dc456a16","updated":"2019-11-21 17:00:01.000000000","message":"true. Thanks!","commit_id":"036a1a06b94e0a3a1de36dc59ee74f9792cbff28"}]}
