)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2d0d14bb1fa63d769582cbda4f9694356c40b006","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":809,"context_line":"        try:"},{"line_number":810,"context_line":"            response \u003d lbaas.get_load_balancer(lb_uuid)"},{"line_number":811,"context_line":"        except (o_exc.ResourceNotFound, o_exc.NotFoundException):"},{"line_number":812,"context_line":"            LOG.debug(\"Couldn\u0027t find loadbalancer with uuid\u003d%s\", lb_uuid)"},{"line_number":813,"context_line":"            return None"},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f5338d5f","line":811,"range":{"start_line":811,"start_character":0,"end_line":811,"end_character":65},"updated":"2019-11-22 09:02:47.000000000","message":"Apparently it\u0027s the same exception [1] in current openstacksdk. I bet you\u0027re looking into fixing this for 0.17.2 which was in our lower-constraints. This is fine, but back then [2] ResourceNotFound was a subclass of NotFoundException. So seems like putting just NotFoundException here is enough.\n\n[1] https://github.com/openstack/openstacksdk/blob/5ae0d72247f02c56c59a7fcb5b15e48539740d60/openstack/exceptions.py#L143-L148\n[2] https://github.com/openstack/openstacksdk/blob/0.17.2/openstack/exceptions.py#L145-L147","commit_id":"14064a3d8f7a9d9e3a4097403d8f11179408f3ff"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"30f478b14261e21fcf6b79e1d13c3a650ebf144b","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":809,"context_line":"        try:"},{"line_number":810,"context_line":"            response \u003d lbaas.get_load_balancer(lb_uuid)"},{"line_number":811,"context_line":"        except (o_exc.ResourceNotFound, o_exc.NotFoundException):"},{"line_number":812,"context_line":"            LOG.debug(\"Couldn\u0027t find loadbalancer with uuid\u003d%s\", lb_uuid)"},{"line_number":813,"context_line":"            return None"},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e9e5f8db","line":811,"range":{"start_line":811,"start_character":0,"end_line":811,"end_character":65},"in_reply_to":"3fa7e38b_b51f556e","updated":"2019-11-22 13:31:54.000000000","message":"You\u0027re right. I didn\u0027t notice it was a subclass of NotFoundException.","commit_id":"14064a3d8f7a9d9e3a4097403d8f11179408f3ff"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"157098569f8d4eadb38105ef8ca665cf77039ce4","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":809,"context_line":"        try:"},{"line_number":810,"context_line":"            response \u003d lbaas.get_load_balancer(lb_uuid)"},{"line_number":811,"context_line":"        except (o_exc.ResourceNotFound, o_exc.NotFoundException):"},{"line_number":812,"context_line":"            LOG.debug(\"Couldn\u0027t find loadbalancer with uuid\u003d%s\", lb_uuid)"},{"line_number":813,"context_line":"            return None"},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b51f556e","line":811,"range":{"start_line":811,"start_character":0,"end_line":811,"end_character":65},"in_reply_to":"3fa7e38b_d568d1f4","updated":"2019-11-22 09:14:51.000000000","message":"Yup, it should be enough to satisfy both cases.","commit_id":"14064a3d8f7a9d9e3a4097403d8f11179408f3ff"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9e3495effe460305a636861d08de21579b1a0c77","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":809,"context_line":"        try:"},{"line_number":810,"context_line":"            response \u003d lbaas.get_load_balancer(lb_uuid)"},{"line_number":811,"context_line":"        except (o_exc.ResourceNotFound, o_exc.NotFoundException):"},{"line_number":812,"context_line":"            LOG.debug(\"Couldn\u0027t find loadbalancer with uuid\u003d%s\", lb_uuid)"},{"line_number":813,"context_line":"            return None"},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d568d1f4","line":811,"range":{"start_line":811,"start_character":0,"end_line":811,"end_character":65},"in_reply_to":"3fa7e38b_f5338d5f","updated":"2019-11-22 09:08:17.000000000","message":"so you think we should just keep NotFoundException instead of ResourceNotFound?","commit_id":"14064a3d8f7a9d9e3a4097403d8f11179408f3ff"}]}
