)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9fd1e93de57553be4b1fd79c4625a5d093b2c0c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure not found exception is ignored when LB is not present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using ovn-octavia driver a load balancer can be deleted"},{"line_number":10,"context_line":"fast enought to cause a NotFoundException when trying to retrieve"},{"line_number":11,"context_line":"it, which is different than the current exception being handled."},{"line_number":12,"context_line":"This commit ensures the additional exception is handled."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I11edd23303a017b281ef3a9a4ff28ee8baeb08cd"},{"line_number":15,"context_line":"Closes-bug: 1853498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_77aaf6d3","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":56},"updated":"2019-11-28 08:28:14.000000000","message":"Really? As fair as I see in OpenStackSDK code, those two types of exceptions (ResourceNotFound and NotFoundException) are exactly the same[1], and was changed in v0.18 of OpenStackSDK. In current and future code, I expect to have rather ResourceNotFound instead of NotFoundException.\n\nMaybe a better idea is to catch both of them now with a TODO to remove it in the future, when we have lower constraints high enough ;)\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/b503f1ff570d77298df83f676e1e4ac287ad770e/openstack/exceptions.py#L143-L148","commit_id":"45539baeb4622231af9019ff7d71f203a72fab15"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"12aa6a7340d8b3e051ead0360b51a2fafc94c756","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure not found exception is ignored when LB is not present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using ovn-octavia driver a load balancer can be deleted"},{"line_number":10,"context_line":"fast enought to cause a NotFoundException when trying to retrieve"},{"line_number":11,"context_line":"it, which is different than the current exception being handled."},{"line_number":12,"context_line":"This commit ensures the additional exception is handled."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I11edd23303a017b281ef3a9a4ff28ee8baeb08cd"},{"line_number":15,"context_line":"Closes-bug: 1853498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_b73cee92","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":56},"in_reply_to":"3fa7e38b_77aaf6d3","updated":"2019-11-28 08:32:22.000000000","message":"Note this is already a cherry-pick of the ps that got merged in master. I would rather merge this and change it on master (and backport it). Besides, I actually hit this problem of NotFoundException being triggered (and not captured) instead of ResourceNotFound","commit_id":"45539baeb4622231af9019ff7d71f203a72fab15"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"25b2144361bfe537a035fef1597afb30ef6a8bc9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure not found exception is ignored when LB is not present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using ovn-octavia driver a load balancer can be deleted"},{"line_number":10,"context_line":"fast enought to cause a NotFoundException when trying to retrieve"},{"line_number":11,"context_line":"it, which is different than the current exception being handled."},{"line_number":12,"context_line":"This commit ensures the additional exception is handled."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I11edd23303a017b281ef3a9a4ff28ee8baeb08cd"},{"line_number":15,"context_line":"Closes-bug: 1853498"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_e28386ca","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":56},"in_reply_to":"3fa7e38b_b73cee92","updated":"2019-11-28 10:15:10.000000000","message":"Roman, we saw that on builds from openshift/kuryr-kubernetes that were using older dependencies (but still in range of lower-constraints). This commit would only be a fix for anyone building from older deps, but still should not hurt.","commit_id":"45539baeb4622231af9019ff7d71f203a72fab15"}]}