)]}'
{"kuryr_kubernetes/clients.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c0160fe12347805da70debb2836a5a7d196c9db2","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_trunks(self, payload):"},{"line_number":94,"context_line":"    \"\"\"Return trunks filtered by whatever\"\"\""},{"line_number":95,"context_line":"    # TODO(gryf): Trunk object should be expanded by tags attribute in"},{"line_number":96,"context_line":"    # openstacksdk instead."},{"line_number":97,"context_line":"    response \u003d self.get(os_trunk.Trunk.base_path, params\u003dpayload)"},{"line_number":98,"context_line":"    if not response.ok:"},{"line_number":99,"context_line":"        raise os_exc.SDKException(\u0027Error on searching trunks with params %s: \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fb6d532f","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":27},"updated":"2019-12-02 11:38:08.000000000","message":"Actually, this was done in version 0.21[1] of OpenStackSDK, but we are currently using 0.17.\n\n[1] https://opendev.org/openstack/openstacksdk/src/tag/0.21.0/openstack/network/v2/trunk.py#L17","commit_id":"41f1983ff107a51ead4cadc7a6a31427a1617d97"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4fafac84d4b45e56487be0354c3f53af974c524b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    response \u003d self.get(os_trunk.Trunk.base_path, params\u003dpayload)"},{"line_number":100,"context_line":"    if not response.ok:"},{"line_number":101,"context_line":"        raise os_exc.SDKException(\u0027Error on searching trunks with params %s: \u0027"},{"line_number":102,"context_line":"                                  \u0027%s\u0027, payload, response.text)"},{"line_number":103,"context_line":"    return (os_trunk.Trunk(**item) for item in response.json()[\u0027trunks\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_76462a25","line":102,"range":{"start_line":102,"start_character":38,"end_line":102,"end_character":62},"updated":"2019-12-23 16:50:11.000000000","message":"This isn\u0027t LOG.error, need to use % operator.","commit_id":"e4939613b7aa6a7123e554d21627d86ad724f58b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1a100d11652ecb9aa3c189b1ab1445c0bb1d7917","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_trunks(self, payload):"},{"line_number":94,"context_line":"    \"\"\"Return trunks filtered by whatever\"\"\""},{"line_number":95,"context_line":"    # TODO(gryf): Trunk object have been updated in OpenStackSDK 0.21. After"},{"line_number":96,"context_line":"    # we bump to this version (or higher), this method can be safely removed,"},{"line_number":97,"context_line":"    # and its call replaced with:"},{"line_number":98,"context_line":"    #   os_net.trunks(tags\u003d[...])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_a794c799","line":95,"range":{"start_line":95,"start_character":65,"end_line":95,"end_character":69},"updated":"2020-01-14 13:35:28.000000000","message":"Over thew course of this going on we ended up bumping openstacksdk to 0.36.0 in the lower-constraints, so I guess this can be reworked.\n\nI\u0027m fine with doing that in subsequent patch - we have this code tested.","commit_id":"79ca13614d0ec55ef454c278bec5e06cf20c2170"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"18952ac95a71cb7af1502e5e30d3abe3dcd2531a","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_trunks(self, payload):"},{"line_number":94,"context_line":"    \"\"\"Return trunks filtered by whatever\"\"\""},{"line_number":95,"context_line":"    # TODO(gryf): Trunk object have been updated in OpenStackSDK 0.21. After"},{"line_number":96,"context_line":"    # we bump to this version (or higher), this method can be safely removed,"},{"line_number":97,"context_line":"    # and its call replaced with:"},{"line_number":98,"context_line":"    #   os_net.trunks(tags\u003d[...])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_e78abf63","line":95,"range":{"start_line":95,"start_character":65,"end_line":95,"end_character":69},"in_reply_to":"3fa7e38b_a794c799","updated":"2020-01-14 13:37:22.000000000","message":"Ack. I\u0027m adding an item on my todo list.","commit_id":"79ca13614d0ec55ef454c278bec5e06cf20c2170"}]}