)]}'
{"kuryr_kubernetes/os_vif_util.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dd8982f05314269f130a2efb8d9c502182256d7c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    return (neutron_port[\u0027status\u0027] \u003d\u003d kl_const.PORT_STATUS_ACTIVE)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"def neutron_to_osvif_vif_ovs(vif_plugin, os_port, subnets):"},{"line_number":210,"context_line":"    \"\"\"Converts Neutron port to VIF object for os-vif \u0027ovs\u0027 plugin."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    :param vif_plugin: name of the os-vif plugin to use (i.e. \u0027ovs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_34160ef4","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":28},"updated":"2019-12-11 11:52:01.000000000","message":"Do you even need to change this in this patch? I think I got it working without touching this method.","commit_id":"0f30270ba6a4d7d799601bc531968fd4a23fb428"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6c3ac155109ad7f5a24117bf2b2399647c8154a3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    return (neutron_port[\u0027status\u0027] \u003d\u003d kl_const.PORT_STATUS_ACTIVE)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"def neutron_to_osvif_vif_ovs(vif_plugin, os_port, subnets):"},{"line_number":210,"context_line":"    \"\"\"Converts Neutron port to VIF object for os-vif \u0027ovs\u0027 plugin."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    :param vif_plugin: name of the os-vif plugin to use (i.e. \u0027ovs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_971b441a","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":28},"in_reply_to":"3fa7e38b_34160ef4","updated":"2019-12-11 13:00:38.000000000","message":"Hm. I\u0027ll revert it, but I was almost sure, one of the method pass there something different than dict…","commit_id":"0f30270ba6a4d7d799601bc531968fd4a23fb428"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2b98855537170c4506796f0de9a84c714b28630f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    return (neutron_port[\u0027status\u0027] \u003d\u003d kl_const.PORT_STATUS_ACTIVE)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"def neutron_to_osvif_vif_ovs(vif_plugin, os_port, subnets):"},{"line_number":210,"context_line":"    \"\"\"Converts Neutron port to VIF object for os-vif \u0027ovs\u0027 plugin."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    :param vif_plugin: name of the os-vif plugin to use (i.e. \u0027ovs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c9fd9508","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":28},"in_reply_to":"3fa7e38b_971b441a","updated":"2019-12-12 10:01:35.000000000","message":"To me neutron_to_osvif_vif() is only called by the drivers and I don\u0027t think you\u0027ve touched them. Unless the vif_pool one?","commit_id":"0f30270ba6a4d7d799601bc531968fd4a23fb428"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"7c7c2db32a7a7261a0613aed0b6b1f6ef6047182","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    return (neutron_port[\u0027status\u0027] \u003d\u003d kl_const.PORT_STATUS_ACTIVE)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"def neutron_to_osvif_vif_ovs(vif_plugin, os_port, subnets):"},{"line_number":210,"context_line":"    \"\"\"Converts Neutron port to VIF object for os-vif \u0027ovs\u0027 plugin."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    :param vif_plugin: name of the os-vif plugin to use (i.e. \u0027ovs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e97ad1ed","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":28},"in_reply_to":"3fa7e38b_c9fd9508","updated":"2019-12-12 10:32:26.000000000","message":"No, they ain\u0027t merged yet. Only handlers and utils was.","commit_id":"0f30270ba6a4d7d799601bc531968fd4a23fb428"}]}
