)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"43effc79d27e377a3aec69dddbd47674b8878df3","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_611fc659","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"updated":"2019-12-13 08:49:17.000000000","message":"this should be a different try at line 382, right?","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"2da34200864c43e08cc5e6a5a7a04d82a3ea495e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_bc5f07e3","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"in_reply_to":"3fa7e38b_611fc659","updated":"2019-12-16 12:54:03.000000000","message":"That will be caught in 396, like before. utils.get_subnet_cidr can cause os_exc exception. If we didn\u0027t change anything in utils module, than both exceptions would be caught by the NeutronClientException whatever the reason. Eventually, we exchange the NeutronClientException to SDKException, unless you want to catch both of the exceptions separately.","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"3e2e42af040f7531e52c99d9df9b4c06cb0b5284","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ab89fb25","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"in_reply_to":"3fa7e38b_65833205","updated":"2019-12-16 17:05:22.000000000","message":"\u003e my point here is that worker_subnet_id is only used at lines 379/381, so, this message is targetting that, which I assume it should be a try/catch for lines 382-391. \n\nos_exc.ResourceNotFound will only raise on utils.get_subnet_cidr failure, since only this function was converted to openstacksdk at this point. So if we enclose with try:except lines 382-391 for this exception, it\u0027s not going to help, because that is still neutron client call.\n\nWe can enclose with try:except line 381:\n\n    try:\n        worker_subnet_cidr \u003d utils.get_subnet_cidr(worker_subnet_id)\n    except os_exc.ResourceNotFound:\n        LOG.exception(…)\n\nto narrow down the exception, if that\u0027s the point.\n\n\u003e Then, of course we still need to have the except at line 396 catching the NeutronClientException for both lines 365 and 382.\n\nRight.","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"966eb96486f716d30fbc81018ae23c6251f5b289","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0eddb312","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"in_reply_to":"3fa7e38b_6b1c5914","updated":"2019-12-17 09:54:09.000000000","message":"Ack. We don\u0027t want to create security group without worker_subnet_cidr anyway.","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c4b69e2dd27bf1b52c246c7b85203e34e66abc67","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6b1c5914","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"in_reply_to":"3fa7e38b_ab89fb25","updated":"2019-12-17 08:03:17.000000000","message":"Right, this try/except should be on line 381, and perhaps also including 382-390 ass this neutron.create_security_group_rule will also go away soon","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b1a5e58543806d01896a5d6b1b0aa7d983389aec","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        \u0027description\u0027: listener.name,"},{"line_number":391,"context_line":"                    },"},{"line_number":392,"context_line":"                })"},{"line_number":393,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":394,"context_line":"            LOG.exception(\u0027Failed when creating security group rule due to \u0027"},{"line_number":395,"context_line":"                          \u0027nonexistent worker_subnet_id: %s\u0027, worker_subnet_id)"},{"line_number":396,"context_line":"        except n_exc.NeutronClientException as ex:"},{"line_number":397,"context_line":"            if ex.status_code !\u003d requests.codes.conflict:"},{"line_number":398,"context_line":"                LOG.exception(\u0027Failed when creating security group rule \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_65833205","line":395,"range":{"start_line":393,"start_character":0,"end_line":395,"end_character":79},"in_reply_to":"3fa7e38b_bc5f07e3","updated":"2019-12-16 15:30:10.000000000","message":"my point here is that worker_subnet_id is only used at lines 379/381, so, this message is targetting that, which I assume it should be a try/catch for lines 382-391. Then, of course we still need to have the except at line 396 catching the NeutronClientException for both lines 365 and 382.","commit_id":"8d4f35c178c4257854188ea95fef904a02e72acc"}],"kuryr_kubernetes/controller/handlers/vif.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"41b26ff8a9d762b75eb44c3ec6748e82255c5a5b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if not state:"},{"line_number":95,"context_line":"            try:"},{"line_number":96,"context_line":"                subnets \u003d self._drv_subnets.get_subnets(pod, project_id)"},{"line_number":97,"context_line":"            except (n_exc.NotFound, k_exc.K8sResourceNotFound):"},{"line_number":98,"context_line":"                LOG.warning(\"Subnet does not exists. If namespace driver is \""},{"line_number":99,"context_line":"                            \"used, probably the namespace for the pod is \""},{"line_number":100,"context_line":"                            \"already deleted. So this pod does not need to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e81bc018","side":"PARENT","line":97,"range":{"start_line":97,"start_character":36,"end_line":97,"end_character":61},"updated":"2019-12-11 08:33:10.000000000","message":"This one should be kept, it\u0027s an exception from K8s, not OpenStack and it\u0027s when we look for a KuryrNet CRD in K8s API.","commit_id":"e4e3da5178002b793353027a01447f24113eb6a9"}]}