)]}'
{"kuryr_kubernetes/cni/binding/sriov.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"ee92687a5850e2fe4b02ed237a440061752eba9b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            old_driver_path \u003d \u0027/sys/bus/pci/devices/{}/driver\u0027.format(pci)"},{"line_number":196,"context_line":"            old_driver_link \u003d os.readlink(old_driver_path)"},{"line_number":197,"context_line":"            old_driver \u003d os.path.basename(old_driver_link)"},{"line_number":198,"context_line":"        if old_driver not in constants.MELLANOX_DRIVERS:"},{"line_number":199,"context_line":"            unbind_path \u003d \u0027/sys/bus/pci/drivers/{}/unbind\u0027.format(old_driver)"},{"line_number":200,"context_line":"            bind_path \u003d \u0027/sys/bus/pci/drivers/{}/bind\u0027.format(driver)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4e4c0b3f","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":56},"updated":"2019-12-17 09:22:41.000000000","message":"I have no strong opinions regarding this, but how about:\n\n    if old_driver in constants.MELLANOX_DRIVERS:\n        return old_driver\n\nthat way, we could avoid increasing indentation level.","commit_id":"20e14a9e2bfe8e62b49511ff7142cd2533e755f6"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"874a391d307cd8195903d1023c5aafe96fcfb968","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            old_driver_path \u003d \u0027/sys/bus/pci/devices/{}/driver\u0027.format(pci)"},{"line_number":196,"context_line":"            old_driver_link \u003d os.readlink(old_driver_path)"},{"line_number":197,"context_line":"            old_driver \u003d os.path.basename(old_driver_link)"},{"line_number":198,"context_line":"        if old_driver not in constants.MELLANOX_DRIVERS:"},{"line_number":199,"context_line":"            unbind_path \u003d \u0027/sys/bus/pci/drivers/{}/unbind\u0027.format(old_driver)"},{"line_number":200,"context_line":"            bind_path \u003d \u0027/sys/bus/pci/drivers/{}/bind\u0027.format(driver)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_eecdb792","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":56},"in_reply_to":"3fa7e38b_4e4c0b3f","updated":"2019-12-17 09:29:14.000000000","message":"yes, but this way we will have two \"return old_driver\". Here and at the end of method","commit_id":"20e14a9e2bfe8e62b49511ff7142cd2533e755f6"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"b2ed59d286f062aa1328124075b3a5df949ca289","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            old_driver_path \u003d \u0027/sys/bus/pci/devices/{}/driver\u0027.format(pci)"},{"line_number":196,"context_line":"            old_driver_link \u003d os.readlink(old_driver_path)"},{"line_number":197,"context_line":"            old_driver \u003d os.path.basename(old_driver_link)"},{"line_number":198,"context_line":"        if old_driver not in constants.MELLANOX_DRIVERS:"},{"line_number":199,"context_line":"            unbind_path \u003d \u0027/sys/bus/pci/drivers/{}/unbind\u0027.format(old_driver)"},{"line_number":200,"context_line":"            bind_path \u003d \u0027/sys/bus/pci/drivers/{}/bind\u0027.format(driver)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e805a47a","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":56},"in_reply_to":"3fa7e38b_887e7019","updated":"2019-12-17 18:28:40.000000000","message":"ok, sure\nanyway, we have a chance to fix it in next commit;)","commit_id":"20e14a9e2bfe8e62b49511ff7142cd2533e755f6"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"02f1d77c27656f54c00cf06d804e9fe3f42b5a85","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            old_driver_path \u003d \u0027/sys/bus/pci/devices/{}/driver\u0027.format(pci)"},{"line_number":196,"context_line":"            old_driver_link \u003d os.readlink(old_driver_path)"},{"line_number":197,"context_line":"            old_driver \u003d os.path.basename(old_driver_link)"},{"line_number":198,"context_line":"        if old_driver not in constants.MELLANOX_DRIVERS:"},{"line_number":199,"context_line":"            unbind_path \u003d \u0027/sys/bus/pci/drivers/{}/unbind\u0027.format(old_driver)"},{"line_number":200,"context_line":"            bind_path \u003d \u0027/sys/bus/pci/drivers/{}/bind\u0027.format(driver)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_887e7019","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":56},"in_reply_to":"3fa7e38b_eecdb792","updated":"2019-12-17 18:21:51.000000000","message":"I don\u0027t mind early exits, but as I said, I don\u0027t have strong opinion regarding this particular case :)","commit_id":"20e14a9e2bfe8e62b49511ff7142cd2533e755f6"}]}