)]}'
{"kuryr_kubernetes/controller/handlers/namespace.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4485cad46e7f360f878ff85370b1b7ed0f163f91","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":350,"context_line":"        if not tags:"},{"line_number":351,"context_line":"            return"},{"line_number":352,"context_line":"        while True:"},{"line_number":353,"context_line":"            retry \u003d False"},{"line_number":354,"context_line":"            subnets \u003d os_net.subnets(tags\u003dtags)"},{"line_number":355,"context_line":"            namespaces \u003d k8s.get(constants.K8S_API_NAMESPACES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_33e5363f","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":19},"updated":"2019-12-20 14:32:43.000000000","message":"Could just be `while retry:`, but I\u0027d vote to have max number of this loop repeats.","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8734b65346c4f113328ae9ad9ae00370e3257303","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":350,"context_line":"        if not tags:"},{"line_number":351,"context_line":"            return"},{"line_number":352,"context_line":"        while True:"},{"line_number":353,"context_line":"            retry \u003d False"},{"line_number":354,"context_line":"            subnets \u003d os_net.subnets(tags\u003dtags)"},{"line_number":355,"context_line":"            namespaces \u003d k8s.get(constants.K8S_API_NAMESPACES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f3b1de02","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":19},"in_reply_to":"3fa7e38b_33e5363f","updated":"2019-12-20 14:46:06.000000000","message":"yep, changing it by a for loop","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4485cad46e7f360f878ff85370b1b7ed0f163f91","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                    if (subnet.subnet_pool_id !\u003d"},{"line_number":362,"context_line":"                            oslo_cfg.CONF.namespace_subnet.pod_subnet_pool):"},{"line_number":363,"context_line":"                        # Not a kuryr generated network"},{"line_number":364,"context_line":"                        return"},{"line_number":365,"context_line":"                    try:"},{"line_number":366,"context_line":"                        self._drv_subnets._delete_namespace_network_resources("},{"line_number":367,"context_line":"                            subnet.id, subnet.network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f3eebe1f","line":364,"range":{"start_line":364,"start_character":24,"end_line":364,"end_character":30},"updated":"2019-12-20 14:32:43.000000000","message":"We want to return here? What about next subnet in subnets var?","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8734b65346c4f113328ae9ad9ae00370e3257303","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                    if (subnet.subnet_pool_id !\u003d"},{"line_number":362,"context_line":"                            oslo_cfg.CONF.namespace_subnet.pod_subnet_pool):"},{"line_number":363,"context_line":"                        # Not a kuryr generated network"},{"line_number":364,"context_line":"                        return"},{"line_number":365,"context_line":"                    try:"},{"line_number":366,"context_line":"                        self._drv_subnets._delete_namespace_network_resources("},{"line_number":367,"context_line":"                            subnet.id, subnet.network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_13aa7a83","line":364,"range":{"start_line":364,"start_character":24,"end_line":364,"end_character":30},"in_reply_to":"3fa7e38b_f3eebe1f","updated":"2019-12-20 14:46:06.000000000","message":"Done","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4485cad46e7f360f878ff85370b1b7ed0f163f91","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                            subnet.id, subnet.network_id)"},{"line_number":368,"context_line":"                    except (os_exc.SDKException, exceptions.ResourceNotReady):"},{"line_number":369,"context_line":"                        LOG.debug(\"Cleanup of network namespace resources %s \""},{"line_number":370,"context_line":"                                  \"faiuled. A retry will be triggered.\","},{"line_number":371,"context_line":"                                  subnet.network_id)"},{"line_number":372,"context_line":"                        retry \u003d True"},{"line_number":373,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_53755296","line":370,"range":{"start_line":370,"start_character":35,"end_line":370,"end_character":42},"updated":"2019-12-20 14:32:43.000000000","message":"failed","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8734b65346c4f113328ae9ad9ae00370e3257303","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                            subnet.id, subnet.network_id)"},{"line_number":368,"context_line":"                    except (os_exc.SDKException, exceptions.ResourceNotReady):"},{"line_number":369,"context_line":"                        LOG.debug(\"Cleanup of network namespace resources %s \""},{"line_number":370,"context_line":"                                  \"faiuled. A retry will be triggered.\","},{"line_number":371,"context_line":"                                  subnet.network_id)"},{"line_number":372,"context_line":"                        retry \u003d True"},{"line_number":373,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_339d366c","line":370,"range":{"start_line":370,"start_character":35,"end_line":370,"end_character":42},"in_reply_to":"3fa7e38b_53755296","updated":"2019-12-20 14:46:06.000000000","message":"Done","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4485cad46e7f360f878ff85370b1b7ed0f163f91","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                  \"faiuled. A retry will be triggered.\","},{"line_number":371,"context_line":"                                  subnet.network_id)"},{"line_number":372,"context_line":"                        retry \u003d True"},{"line_number":373,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b39366a4","line":373,"range":{"start_line":373,"start_character":24,"end_line":373,"end_character":32},"updated":"2019-12-20 14:32:43.000000000","message":"This isn\u0027t really needed at this point.","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8734b65346c4f113328ae9ad9ae00370e3257303","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                  \"faiuled. A retry will be triggered.\","},{"line_number":371,"context_line":"                                  subnet.network_id)"},{"line_number":372,"context_line":"                        retry \u003d True"},{"line_number":373,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_73c5ee5b","line":373,"range":{"start_line":373,"start_character":24,"end_line":373,"end_character":32},"in_reply_to":"3fa7e38b_b39366a4","updated":"2019-12-20 14:46:06.000000000","message":"yep, same at line 339, I left it to be explicit. No strong opinion... I can remove both","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4485cad46e7f360f878ff85370b1b7ed0f163f91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fa7e38b_d38e2279","line":374,"updated":"2019-12-20 14:32:43.000000000","message":"There should be some logic to break the loop.","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8734b65346c4f113328ae9ad9ae00370e3257303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fa7e38b_93c0aa4c","line":374,"in_reply_to":"3fa7e38b_d38e2279","updated":"2019-12-20 14:46:06.000000000","message":"Done","commit_id":"d4159910670034b4f04874b1a4e28915a2430a69"},{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"234e7814ba961700fb5022b8d52caba4e09d597f","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            if not retry:"},{"line_number":342,"context_line":"                break"},{"line_number":343,"context_line":"            # Leave time between retries to help Neutron to complete actions"},{"line_number":344,"context_line":"            time.sleep(60)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # NOTE(ltomasbo): to ensure we don\u0027t miss created network resources"},{"line_number":347,"context_line":"        # without associated kuryrnet objects, we do a second search"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_48727114","line":344,"updated":"2019-12-23 14:03:36.000000000","message":"This should probably be a configurable value","commit_id":"3e6b0baeaff8bc81c433ee393ab5de302df9f5f3"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dab02858e41a8ba7dddbf4eee792c96e38ac4ce4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            if not retry:"},{"line_number":342,"context_line":"                break"},{"line_number":343,"context_line":"            # Leave time between retries to help Neutron to complete actions"},{"line_number":344,"context_line":"            time.sleep(60)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # NOTE(ltomasbo): to ensure we don\u0027t miss created network resources"},{"line_number":347,"context_line":"        # without associated kuryrnet objects, we do a second search"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_cb6bbbb6","line":344,"in_reply_to":"3fa7e38b_48727114","updated":"2019-12-23 14:32:59.000000000","message":"Umm, agree with you it should be a constant instead, but not sure if we would like to make this configurable. This is just a cleanup thread so fine tuning here won\u0027t help much","commit_id":"3e6b0baeaff8bc81c433ee393ab5de302df9f5f3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3cd4178d8951de18426affe860d231edb54b25a7","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                                  \"failed. A retry will be triggered.\","},{"line_number":372,"context_line":"                                  subnet.network_id)"},{"line_number":373,"context_line":"                        retry \u003d True"},{"line_number":374,"context_line":"                        continue"},{"line_number":375,"context_line":"            if not retry:"},{"line_number":376,"context_line":"                break"},{"line_number":377,"context_line":"            # Leave time between retries to help Neutron to complete actions"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_13983a67","line":374,"range":{"start_line":374,"start_character":24,"end_line":374,"end_character":32},"updated":"2019-12-20 14:49:22.000000000","message":"I think this continue will make 378 unreachable.","commit_id":"3e6b0baeaff8bc81c433ee393ab5de302df9f5f3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"07bff0f3dd548d3235acb595d760168442241b0d","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                                  \"failed. A retry will be triggered.\","},{"line_number":372,"context_line":"                                  subnet.network_id)"},{"line_number":373,"context_line":"                        retry \u003d True"},{"line_number":374,"context_line":"                        continue"},{"line_number":375,"context_line":"            if not retry:"},{"line_number":376,"context_line":"                break"},{"line_number":377,"context_line":"            # Leave time between retries to help Neutron to complete actions"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b3c7e646","line":374,"range":{"start_line":374,"start_character":24,"end_line":374,"end_character":32},"in_reply_to":"3fa7e38b_13983a67","updated":"2019-12-20 14:51:51.000000000","message":"Nevermind.","commit_id":"3e6b0baeaff8bc81c433ee393ab5de302df9f5f3"}]}