)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0ed26a1e7ac1267046911408556066304a892922","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"        utils.set_lbaas_state(endpoint, lbaas)"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        lsnr_by_id \u003d {l.id: l for l in lbaas.listeners}"},{"line_number":1052,"context_line":"        pool_by_lsnr_port \u003d {(lsnr_by_id[p.listener_id].protocol,"},{"line_number":1053,"context_line":"                              lsnr_by_id[p.listener_id].port): p"},{"line_number":1054,"context_line":"                             for p in lbaas.pools}"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        for port in svc_ports:"},{"line_number":1057,"context_line":"            port_protocol \u003d port[\u0027protocol\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e191cf9b","line":1054,"range":{"start_line":1052,"start_character":0,"end_line":1054,"end_character":50},"updated":"2020-01-03 01:30:04.000000000","message":"Perhaps instead of creating this new dict, we could update the \"lsnr_by_id\" dict to have all the info needed {(port_protocol, target_port): listener_id}.","commit_id":"a0200dbe163cb0b9b76d1ca091f4db0e76b9c46c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6f6e155608d40dc223d3d65e2ca5bc24c24d85da","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"        utils.set_lbaas_state(endpoint, lbaas)"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        lsnr_by_id \u003d {l.id: l for l in lbaas.listeners}"},{"line_number":1052,"context_line":"        pool_by_lsnr_port \u003d {(lsnr_by_id[p.listener_id].protocol,"},{"line_number":1053,"context_line":"                              lsnr_by_id[p.listener_id].port): p"},{"line_number":1054,"context_line":"                             for p in lbaas.pools}"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        for port in svc_ports:"},{"line_number":1057,"context_line":"            port_protocol \u003d port[\u0027protocol\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d791f19b","line":1054,"range":{"start_line":1052,"start_character":0,"end_line":1054,"end_character":50},"in_reply_to":"3fa7e38b_e191cf9b","updated":"2020-01-03 08:46:24.000000000","message":"Done","commit_id":"a0200dbe163cb0b9b76d1ca091f4db0e76b9c46c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0ed26a1e7ac1267046911408556066304a892922","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            target_port \u003d port[\u0027targetPort\u0027]"},{"line_number":1060,"context_line":"            sg_rule_name \u003d \"%s:%s:%s\" % (lbaas_name, port_protocol, lbaas_port)"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"            pool \u003d pool_by_lsnr_port[port_protocol, target_port]"},{"line_number":1063,"context_line":"            listener_id \u003d pool.listener_id"},{"line_number":1064,"context_line":"            self._apply_members_security_groups(lbaas_obj, lbaas_port,"},{"line_number":1065,"context_line":"                                                target_port, port_protocol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c1d93384","line":1062,"range":{"start_line":1062,"start_character":12,"end_line":1062,"end_character":64},"updated":"2020-01-03 01:30:04.000000000","message":"it might be safer to retrieve the value with \"get\"","commit_id":"a0200dbe163cb0b9b76d1ca091f4db0e76b9c46c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6f6e155608d40dc223d3d65e2ca5bc24c24d85da","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            target_port \u003d port[\u0027targetPort\u0027]"},{"line_number":1060,"context_line":"            sg_rule_name \u003d \"%s:%s:%s\" % (lbaas_name, port_protocol, lbaas_port)"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"            pool \u003d pool_by_lsnr_port[port_protocol, target_port]"},{"line_number":1063,"context_line":"            listener_id \u003d pool.listener_id"},{"line_number":1064,"context_line":"            self._apply_members_security_groups(lbaas_obj, lbaas_port,"},{"line_number":1065,"context_line":"                                                target_port, port_protocol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_778a7d65","line":1062,"range":{"start_line":1062,"start_character":12,"end_line":1062,"end_character":64},"in_reply_to":"3fa7e38b_c1d93384","updated":"2020-01-03 08:46:24.000000000","message":"Done","commit_id":"a0200dbe163cb0b9b76d1ca091f4db0e76b9c46c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"be68b004918d156c70b7c4e522ffa05408420517","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            target_port \u003d port[\u0027targetPort\u0027]"},{"line_number":1095,"context_line":"            sg_rule_name \u003d \"%s:%s:%s\" % (lbaas_name, port_protocol, lbaas_port)"},{"line_number":1096,"context_line":"            listener_id \u003d lsnr_ids.get((port_protocol, target_port))"},{"line_number":1097,"context_line":"            self._apply_members_security_groups(lbaas_obj, lbaas_port,"},{"line_number":1098,"context_line":"                                                target_port, port_protocol,"},{"line_number":1099,"context_line":"                                                sg_rule_name, listener_id, sgs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_3e97993c","line":1099,"range":{"start_line":1097,"start_character":0,"end_line":1099,"end_character":79},"updated":"2020-01-13 07:43:40.000000000","message":"What will happen, if for some reason listener_id will be None?","commit_id":"b289cba317b8b68e4d4f816173ef715cb6e79af9"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e23f9412c90aaf927b22f943ba0f834df4aa504c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        #         fixed one day."},{"line_number":74,"context_line":"        v \u003d self.get_octavia_version()"},{"line_number":75,"context_line":"        if v \u003e\u003d _OCTAVIA_ACL_VERSION:"},{"line_number":76,"context_line":"            self._octavia_acls \u003d True"},{"line_number":77,"context_line":"        if v \u003e\u003d _OCTAVIA_TAGGING_VERSION:"},{"line_number":78,"context_line":"            LOG.info(\u0027Octavia supports resource tags.\u0027)"},{"line_number":79,"context_line":"            self._octavia_tags \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_dffd1c0a","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":37},"updated":"2020-01-13 15:44:13.000000000","message":"It might be useful to LOG the info of ACL being supported.","commit_id":"48a7c7101db3a2918f00035dff854b2711a87f90"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e23f9412c90aaf927b22f943ba0f834df4aa504c","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            target_port \u003d port[\u0027targetPort\u0027]"},{"line_number":1095,"context_line":"            sg_rule_name \u003d \"%s:%s:%s\" % (lbaas_name, port_protocol, lbaas_port)"},{"line_number":1096,"context_line":"            listener_id \u003d lsnr_ids.get((port_protocol, target_port))"},{"line_number":1097,"context_line":"            if not listener_id:"},{"line_number":1098,"context_line":"                LOG.warning(\"There is no listener associated to the protocol \""},{"line_number":1099,"context_line":"                            \"%s and port %s. Skipping\", port_protocol,"},{"line_number":1100,"context_line":"                            lbaas_port)"},{"line_number":1101,"context_line":"                continue"},{"line_number":1102,"context_line":"            self._apply_members_security_groups(lbaas_obj, lbaas_port,"},{"line_number":1103,"context_line":"                                                target_port, port_protocol,"},{"line_number":1104,"context_line":"                                                sg_rule_name, listener_id, sgs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_3a923e4c","line":1101,"range":{"start_line":1097,"start_character":0,"end_line":1101,"end_character":24},"updated":"2020-01-13 15:44:13.000000000","message":"Perhaps it\u0027s better to handle this case only when the listener_id is important, which is at the _create_listeners_acls method.\n\nShouldn\u0027t we retry the update instead of skipping? I believe that eventually a listener will get created for the port and protocol.","commit_id":"48a7c7101db3a2918f00035dff854b2711a87f90"}]}