)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"dbe3bb315f85bc9722fa729b412ffa1fdc09e3f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure lb SG is not updated on member creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whe enforce_sg_rules is not set member creation should not trigger"},{"line_number":10,"context_line":"loadbalancer security group rules update. This patch ensures the"},{"line_number":11,"context_line":"action is not triggered in such a case."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_9a673ded","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2020-01-21 08:47:02.000000000","message":"When","commit_id":"a2bc14ca4485e0c206167103776e735ec226f2e1"}],"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"32101ab59e4ade4ddfbe930115df325e23ed6b35","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                                          self._create_member,"},{"line_number":597,"context_line":"                                          self._find_member)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        network_policy \u003d ("},{"line_number":600,"context_line":"            \u0027policy\u0027 in CONF.kubernetes.enabled_handlers and"},{"line_number":601,"context_line":"            CONF.kubernetes.service_security_groups_driver \u003d\u003d \u0027policy\u0027)"},{"line_number":602,"context_line":"        if (network_policy and CONF.octavia_defaults.enforce_sg_rules and"},{"line_number":603,"context_line":"                listener_port):"},{"line_number":604,"context_line":"            protocol \u003d pool.protocol"},{"line_number":605,"context_line":"            sg_rule_name \u003d pool.name"},{"line_number":606,"context_line":"            listener_id \u003d pool.listener_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_79b636ff","line":603,"range":{"start_line":599,"start_character":0,"end_line":603,"end_character":31},"updated":"2020-01-17 13:27:41.000000000","message":"It is quite long condition, so maybe:\n\n        if (\u0027policy\u0027 in CONF.kubernetes.enabled_handlers and\n            CONF.kubernetes.service_security_groups_driver \u003d\u003d \u0027policy\u0027 and\n            CONF.octavia_defaults.enforce_sg_rules and listener_port):\n            ...\n\nor\n\n        network_policy \u003d (\n            \u0027policy\u0027 in CONF.kubernetes.enabled_handlers and\n            CONF.kubernetes.service_security_groups_driver \u003d\u003d \u0027policy\u0027)\n        enforce_sg_rules \u003d CONF.octavia_defaults.enforce_sg_rules\n\n        if network_policy and enforce_sg_rules and listener_port:\n            ...\n\nnot sure which one is better for humans to parse…","commit_id":"efefad22cb82a7672661f81b8c6bb047adc89551"}]}