)]}'
{"kuryr_kubernetes/controller/drivers/nested_macvlan_vif.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5cf2db703b9179e3603c401074f15526653666ad","unresolved":false,"context_lines":[{"line_number":182,"context_line":"def _tag_neutron_port(res_id):"},{"line_number":183,"context_line":"    tags \u003d CONF.neutron_defaults.resource_tags"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if not tags:"},{"line_number":186,"context_line":"        return"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    neutron \u003d clients.get_neutron_client()"},{"line_number":189,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0b405e04","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":14},"updated":"2020-01-30 12:29:24.000000000","message":"To avoid this return you could determine the execution of this method only when tags exist, and pass them as parameter.","commit_id":"11b0d08c33fc371b7160d7a1dd2ffa058bc7d85c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"eb55c7fc9bb01ac92c26336df80103747b393238","unresolved":false,"context_lines":[{"line_number":182,"context_line":"def _tag_neutron_port(res_id):"},{"line_number":183,"context_line":"    tags \u003d CONF.neutron_defaults.resource_tags"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if not tags:"},{"line_number":186,"context_line":"        return"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    neutron \u003d clients.get_neutron_client()"},{"line_number":189,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8e253cb0","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":14},"in_reply_to":"3fa7e38b_0b405e04","updated":"2020-01-30 13:07:20.000000000","message":"Very well.","commit_id":"11b0d08c33fc371b7160d7a1dd2ffa058bc7d85c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"0c5e081a5b9d40772c5d001870efe978ce24a9a5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"def _tag_neutron_port(res_id):"},{"line_number":183,"context_line":"    tags \u003d CONF.neutron_defaults.resource_tags"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if not tags:"},{"line_number":186,"context_line":"        return"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    neutron \u003d clients.get_neutron_client()"},{"line_number":189,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_aedef868","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":14},"in_reply_to":"3fa7e38b_8e253cb0","updated":"2020-01-30 13:13:36.000000000","message":"On second thought - I\u0027d like to have some logic here, instead of passing config thingy as an argument. The other method for openstacksdk have the same check, so I\u0027ll leave it here.","commit_id":"11b0d08c33fc371b7160d7a1dd2ffa058bc7d85c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4937eccfddd6e60a32af3398245ce640d20b8b90","unresolved":false,"context_lines":[{"line_number":182,"context_line":"def _tag_neutron_port(res_id):"},{"line_number":183,"context_line":"    tags \u003d CONF.neutron_defaults.resource_tags"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if not tags:"},{"line_number":186,"context_line":"        return"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    neutron \u003d clients.get_neutron_client()"},{"line_number":189,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_bd829e01","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":14},"in_reply_to":"3fa7e38b_8ed0dc2c","updated":"2020-02-03 11:57:07.000000000","message":"Quick return is fine, I think. Mostly a matter of preference, but sometimes having one less indent is handy.","commit_id":"11b0d08c33fc371b7160d7a1dd2ffa058bc7d85c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"ed4ed72d7d3305167eb909b7965344ec43c7a648","unresolved":false,"context_lines":[{"line_number":182,"context_line":"def _tag_neutron_port(res_id):"},{"line_number":183,"context_line":"    tags \u003d CONF.neutron_defaults.resource_tags"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if not tags:"},{"line_number":186,"context_line":"        return"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    neutron \u003d clients.get_neutron_client()"},{"line_number":189,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8ed0dc2c","line":186,"range":{"start_line":185,"start_character":0,"end_line":186,"end_character":14},"in_reply_to":"3fa7e38b_aedef868","updated":"2020-01-30 13:20:50.000000000","message":"okay.","commit_id":"11b0d08c33fc371b7160d7a1dd2ffa058bc7d85c"}]}