)]}'
{"kuryr_kubernetes/controller/drivers/network_policy_security_groups.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"25bee54d0aa1760adef17587d1ff4856a504d26b","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                    if sg_rule not in crd_rules:"},{"line_number":320,"context_line":"                        crd_rules.append(sg_rule)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            ns_pods \u003d driver_utils.get_pods(ns_selector).get(\u0027items\u0027)"},{"line_number":323,"context_line":"            ns_cidr \u003d driver_utils.get_namespace_subnet_cidr(namespace)"},{"line_number":324,"context_line":"            if \u0027ports\u0027 in rule_block:"},{"line_number":325,"context_line":"                for port in rule_block[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_af2d94a9","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":69},"updated":"2020-02-24 11:11:07.000000000","message":"Maybe a fallback would be sufficient in case there is no items?\n\n    driver_utils.get_pods(ns_selector).get(\u0027items\u0027, [])\n\nsince in _create_sg_rule_on_text_port method, we simply iterate over the pods.","commit_id":"6564e04fc2ea8effea55f2613e3714538d65eebf"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"2144178a271ff6a71d465d4199a5c81d4be6a060","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                    if sg_rule not in crd_rules:"},{"line_number":320,"context_line":"                        crd_rules.append(sg_rule)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            ns_pods \u003d driver_utils.get_pods(ns_selector).get(\u0027items\u0027)"},{"line_number":323,"context_line":"            ns_cidr \u003d driver_utils.get_namespace_subnet_cidr(namespace)"},{"line_number":324,"context_line":"            if \u0027ports\u0027 in rule_block:"},{"line_number":325,"context_line":"                for port in rule_block[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_8288af71","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":69},"in_reply_to":"1fa4df85_2221bba0","updated":"2020-02-24 11:31:11.000000000","message":"I understand, although if we are certain about existence of \u0027items\u0027 key, why using .get() instead of simply getting items directly?, like:\n\n    driver_utils.get_pods(ns_selector)[\u0027items\u0027]","commit_id":"6564e04fc2ea8effea55f2613e3714538d65eebf"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"cda3c87341a7d1eacbe48192074001780e74859d","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                    if sg_rule not in crd_rules:"},{"line_number":320,"context_line":"                        crd_rules.append(sg_rule)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            ns_pods \u003d driver_utils.get_pods(ns_selector).get(\u0027items\u0027)"},{"line_number":323,"context_line":"            ns_cidr \u003d driver_utils.get_namespace_subnet_cidr(namespace)"},{"line_number":324,"context_line":"            if \u0027ports\u0027 in rule_block:"},{"line_number":325,"context_line":"                for port in rule_block[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_059fe950","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":69},"in_reply_to":"1fa4df85_8288af71","updated":"2020-02-24 12:11:43.000000000","message":"good point, thanks!","commit_id":"6564e04fc2ea8effea55f2613e3714538d65eebf"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"ba2ea7538de70aed5f9c0e3eb0b2ee14080f0361","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                    if sg_rule not in crd_rules:"},{"line_number":320,"context_line":"                        crd_rules.append(sg_rule)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            ns_pods \u003d driver_utils.get_pods(ns_selector).get(\u0027items\u0027)"},{"line_number":323,"context_line":"            ns_cidr \u003d driver_utils.get_namespace_subnet_cidr(namespace)"},{"line_number":324,"context_line":"            if \u0027ports\u0027 in rule_block:"},{"line_number":325,"context_line":"                for port in rule_block[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_2221bba0","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":69},"in_reply_to":"1fa4df85_af2d94a9","updated":"2020-02-24 11:18:53.000000000","message":"as the result is a list, it would have the following format when empty:\n\n{\n  \"kind\": \"PodList\",\n  \"apiVersion\": \"v1\",\n  \"metadata\": {\n    \"selfLink\": \"/api/v1/pods\",\n    \"resourceVersion\": \"696171\"\n  },\n  \"items\": []\n}\n\nSo, we\u0027re safe.","commit_id":"6564e04fc2ea8effea55f2613e3714538d65eebf"}]}