)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"91d3bfd9f9ebc50b446f289989b8d14ed101975c","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        if not response.ok:"},{"line_number":499,"context_line":"            LOG.error(\u0027Error when creating %s: %s\u0027, resource.resource_key,"},{"line_number":500,"context_line":"                      response.text)"},{"line_number":501,"context_line":"            response.raise_for_status()"},{"line_number":502,"context_line":"        response_dict \u003d response.json()[resource.resource_key]"},{"line_number":503,"context_line":"        return resource(**response_dict)"},{"line_number":504,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_423cc992","side":"PARENT","line":501,"range":{"start_line":501,"start_character":12,"end_line":501,"end_character":39},"updated":"2020-02-26 14:15:26.000000000","message":"Here!","commit_id":"0ff30ac053276151caca379ffd69f1b5da902d3d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5e703f63acd5d822c23fb865c7ef0a4b8156038d","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self.add_tags(\u0027loadbalancer\u0027, request)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":494,"context_line":"        response \u003d lbaas.create_load_balancer(**request)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        loadbalancer.id \u003d response.id"},{"line_number":497,"context_line":"        loadbalancer.port_id \u003d self._get_vip_port(loadbalancer).id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6e48d1cb","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":56},"updated":"2020-02-26 13:43:50.000000000","message":"we would need try/except for the calls now","commit_id":"b75f3ffbb4dcf889c8beab44e1a4762dc056672e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8667e87eb898e84cc9508057dc11a2bb6fab3076","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self.add_tags(\u0027loadbalancer\u0027, request)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":494,"context_line":"        response \u003d lbaas.create_load_balancer(**request)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        loadbalancer.id \u003d response.id"},{"line_number":497,"context_line":"        loadbalancer.port_id \u003d self._get_vip_port(loadbalancer).id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_420a89d2","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":56},"in_reply_to":"1fa4df85_22374db3","updated":"2020-02-26 14:16:58.000000000","message":"Hm, we don\u0027t import requests.exceptions anywhere, so we should be fine…","commit_id":"b75f3ffbb4dcf889c8beab44e1a4762dc056672e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"91d3bfd9f9ebc50b446f289989b8d14ed101975c","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self.add_tags(\u0027loadbalancer\u0027, request)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        lbaas \u003d clients.get_loadbalancer_client()"},{"line_number":494,"context_line":"        response \u003d lbaas.create_load_balancer(**request)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        loadbalancer.id \u003d response.id"},{"line_number":497,"context_line":"        loadbalancer.port_id \u003d self._get_vip_port(loadbalancer).id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_22374db3","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":56},"in_reply_to":"1fa4df85_6e48d1cb","updated":"2020-02-26 14:15:26.000000000","message":"Previous code was raising exceptions that were not caught here too. See my comment on removed code. The difference is method was probably raising exceptions from requests, I\u0027ll see if we depend on them somewhere.","commit_id":"b75f3ffbb4dcf889c8beab44e1a4762dc056672e"}]}