)]}'
{"kuryr_kubernetes/constants.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"cc886acb8ee578bcd098c28b79d5c8ed4603e54a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"NEUTRON_LBAAS_HAPROXY_PROVIDER \u003d \u0027haproxy\u0027"},{"line_number":69,"context_line":"NEUTRON_IPV4_ETHERTYPE \u003d \u0027IPv4\u0027"},{"line_number":70,"context_line":"NEUTRON_IPV6_ETHERTYPE \u003d \u0027IPv6\u0027"},{"line_number":71,"context_line":"NEUTRON_IPV6_VERSION \u003d 6"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"VIF_POOL_POPULATE \u003d \u0027/populatePool\u0027"},{"line_number":74,"context_line":"VIF_POOL_FREE \u003d \u0027/freePool\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_497e0e6c","line":71,"updated":"2020-02-28 12:28:30.000000000","message":"how about:\n\n  IPv4 \u003d \u0027IPv4\u0027\n  IPv6 \u003d \u0027IPv6\u0027\n  IP_VERSION_4 \u003d 4\n  IP_VERSION_6 \u003d 6\n\nso exaclty the same as in the neuron_lib.constants? It\u0027s rather universal values, no?","commit_id":"fe5e245be6516ab06fbab7d467df1e124e0913f5"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a4a7e63a8246a458deb763180f7ee14cd94830c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"NEUTRON_LBAAS_HAPROXY_PROVIDER \u003d \u0027haproxy\u0027"},{"line_number":69,"context_line":"NEUTRON_IPV4_ETHERTYPE \u003d \u0027IPv4\u0027"},{"line_number":70,"context_line":"NEUTRON_IPV6_ETHERTYPE \u003d \u0027IPv6\u0027"},{"line_number":71,"context_line":"NEUTRON_IPV6_VERSION \u003d 6"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"VIF_POOL_POPULATE \u003d \u0027/populatePool\u0027"},{"line_number":74,"context_line":"VIF_POOL_FREE \u003d \u0027/freePool\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_dfb38c4c","line":71,"in_reply_to":"1fa4df85_497e0e6c","updated":"2020-02-28 14:11:18.000000000","message":"Done","commit_id":"fe5e245be6516ab06fbab7d467df1e124e0913f5"}],"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5d009e44bdf7bb3e3997029b1b85ef8cde69591e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                                port_range_min\u003dport,"},{"line_number":321,"context_line":"                                port_range_max\u003dport,"},{"line_number":322,"context_line":"                                protocol\u003dprotocol,"},{"line_number":323,"context_line":"                                remote_ip_prefix\u003drule.remote_ip_prefix,"},{"line_number":324,"context_line":"                                security_group_id\u003dlb_sg,"},{"line_number":325,"context_line":"                                description\u003dsg_rule_name)"},{"line_number":326,"context_line":"                        except os_exc.ConflictException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_972182fe","line":323,"range":{"start_line":323,"start_character":49,"end_line":323,"end_character":70},"updated":"2020-02-28 09:16:18.000000000","message":"Can\u0027t we decide based on this? IMO Neutron should just do it for us, but well, it\u0027s not a perfect world. ;)","commit_id":"aae94f41d2d760ea9fa88aa29963e553edb59acd"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"cc886acb8ee578bcd098c28b79d5c8ed4603e54a","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                port_range_min\u003dport,"},{"line_number":322,"context_line":"                                port_range_max\u003dport,"},{"line_number":323,"context_line":"                                protocol\u003dprotocol,"},{"line_number":324,"context_line":"                                remote_ip_prefix\u003drule.remote_ip_prefix,"},{"line_number":325,"context_line":"                                security_group_id\u003dlb_sg,"},{"line_number":326,"context_line":"                                description\u003dsg_rule_name)"},{"line_number":327,"context_line":"                        except os_exc.ConflictException:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_e94fba31","line":324,"range":{"start_line":324,"start_character":32,"end_line":324,"end_character":71},"updated":"2020-02-28 12:28:30.000000000","message":"Is it possible, that even if we have LB placed on service subnet on ipv4, still, there could be rules which are related to ipv6? Or am I talking nonsense?","commit_id":"fe5e245be6516ab06fbab7d467df1e124e0913f5"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a4a7e63a8246a458deb763180f7ee14cd94830c3","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                port_range_min\u003dport,"},{"line_number":322,"context_line":"                                port_range_max\u003dport,"},{"line_number":323,"context_line":"                                protocol\u003dprotocol,"},{"line_number":324,"context_line":"                                remote_ip_prefix\u003drule.remote_ip_prefix,"},{"line_number":325,"context_line":"                                security_group_id\u003dlb_sg,"},{"line_number":326,"context_line":"                                description\u003dsg_rule_name)"},{"line_number":327,"context_line":"                        except os_exc.ConflictException:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_9c1762a4","line":324,"range":{"start_line":324,"start_character":32,"end_line":324,"end_character":71},"in_reply_to":"1fa4df85_e94fba31","updated":"2020-02-28 14:11:18.000000000","message":"As right know our goal is to support either IPv4 or IPv6 this wouldn\u0027t be possible. From my understanding, if the service subnet has IPv6, the subnetpool should have as well, thus the sg rule would be IPv6.","commit_id":"fe5e245be6516ab06fbab7d467df1e124e0913f5"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fc0af8db6b4164f0d5fdfccc9f03857180d19356","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                port_range_min\u003dport,"},{"line_number":322,"context_line":"                                port_range_max\u003dport,"},{"line_number":323,"context_line":"                                protocol\u003dprotocol,"},{"line_number":324,"context_line":"                                remote_ip_prefix\u003drule.remote_ip_prefix,"},{"line_number":325,"context_line":"                                security_group_id\u003dlb_sg,"},{"line_number":326,"context_line":"                                description\u003dsg_rule_name)"},{"line_number":327,"context_line":"                        except os_exc.ConflictException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_bfc9f078","line":324,"range":{"start_line":324,"start_character":49,"end_line":324,"end_character":70},"updated":"2020-02-28 14:28:41.000000000","message":"Why can\u0027t we spare the call to neutron and just use ipaddress library on this rule?\n\n In [1]: import ipaddress                       \n In [2]: n \u003d ipaddress.ip_network(\u002710.0.0.0/24\u0027) \n In [3]: n.version                              \n Out[3]: 4\n In [4]: n \u003d ipaddress.ip_network(\u00272001:db8:1234::/48\u0027)                                         \n In [5]: n.version                              \n Out[5]: 6","commit_id":"a7602340a990516fef159c483699f5d86143fee1"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2307ee376ddb5c0d987c886f50d994e5776ea11a","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                port_range_min\u003dport,"},{"line_number":322,"context_line":"                                port_range_max\u003dport,"},{"line_number":323,"context_line":"                                protocol\u003dprotocol,"},{"line_number":324,"context_line":"                                remote_ip_prefix\u003drule.remote_ip_prefix,"},{"line_number":325,"context_line":"                                security_group_id\u003dlb_sg,"},{"line_number":326,"context_line":"                                description\u003dsg_rule_name)"},{"line_number":327,"context_line":"                        except os_exc.ConflictException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_9f2e74f8","line":324,"range":{"start_line":324,"start_character":49,"end_line":324,"end_character":70},"in_reply_to":"1fa4df85_bfc9f078","updated":"2020-02-28 14:42:57.000000000","message":"Done","commit_id":"a7602340a990516fef159c483699f5d86143fee1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c2921377dc8f1bb1e56fda9d829f9f64f642ba92","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                                                  max_port+1)):"},{"line_number":310,"context_line":"                            continue"},{"line_number":311,"context_line":"                        all_pod_rules.append(rule)"},{"line_number":312,"context_line":"                        sg_rule_ethertype \u003d ipaddress.ip_network("},{"line_number":313,"context_line":"                            rule.remote_ip_prefix)"},{"line_number":314,"context_line":"                        try:"},{"line_number":315,"context_line":"                            LOG.debug(\"Creating LBaaS sg rule for sg: %r\","},{"line_number":316,"context_line":"                                      lb_sg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_5a5faa71","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":50},"updated":"2020-02-28 15:39:37.000000000","message":"You probably need \".version\" here. ;)","commit_id":"c8a36d814ca899b84d701c17148a86c6411dfca9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c2921377dc8f1bb1e56fda9d829f9f64f642ba92","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            self._delete_rule_if_no_match(rule, all_pod_rules)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if add_default_rules:"},{"line_number":346,"context_line":"            sg_rule_ethertype \u003d k_const.IPv4"},{"line_number":347,"context_line":"            if utils.get_service_subnet_version() \u003d\u003d k_const.IP_VERSION_6:"},{"line_number":348,"context_line":"                sg_rule_ethertype \u003d k_const.IPv6"},{"line_number":349,"context_line":"            try:"},{"line_number":350,"context_line":"                LOG.debug(\"Restoring default LBaaS sg rule for sg: %r\", lb_sg)"},{"line_number":351,"context_line":"                os_net.create_security_group_rule(direction\u003d\u0027ingress\u0027,"},{"line_number":352,"context_line":"                                                  ether_type\u003dsg_rule_ethertype,"},{"line_number":353,"context_line":"                                                  port_range_min\u003dport,"},{"line_number":354,"context_line":"                                                  port_range_max\u003dport,"},{"line_number":355,"context_line":"                                                  protocol\u003dprotocol,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_7a62a640","line":352,"range":{"start_line":346,"start_character":0,"end_line":352,"end_character":79},"updated":"2020-02-28 15:39:37.000000000","message":"Ah, right. Anyway still better to do it this way, I think.","commit_id":"c8a36d814ca899b84d701c17148a86c6411dfca9"}]}