)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e0ae1c6c5c65614e174622be6307a5937e2ec525","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            os_listener \u003d next(response)"},{"line_number":582,"context_line":"            listener.id \u003d os_listener.id"},{"line_number":583,"context_line":"            if os_listener.provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":584,"context_line":"                LOG.debug(\"Releasing listener %s\", os_listener.id)"},{"line_number":585,"context_line":"                self.release_listener(loadbalancer, listener)"},{"line_number":586,"context_line":"                return None"},{"line_number":587,"context_line":"        except (KeyError, StopIteration):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_f865df46","line":584,"range":{"start_line":584,"start_character":0,"end_line":584,"end_character":66},"updated":"2020-05-26 12:34:14.000000000","message":"Could be nice to say why it\u0027s being released, but not a big deal if it\u0027s the only place we log such message.","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"42f8b5c559fbdcba03bbd96821b50513d12c798d","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                         in {listener[\u0027id\u0027] for listener in p.listeners}]"},{"line_number":621,"context_line":"            else:"},{"line_number":622,"context_line":"                pools \u003d [p for p in response if pool.name \u003d\u003d p.name]"},{"line_number":623,"context_line":"            pool.id \u003d pools[0].id"},{"line_number":624,"context_line":"            if pools[0].provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":625,"context_line":"                LOG.debug(\"Releasing pool %s\", pool.id)"},{"line_number":626,"context_line":"                self.release_pool(loadbalancer, pool)"},{"line_number":627,"context_line":"                return None"},{"line_number":628,"context_line":"        except (KeyError, IndexError):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_2edf8dd6","line":625,"range":{"start_line":623,"start_character":0,"end_line":625,"end_character":55},"updated":"2020-05-19 06:42:00.000000000","message":"worth to add a comment about assuming only one pool per listener","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"42f8b5c559fbdcba03bbd96821b50513d12c798d","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        try:"},{"line_number":660,"context_line":"            os_members \u003d next(response)"},{"line_number":661,"context_line":"            member.id \u003d os_members.id"},{"line_number":662,"context_line":"            if os_members.provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":663,"context_line":"                LOG.debug(\"Releasing Member %s\", os_members.id)"},{"line_number":664,"context_line":"                self.release_member(loadbalancer, member)"},{"line_number":665,"context_line":"                return None"},{"line_number":666,"context_line":"        except (KeyError, StopIteration):"},{"line_number":667,"context_line":"            return None"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_ee01153a","line":665,"range":{"start_line":661,"start_character":0,"end_line":665,"end_character":27},"updated":"2020-05-19 06:42:00.000000000","message":"I\u0027m not that sure about this one... probably for our case k8s will detect the dead pod/endpoint and remove the member. Otherwise, perhaps needs to stay?","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"98d1e7ed2f0d593a0f8f2d7ffb521c60e7942c10","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        try:"},{"line_number":660,"context_line":"            os_members \u003d next(response)"},{"line_number":661,"context_line":"            member.id \u003d os_members.id"},{"line_number":662,"context_line":"            if os_members.provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":663,"context_line":"                LOG.debug(\"Releasing Member %s\", os_members.id)"},{"line_number":664,"context_line":"                self.release_member(loadbalancer, member)"},{"line_number":665,"context_line":"                return None"},{"line_number":666,"context_line":"        except (KeyError, StopIteration):"},{"line_number":667,"context_line":"            return None"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_daf4aff3","line":665,"range":{"start_line":661,"start_character":0,"end_line":665,"end_character":27},"in_reply_to":"ff570b3c_0a438eb0","updated":"2020-05-20 07:47:18.000000000","message":"right... I was thinking on member in ERROR due to endpoint not being reachable, rather than just the octavia side being broken","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e0ae1c6c5c65614e174622be6307a5937e2ec525","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        try:"},{"line_number":660,"context_line":"            os_members \u003d next(response)"},{"line_number":661,"context_line":"            member.id \u003d os_members.id"},{"line_number":662,"context_line":"            if os_members.provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":663,"context_line":"                LOG.debug(\"Releasing Member %s\", os_members.id)"},{"line_number":664,"context_line":"                self.release_member(loadbalancer, member)"},{"line_number":665,"context_line":"                return None"},{"line_number":666,"context_line":"        except (KeyError, StopIteration):"},{"line_number":667,"context_line":"            return None"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_f8c15fe6","line":665,"range":{"start_line":661,"start_character":0,"end_line":665,"end_character":27},"in_reply_to":"ff570b3c_daf4aff3","updated":"2020-05-26 12:34:14.000000000","message":"I strongly doubt K8s would figure it out, to me its role is just to write IPs of the pods that match selector into the Endpoints object. I don\u0027t think it tries to probe them, it wouldn\u0027t even had ability to do it as there\u0027s no guarantee any K8s service has access to pod subnet.","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5751ceb16dfd339d912df9c9170f349b0af216d2","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        try:"},{"line_number":660,"context_line":"            os_members \u003d next(response)"},{"line_number":661,"context_line":"            member.id \u003d os_members.id"},{"line_number":662,"context_line":"            if os_members.provisioning_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":663,"context_line":"                LOG.debug(\"Releasing Member %s\", os_members.id)"},{"line_number":664,"context_line":"                self.release_member(loadbalancer, member)"},{"line_number":665,"context_line":"                return None"},{"line_number":666,"context_line":"        except (KeyError, StopIteration):"},{"line_number":667,"context_line":"            return None"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_0a438eb0","line":665,"range":{"start_line":661,"start_character":0,"end_line":665,"end_character":27},"in_reply_to":"ff570b3c_ee01153a","updated":"2020-05-19 12:33:11.000000000","message":"How would k8s detected that the member is with ERROR if by any chance the respective pod might be running?","commit_id":"f8a315a080095a3f3321da846431ded25d800dae"}]}