)]}'
{"kuryr_kubernetes/cni/binding/vhostuser.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"26a52f4f57e2d5dae57df619b015fd34bfe12d3e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        try:"},{"line_number":119,"context_line":"            os.remove(vhu_sock_path)"},{"line_number":120,"context_line":"        except Exception as err:"},{"line_number":121,"context_line":"            LOG.error(\"failed to delete socket: {0}\".format(err))"},{"line_number":122,"context_line":"        os.remove(conf_file_path)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def is_healthy(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_d71f6369","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":65},"updated":"2020-03-10 10:20:25.000000000","message":"Logs don\u0027t have to get explicitly formatted strings, i.e.\n\n    LOG.error(\"failed to delete socket: %s\", err)","commit_id":"c7abbc20422e1e10ece2d49c0eae7e1f93deb65f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"af4cd14c691dae8684cdeccc5c8356003cbb6687","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            os.remove(vhu_sock_path)"},{"line_number":119,"context_line":"        except Exception as err:"},{"line_number":120,"context_line":"            LOG.error(\"failed to delete socket: {0}\".format(err))"},{"line_number":121,"context_line":"        os.remove(config_file_path)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def is_alive(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_6909b82f","line":120,"range":{"start_line":120,"start_character":11,"end_line":120,"end_character":65},"updated":"2020-03-13 09:44:37.000000000","message":"Why changing back to using format method? The way how it was on PS9 was coherent with other LOG usages…","commit_id":"78f42bd97576870dd5f112bc7b584ea9380afb09"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"05309e92f259ffea6905c3b1ca0778fa74d97e62","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            os.remove(vhu_sock_path)"},{"line_number":119,"context_line":"        except Exception as err:"},{"line_number":120,"context_line":"            LOG.error(\"failed to delete socket: {0}\".format(err))"},{"line_number":121,"context_line":"        os.remove(config_file_path)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def is_alive(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_ff5551fb","line":120,"range":{"start_line":120,"start_character":11,"end_line":120,"end_character":65},"in_reply_to":"1fa4df85_6909b82f","updated":"2020-03-13 15:49:42.000000000","message":"Yeah, in LOGs we\u0027re not supposed to use formatting directly, but just give them as subarguments so that when log will not be printed, the formatting will not happen.\n\nLet\u0027s make it something like:\n\n LOG.exception(\"Failed to delete socket %s when processing VIF %s.\", vhu_sock_path, vif.id)","commit_id":"78f42bd97576870dd5f112bc7b584ea9380afb09"}]}