)]}'
{"kuryr_kubernetes/controller/handlers/lbaas.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"69d0a28a314b02eb18ffd6ef7f846f7ead7b5d27","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        # Let\u0027s retrieve again to ensure is updated."},{"line_number":317,"context_line":"        if not lb.security_groups:"},{"line_number":318,"context_line":"            project_id \u003d self._drv_project.get_project(service)"},{"line_number":319,"context_line":"            lb.security_groups \u003d self._drv_sg.get_security_groups(service, project_id)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def _add_new_members(self, endpoints, lbaas_state, lbaas_spec):"},{"line_number":322,"context_line":"        changed \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_a422d4fe","line":319,"updated":"2020-04-17 21:58:31.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"fa03a9d6e8d5e4f62f26e740eb45457bb7e957e5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e89a31582ff2cc83783bdbf71b4b01597f0b8ce5","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        # the endpoint got annotated and the svc haven\u0027t due to controller"},{"line_number":300,"context_line":"        # restarts. For this case, a resourceNotReady exception is raised"},{"line_number":301,"context_line":"        # till the svc gets annotated with a \u0027lbaas_spec\u0027."},{"line_number":302,"context_line":"        if lbaas_spec:"},{"line_number":303,"context_line":"            lbaas_spec_sgs \u003d lbaas_spec.security_groups_ids"},{"line_number":304,"context_line":"        else:"},{"line_number":305,"context_line":"            raise k_exc.ResourceNotReady(svc_link)"},{"line_number":306,"context_line":"        if lb.security_groups and lb.security_groups !\u003d lbaas_spec_sgs:"},{"line_number":307,"context_line":"            sgs \u003d [lb_sg for lb_sg in lb.security_groups"},{"line_number":308,"context_line":"                   if lb_sg not in default_sgs]"},{"line_number":309,"context_line":"            if lbaas_spec_sgs !\u003d default_sgs:"},{"line_number":310,"context_line":"                sgs.extend(lbaas_spec_sgs)"},{"line_number":311,"context_line":"            lb.security_groups \u003d sgs"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(maysams) It\u0027s possible that while the service annotation"},{"line_number":314,"context_line":"        # is added the backend pods on that service are not yet created"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_2ce5f809","line":311,"range":{"start_line":302,"start_character":0,"end_line":311,"end_character":36},"updated":"2020-04-20 06:53:05.000000000","message":"do we need all this now? or should be ok simply executing the new code and get the actual SGs?","commit_id":"a24bc0f8c566a51870d88ab47e7c84cf908b2751"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e89a31582ff2cc83783bdbf71b4b01597f0b8ce5","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # resulting in no security groups retrieved for the service."},{"line_number":316,"context_line":"        # Let\u0027s retrieve again to ensure is updated."},{"line_number":317,"context_line":"        if not lb.security_groups:"},{"line_number":318,"context_line":"            project_id \u003d self._drv_project.get_project(service)"},{"line_number":319,"context_line":"            lb_sgs \u003d self._drv_sg.get_security_groups(service, project_id)"},{"line_number":320,"context_line":"            lb.security_groups \u003d lb_sgs"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_6c16e0f3","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":63},"updated":"2020-04-20 06:53:05.000000000","message":"perhaps worth to do this at __init__ as the project_id is not meant to change","commit_id":"a24bc0f8c566a51870d88ab47e7c84cf908b2751"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8c8d8dcca03c6cddad2b8c62fe5982cc127692a9","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # resulting in no security groups retrieved for the service."},{"line_number":316,"context_line":"        # Let\u0027s retrieve again to ensure is updated."},{"line_number":317,"context_line":"        if not lb.security_groups:"},{"line_number":318,"context_line":"            project_id \u003d self._drv_project.get_project(service)"},{"line_number":319,"context_line":"            lb_sgs \u003d self._drv_sg.get_security_groups(service, project_id)"},{"line_number":320,"context_line":"            lb.security_groups \u003d lb_sgs"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_b59390a3","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":63},"in_reply_to":"3f4c43b2_6c16e0f3","updated":"2020-04-20 20:52:23.000000000","message":"As it requires a service in order to retrieve the project_id, it\u0027s better to handle it here.","commit_id":"a24bc0f8c566a51870d88ab47e7c84cf908b2751"}]}